fix: Adding checks to prevent disallowed hosts from connecting via Elasticsearch plugin #15834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sondermanish
reviewed
Aug 8, 2022
sondermanish
previously approved these changes
Aug 8, 2022
mohanarpit
added
the
Test Plan Approved
|
Approving this with a note that disallowed hosts should be at a common place instead of a per-plugin level. Request you to raise an issue for this so that this doesn't get missed. Thanks! |
trishaanand
approved these changes
Aug 8, 2022
sharat87
added a commit
that referenced
this pull request
Aug 8, 2022
…asticsearch plugin (#15834) ## Description This PR fixes an issue where a potentially malicious user can connect to disallowed hosts from the Elasticsearch plugin within Appsmith. This is because Elasticsearch client SDK is a HTTP interface underneath the hood. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Junits for the following: - create datasource with disallowed host - validate datasource with disallowed host - test datasource with disallowed host ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes (cherry picked from commit c1dbca6) Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Vijetha-Kaja
pushed a commit
that referenced
this pull request
Dec 20, 2022
…asticsearch plugin (#15834) This PR fixes an issue where a potentially malicious user can connect to disallowed hosts from the Elasticsearch plugin within Appsmith. This is because Elasticsearch client SDK is a HTTP interface underneath the hood. - Bug fix (non-breaking change which fixes an issue) - Junits for the following: - create datasource with disallowed host - validate datasource with disallowed host - test datasource with disallowed host - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes (cherry picked from commit c1dbca6) Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a potentially malicious user can connect to disallowed hosts from the Elasticsearch plugin within Appsmith. This is because Elasticsearch client SDK is a HTTP interface underneath the hood.
Type of change
How Has This Been Tested?
Checklist: