fix: welcome tour ending on page refresh #16079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Bug
|
/ok-to-test sha=ca9f077 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2876180813. |
|
/ok-to-test sha=c606b61 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2880017916. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2880017916. Click to view performance test results
|
hetunandu
requested changes
Aug 22, 2022
app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
Show resolved
Hide resolved
| @@ -16,23 +16,41 @@ class LocalStorageNotSupportedError extends Error { | |||
| } | |||
| } | |||
|
|
|||
| export const getLocalStorage = () => { | |||
| const storage = window.localStorage; | |||
| type WebStorageType = "local" | "session"; | |||
There was a problem hiding this comment.
Can we create a new WebStorage or Session storage class instead? Lets not combine these.
There was a problem hiding this comment.
Created two classes LocalStorage and SessionStorage which extends WebStorage as both local and session storage have the same api. https://github.com/appsmithorg/appsmith/pull/16079/files#diff-1e9a43b2c64f5b85db74f40be876df6d9ab7e63b4660387f7330978f050b6d4bR111
|
/ok-to-test sha=fd6c6ca |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2919016127. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2919016127. Click to view performance test results
|
|
/ok-to-test sha=62d40d1 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2925444224. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2925444224. Click to view performance test results
|
hetunandu
approved these changes
Aug 30, 2022
hetunandu
approved these changes
Sep 1, 2022
|
/ok-to-test sha=8567a37 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2977834107. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2977834107. Click to view performance test results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to still have the guided tour running when the current page is refreshed. Note that we don't restore at the initial screen where we show the start building cta. Also we don't restore all states like for e.g focused inputs, if the widget sidebar was open we don't reopen it on refresh etc. but the tour continues to be usable. We also go back a few steps in cases where we cannot resume with the latest step on refresh.
Code changes
Release
release-reload.mov
Post fix
load-from-storage.mov
Fixes #10923
Type of change
How Has This Been Tested?
Cypress
Checklist: