feat: Table widget select column type #16337

sbalaji1192 · 2022-08-26T12:08:25Z

Introduces select column type with server-side filtering

Fixes #6766

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Following cypress tests have been added

should check that the select column is available in the column dropdown options
should check that the editable option is present
should check that options given in the property pane is appearing on the table
should check that the placeholder property is working
should check that filterable property is working
should check that on the option selected is working
should check that server-side filtering is working

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

vercel · 2022-08-26T12:08:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Sep 29, 2022 at 10:07AM (UTC)

github-actions · 2022-08-26T12:09:10Z

Unable to find test scripts. Please add necessary tests to the PR.

sbalaji1192 · 2022-09-06T04:17:17Z

/ok-to-test sha=1c8b3b2

github-actions · 2022-09-06T04:17:43Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2997490721.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1c8b3b2.
PR: 16337.

github-actions · 2022-09-13T13:17:28Z

Unable to find test scripts. Please add necessary tests to the PR.

github-actions · 2022-09-13T13:17:38Z

Unable to find test scripts. Please add necessary tests to the PR.

sbalaji1192 · 2022-09-14T07:21:43Z

/ok-to-test sha=8be1415

github-actions · 2022-09-14T07:36:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3050953764.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8be1415.
PR: 16337.

chandannkumar · 2022-09-20T12:23:09Z

Observations @sbalaji1192

Computed Value property is not available on Property pane of select type column
Widget crashed on filtering select type column
https://www.loom.com/share/5acd27f5771f48a09c664bb68f64250e
Placeholder text is displayed in capital letters. Is this expected?

chandannkumar · 2022-09-22T06:10:22Z

Tested this PR and LGTM

Tested converting existing column to Select type
Tested editing select type column with options added
Tested editing functionalities on Table widget for all column type
Tested for Server Side filtering in select type column
Tested for error messages in Select type column options
Tested JS toggles for each properties
Tested Filters and search functionality

github-actions · 2022-09-27T11:23:41Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3134950348.
Commit: ``.
Results:

Click to view performance test results

	Run 1 _^(ms)	Run 2 _^(ms)	Run 3 _^(ms)	Run 4 _^(ms)	Run 5 _^(ms)	Minimum _^(ms)	Median _^(ms)	Mean _^(ms)	Range _^(%)	SD.Sample _^(%)	SD.Population _^(%)
SELECT_CATEGORY
scripting	410.2	403.62	427.05	339.52	374.74	339.52	403.62	391.03	22.38	8.80	7.88
painting	7.54	3.73	5.38	3.07	6.1	3.07	5.38	5.16	86.63	34.88	31.20
rendering	112.87	118.86	117.04	107.32	113.71	107.32	113.71	113.96	10.13	3.90	3.48
BIND_TABLE_DATA
scripting	1192.14	1133.79	1245.02	1084.83	1163.23	1084.83	1163.23	1163.8	13.76	5.18	4.63
painting	27.15	24.48	31.71	17.1	27.99	17.1	27.15	25.69	56.87	21.21	19.00
rendering	863.72	970.88	955.38	787.02	861.28	787.02	863.72	887.66	20.71	8.53	7.63
CLICK_ON_TABLE_ROW
scripting	1133.03	1044.21	1152.88	879.61	920.24	879.61	1044.21	1025.99	26.63	11.99	10.72
painting	9.35	14.2	19.82	8.3	11.01	8.3	11.01	12.54	91.87	37.00	33.09
rendering	299.47	330.2	368.38	292.62	308.84	292.62	308.84	319.9	23.68	9.56	8.55
UPDATE_POST_TITLE
scripting	1631.7	1640.83	1757.75	1400.86	1569.68	1400.86	1631.7	1600.16	22.30	8.16	7.29
painting	15.88	19.8	20.25	12.78	16.52	12.78	16.52	17.05	43.81	18.01	16.13
rendering	472.19	506.26	523.6	458.51	492.8	458.51	492.8	490.67	13.27	5.30	4.74
OPEN_MODAL
scripting	512.71	498.16	518.32	876.66	504.23	498.16	512.71	582.02	65.03	28.33	25.34
painting	13.99	12.25	17.03	11.68	9.64	9.64	12.25	12.92	57.20	21.44	19.20
rendering	428.56	387.27	412.76	385.47	420.19	385.47	412.76	406.85	10.59	4.80	4.29
CLOSE_MODAL
scripting	215.59	204.23	189.09	182.09	188.96	182.09	189.09	195.99	17.09	6.95	6.21
painting	11.35	14.43	15.1	18.26	12.87	11.35	14.43	14.4	47.99	18.06	16.18
rendering	347.61	360.73	353.63	332.2	343.27	332.2	347.61	347.49	8.21	3.10	2.77
SELECT_WIDGET_MENU_OPEN
scripting	1089.69	1158.37	1011.01	999.46	1055.5	999.46	1055.5	1062.81	14.95	6.06	5.42
painting	14.39	11.3	15.36	11.22	11.76	11.22	11.76	12.81	32.32	15.07	13.51
rendering	704.35	737.46	619.2	619.41	701.22	619.2	701.22	676.33	17.49	7.98	7.14
SELECT_WIDGET_SELECT_OPTION
scripting	176	203.13	161.43	169.01	189.9	161.43	176	179.89	23.18	9.28	8.30
painting	5.04	3.87	3.95	2.64	5.25	2.64	3.95	4.15	62.89	25.30	22.65
rendering	324.77	341.97	311.55	309.94	333.17	309.94	324.77	324.28	9.88	4.25	3.80

sbalaji1192 · 2022-09-28T06:06:14Z

/ok-to-test sha=d655c41

github-actions · 2022-09-28T06:12:03Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3141218656.
Workflow: Appsmith External Integration Test Workflow.
Commit: d655c41.
PR: 16337.

sbalaji1192 · 2022-09-28T09:35:53Z

/ok-to-test sha=e3709ba

github-actions · 2022-09-28T09:36:18Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3142438568.
Workflow: Appsmith External Integration Test Workflow.
Commit: e3709ba.
PR: 16337.

github-actions · 2022-09-28T10:19:33Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3142438568.
Commit: ``.
Results:

Click to view performance test results

	Run 1 _^(ms)	Run 2 _^(ms)	Run 3 _^(ms)	Run 4 _^(ms)	Run 5 _^(ms)	Minimum _^(ms)	Median _^(ms)	Mean _^(ms)	Range _^(%)	SD.Sample _^(%)	SD.Population _^(%)
SELECT_CATEGORY
scripting	384.22	450.45	365.14	385.58	381.9	365.14	384.22	393.46	21.68	8.36	7.48
painting	3.72	7.04	3.94	5.31	5.3	3.72	5.3	5.06	65.61	26.28	23.52
rendering	117.67	117.59	108.07	113.38	110.03	108.07	113.38	113.35	8.47	3.84	3.43
BIND_TABLE_DATA
scripting	1213.36	1050.52	1084	1122.63	1129.15	1050.52	1122.63	1119.93	14.54	5.45	4.88
painting	27.41	25.02	20.24	19.47	28.59	19.47	25.02	24.15	37.76	17.10	15.32
rendering	943.31	834.56	827.74	844.87	883.29	827.74	844.87	866.75	13.33	5.52	4.94
CLICK_ON_TABLE_ROW
scripting	987.68	964.52	1039.53	930.52	1229.38	930.52	987.68	1030.33	29.01	11.47	10.25
painting	11.08	9.36	9.93	9.86	14.35	9.36	9.93	10.92	45.70	18.50	16.58
rendering	315	300.5	319.18	317.01	331.07	300.5	317.01	316.55	9.66	3.45	3.09
UPDATE_POST_TITLE
scripting	1614.3	1551.04	1457.92	1724.47	1913.35	1457.92	1614.3	1652.22	27.56	10.61	9.49
painting	19.19	18.21	20.07	24	18.85	18.21	19.19	20.06	28.86	11.47	10.27
rendering	509.72	473.78	472.33	508.08	529.15	472.33	508.08	498.61	11.40	4.97	4.44
OPEN_MODAL
scripting	489.58	453.71	454.29	496.24	489.47	453.71	489.47	476.66	8.92	4.38	3.91
painting	17.96	10.92	20.13	14.69	14.55	10.92	14.69	15.65	58.85	22.56	20.19
rendering	402.17	384.05	389.33	398.12	404.1	384.05	398.12	395.55	5.07	2.17	1.94
CLOSE_MODAL
scripting	193.19	188.06	190.06	182.1	693.46	182.1	190.06	289.37	176.71	78.08	69.83
painting	5.38	17.7	15.14	4.32	20.81	4.32	15.14	12.67	130.15	58.64	52.41
rendering	351.92	340.69	332.41	343.31	358.37	332.41	343.31	345.34	7.52	2.92	2.61
SELECT_WIDGET_MENU_OPEN
scripting	993.08	991.02	999.03	944.47	1033.32	944.47	993.08	992.18	8.96	3.19	2.86
painting	9.43	8.8	6.74	5.39	10.67	5.39	8.8	8.21	64.31	25.82	23.14
rendering	653.84	616.36	617.93	621.73	710.19	616.36	621.73	644.01	14.57	6.22	5.56
SELECT_WIDGET_SELECT_OPTION
scripting	164.17	159.65	173.21	151.58	171.1	151.58	164.17	163.94	13.19	5.36	4.79
painting	7.11	4.07	12.91	7.89	9.78	4.07	7.89	8.35	105.87	39.28	35.09
rendering	316.77	328.51	309.66	347.95	313.61	309.66	316.77	323.3	11.84	4.79	4.28

sbalaji1192 · 2022-09-29T10:00:28Z

/ok-to-test sha=921df7f

github-actions · 2022-09-29T10:51:53Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3150627807.
Workflow: Appsmith External Integration Test Workflow.
Commit: 921df7f.
PR: 16337.

sbalaji1192 · 2022-09-29T11:07:24Z

/ok-to-test sha=921df7f

github-actions · 2022-09-29T11:07:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3150789626.
Workflow: Appsmith External Integration Test Workflow.
Commit: 921df7f.
PR: 16337.

github-actions · 2022-09-29T11:51:58Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3150789626.
Commit: ``.
Results:

Click to view performance test results

	Run 1 _^(ms)	Run 2 _^(ms)	Run 3 _^(ms)	Run 4 _^(ms)	Run 5 _^(ms)	Minimum _^(ms)	Median _^(ms)	Mean _^(ms)	Range _^(%)	SD.Sample _^(%)	SD.Population _^(%)
SELECT_CATEGORY
scripting	388.02	341.64	383.7	375.35	398.24	341.64	383.7	377.39	15.00	5.73	5.12
painting	3.56	5.35	7.19	3.84	5.06	3.56	5.06	5	72.60	28.80	25.80
rendering	110.29	104.41	123.46	113.91	110.22	104.41	110.29	112.46	16.94	6.25	5.59
BIND_TABLE_DATA
scripting	1260.23	1130.18	1059.88	1570.72	1209.47	1059.88	1209.47	1246.1	41.00	15.80	14.13
painting	39.82	17.24	25.49	26.9	28.55	17.24	26.9	27.6	81.81	29.35	26.27
rendering	948.31	845.41	898.5	581.83	940.45	581.83	898.5	842.9	43.48	17.98	16.08
CLICK_ON_TABLE_ROW
scripting	998.81	1211.97	969.34	982.44	1188.69	969.34	998.81	1070.25	22.67	11.16	9.99
painting	15.87	8.85	12.56	12.17	10.48	8.85	12.17	11.99	58.55	21.85	19.60
rendering	331.74	301.85	305.12	314.98	323.64	301.85	314.98	315.47	9.47	3.96	3.54
UPDATE_POST_TITLE
scripting	1613.53	1310.39	1701.12	1882.52	1790.2	1310.39	1701.12	1659.55	34.48	13.22	11.82
painting	15.51	15.94	24.43	20.65	23.29	15.51	20.65	19.96	44.69	20.59	18.39
rendering	638.65	587.76	651.24	693.42	697.21	587.76	651.24	653.66	16.74	6.86	6.14
OPEN_MODAL
scripting	465.94	489.47	508.78	603.39	562.05	465.94	508.78	525.93	26.13	10.64	9.52
painting	8.76	8.95	11.08	24.7	16	8.76	11.08	13.9	114.68	48.27	43.17
rendering	1208.56	1252.46	1249.14	1471.21	1312.41	1208.56	1252.46	1298.76	20.22	7.95	7.11
CLOSE_MODAL
scripting	220.16	216.58	720.51	288.39	293.87	216.58	288.39	347.9	144.85	60.78	54.37
painting	4.3	10.34	5.39	6.06	6.62	4.3	6.06	6.54	92.35	35.02	31.35
rendering	895.7	925.41	943.53	1058.95	996.13	895.7	943.53	963.94	16.94	6.69	5.98
SELECT_WIDGET_MENU_OPEN
scripting	974.19	996.85	1006.39	1036.38	1078.48	974.19	1006.39	1018.46	10.24	3.96	3.54
painting	5.47	11.71	5.99	6.7	9.06	5.47	6.7	7.79	80.10	33.25	29.65
rendering	684.02	681.43	696.9	724.72	732.21	681.43	696.9	703.86	7.21	3.32	2.97
SELECT_WIDGET_SELECT_OPTION
scripting	182.35	158.03	183.93	177.05	172.87	158.03	177.05	174.85	14.81	5.93	5.31
painting	3.6	5.68	7.32	2.7	4.76	2.7	4.76	4.81	96.05	37.42	33.47
rendering	352.73	314.94	314.91	314.65	314.4	314.4	314.91	322.33	11.89	5.27	4.72

sbalaji1192 marked this pull request as draft August 26, 2022 12:08

vercel bot deployed to Preview – appsmith August 26, 2022 12:09 View deployment

vercel bot deployed to Preview – appsmith August 29, 2022 12:00 View deployment

sbalaji1192 force-pushed the feat/table-select-columntype branch from d85d59d to b54449d Compare August 31, 2022 10:18

vercel bot deployed to Preview – appsmith August 31, 2022 10:19 View deployment

vercel bot deployed to Preview – appsmith September 1, 2022 05:27 View deployment

sbalaji1192 force-pushed the feat/table-select-columntype branch from 4e9f1e8 to 1c8b3b2 Compare September 6, 2022 04:16

vercel bot deployed to Preview – appsmith September 6, 2022 04:17 View deployment

sbalaji1192 force-pushed the feat/table-select-columntype branch from 1c8b3b2 to 9e2fe0e Compare September 13, 2022 11:02

vercel bot deployed to Preview – appsmith September 13, 2022 11:03 View deployment

sbalaji1192 changed the title ~~Feat/table select columntype~~ feat: Table widget select column type Sep 13, 2022

github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Table Widget labels Sep 13, 2022

sbalaji1192 marked this pull request as ready for review September 14, 2022 05:35

vercel bot deployed to Preview – appsmith September 14, 2022 07:21 View deployment

sbalaji1192 force-pushed the feat/table-select-columntype branch from 8be1415 to 7afcef3 Compare September 21, 2022 05:42

vercel bot deployed to Preview – appsmith September 21, 2022 05:43 View deployment

vercel bot deployed to Preview – appsmith September 27, 2022 10:44 View deployment

keyurparalkar previously approved these changes Sep 28, 2022

View reviewed changes

sbalaji1192 dismissed keyurparalkar’s stale review via e3709ba September 28, 2022 09:35

sbalaji1192 force-pushed the feat/table-select-columntype branch from d655c41 to e3709ba Compare September 28, 2022 09:35

vercel bot deployed to Preview – appsmith September 28, 2022 09:36 View deployment

sbalaji1192 added 9 commits September 29, 2022 15:19

feat: Table widget select column type

980f2e8

i

72cbef9

i

50cf8b0

i

5153e00

i

54378df

i

b3ac461

resolve merge conflict

85a81b8

CR callouts

31f5fb0

cypress fix

921df7f

sbalaji1192 force-pushed the feat/table-select-columntype branch from e3709ba to 921df7f Compare September 29, 2022 09:59

vercel bot deployed to Preview – appsmith September 29, 2022 10:00 View deployment

keyurparalkar approved these changes Sep 30, 2022

View reviewed changes

sbalaji1192 merged commit ed1dcca into release Sep 30, 2022

sbalaji1192 deleted the feat/table-select-columntype branch September 30, 2022 04:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Table widget select column type #16337

feat: Table widget select column type #16337

sbalaji1192 commented Aug 26, 2022 •

edited

vercel bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022

sbalaji1192 commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

sbalaji1192 commented Sep 14, 2022

github-actions bot commented Sep 14, 2022

chandannkumar commented Sep 20, 2022 •

edited

chandannkumar commented Sep 22, 2022

github-actions bot commented Sep 27, 2022

sbalaji1192 commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

sbalaji1192 commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

sbalaji1192 commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

sbalaji1192 commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

feat: Table widget select column type #16337

feat: Table widget select column type #16337

Conversation

sbalaji1192 commented Aug 26, 2022 • edited

Type of change

How Has This Been Tested?

Checklist:

vercel bot commented Aug 26, 2022 • edited

github-actions bot commented Aug 26, 2022

sbalaji1192 commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

sbalaji1192 commented Sep 14, 2022

github-actions bot commented Sep 14, 2022

chandannkumar commented Sep 20, 2022 • edited

chandannkumar commented Sep 22, 2022

github-actions bot commented Sep 27, 2022

sbalaji1192 commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

sbalaji1192 commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

sbalaji1192 commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

sbalaji1192 commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

github-actions bot commented Sep 29, 2022

sbalaji1192 commented Aug 26, 2022 •

edited

vercel bot commented Aug 26, 2022 •

edited

chandannkumar commented Sep 20, 2022 •

edited