Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing lint errors in the Cypress code base #16504

Merged
merged 1 commit into from Sep 3, 2022

Conversation

mohanarpit
Copy link
Member

Description

This PR fixes linting errors thrown by eslint in the Cypress code base. Ideally, we shouldn't have any such linting errors.

Type of change

  • Refactoring change

How Has This Been Tested?

  • Since there is no change in actual logic, relying on CI to ensure that all the tests pass.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 3:50PM (UTC)

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 3, 2022
@mohanarpit
Copy link
Member Author

/ok-to-test sha=1faabeb

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2984951230.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1faabeb.
PR: 16504.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2984951230.
Commit: 1faabeb.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 281.22 275.27 273.89 271.83 284.35 275.27 277.31 4.51 1.90 1.70
painting 3.77 3.8 4.09 4.05 4.14 4.05 3.97 9.32 4.28 3.78
rendering 100.93 101.14 102.22 100.03 103.91 101.14 101.65 3.82 1.47 1.31
BIND_TABLE_DATA
scripting 1527.46 1470.87 1488.59 1478.18 1475.41 1478.18 1488.1 3.80 1.54 1.38
painting 12.19 15.74 7.37 12.05 14.65 12.19 12.4 67.50 26.05 23.31
rendering 437.67 424.84 403.18 405.1 420.84 420.84 418.33 8.24 3.44 3.07
CLICK_ON_TABLE_ROW
scripting 721.34 826.98 796.76 797.53 828.74 797.53 794.27 13.52 5.49 4.91
painting 14.05 17.48 11.2 9.69 9.7 11.2 12.42 62.72 26.89 24.07
rendering 294.78 293.5 296.78 286.48 284.67 293.5 291.24 4.16 1.83 1.64
UPDATE_POST_TITLE
scripting 1289.51 894.69 1239.73 1308.97 1259.65 1259.65 1198.51 34.57 14.34 12.83
painting 15.33 9.2 23.14 24.32 12.71 15.33 16.94 89.26 38.84 34.77
rendering 440.06 427.99 443.03 442.92 430.67 440.06 436.93 3.44 1.63 1.46
OPEN_MODAL
scripting 466.7 425.9 496.24 484.96 515.18 484.96 477.8 18.69 7.10 6.35
painting 12.76 10.92 8.92 9.41 7 9.41 9.8 58.78 22.14 19.80
rendering 363.65 347.62 357.06 365.25 369.43 363.65 360.6 6.05 2.36 2.11
CLOSE_MODAL
scripting 271.58 712.67 276.81 282.54 316.14 282.54 371.95 118.59 51.42 45.99
painting 4.74 8.27 12.17 10.97 5.2 8.27 8.27 89.84 40.27 36.03
rendering 317.47 317.98 324.36 318.07 337.95 318.07 323.17 6.34 2.70 2.42
SELECT_WIDGET_MENU_OPEN
scripting 1049.44 1054.12 1052.23 1036.15 1049.63 1049.63 1048.31 1.71 0.67 0.60
painting 11.99 8.98 3.86 4.19 4.84 4.84 6.77 120.09 52.73 47.12
rendering 898.7 880.58 897.11 900.71 892.77 897.11 893.97 2.25 0.90 0.80
SELECT_WIDGET_SELECT_OPTION
scripting 136.38 150.29 141.77 140.39 139.43 140.39 141.65 9.82 3.69 3.30
painting 1.93 3.06 3.7 4.64 2.39 3.06 3.14 86.31 34.08 30.57
rendering 306.62 298.04 294.16 329.33 309.97 306.62 307.62 11.43 4.45 3.98

@mohanarpit mohanarpit added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Sep 3, 2022
@mohanarpit mohanarpit merged commit 7632617 into release Sep 3, 2022
@mohanarpit mohanarpit deleted the chore/fix-lint-errors branch September 3, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants