Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Modularizing the Github actions workflow for maintainability #16505

Merged
merged 38 commits into from Sep 8, 2022

Conversation

mohanarpit
Copy link
Member

Description

This PR refactors the integration-test.yml Github action workflow that is triggered during ok-to-test command. We create centralized workflows for server, client & rts builds. This allows us to create more workflows in the future with ease and without error. It also bring more consistency in the naming convention.

Type of change

  • Refactoring code

How Has This Been Tested?

  • Tested on personal repository

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

arslanhaiderbuttar and others added 30 commits August 30, 2022 10:52
@vercel
Copy link

vercel bot commented Sep 3, 2022

@mohanarpit is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 7:19PM (UTC)

yatinappsmith
yatinappsmith previously approved these changes Sep 5, 2022
@vercel
Copy link

vercel bot commented Sep 6, 2022

Deployment failed with the following error:

Resource is limited - try again in 39 minutes (more than 100, code: "api-deployments-free-per-day").

@mohanarpit
Copy link
Member Author

/ok-to-test sha=4fede75

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3017698435.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4fede75.
PR: 16505.

@mohanarpit mohanarpit merged commit 697bdec into appsmithorg:release Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants