Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Property pane config cleanup #16639

Merged
merged 27 commits into from
Sep 29, 2022
Merged

chore: Property pane config cleanup #16639

merged 27 commits into from
Sep 29, 2022

Conversation

aswathkk
Copy link
Contributor

@aswathkk aswathkk commented Sep 8, 2022

Description

  • Removes unwanted configurations from Widgets
  • Updates widget scaffolding script to make use of property pane config with content & style tabs
  • Remove feature-flag related code from backend

Fixes #15296

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 0:46AM (UTC)

@github-actions github-actions bot added Property Pane Issues related to the behaviour of the property pane UI Builders Pod Issues that UI Builders face using appsmith skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@vercel
Copy link

vercel bot commented Sep 8, 2022

Deployment failed with the following error:

Resource is limited - try again in 3 minutes (more than 100, code: "api-deployments-free-per-day").

@aswathkk
Copy link
Contributor Author

aswathkk commented Sep 9, 2022

/ok-to-test sha=a420af8

ashit-rath
ashit-rath previously approved these changes Sep 12, 2022
app/client/src/utils/WidgetFactory.tsx Outdated Show resolved Hide resolved
@sbalaji1192 sbalaji1192 mentioned this pull request Sep 13, 2022
7 tasks
@aswathkk
Copy link
Contributor Author

/ok-to-test sha=0b4f0d6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3042432314.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0b4f0d6.
PR: 16639.

ashit-rath
ashit-rath previously approved these changes Sep 13, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3090205593.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8ec5b0a.
PR: 16639.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3090205593.
Commit: ``.
Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)|
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
SELECT_CATEGORY| | | | | | | | | | |
| scripting | 343.66 | 371.02 | 424.26 | 354.42 | 379.65 | 343.66| 371.02| 374.6 | 21.52| 8.30 | 7.43|
| painting | 3.01 | 3.06 | 7.21 | 5.93 | 6.32 | 3.01| 5.93| 5.11 | 82.19| 38.16 | 34.05|
| rendering | 102.37 | 105.08 | 115.6 | 109.9 | 113.92 | 102.37| 109.9| 109.37 | 12.10| 5.16 | 4.61|
BIND_TABLE_DATA| | | | | | | | | | |
| scripting | 1267.14 | 1130.07 | 1011.05 | 1103.35 | 1241.24 | 1011.05| 1130.07| 1150.57 | 22.26| 9.11 | 8.15|
| painting | 23.09 | 14.99 | 22 | 22.89 | 28.01 | 14.99| 22.89| 22.2 | 58.65| 20.99 | 18.78|
| rendering | 814.7 | 805.51 | 832.16 | 866.7 | 966.77 | 805.51| 832.16| 857.17 | 18.81| 7.65 | 6.84|
CLICK_ON_TABLE_ROW| | | | | | | | | | |
| scripting | 856.16 | 853.34 | 998.28 | 901.47 | 1018.48 | 853.34| 901.47| 925.55 | 17.84| 8.46 | 7.57|
| painting | 9.01 | 10.76 | 11.1 | 10.08 | 15.49 | 9.01| 10.76| 11.29 | 57.40| 21.97 | 19.66|
| rendering | 295.36 | 295.57 | 317.09 | 318.63 | 321.24 | 295.36| 317.09| 309.58 | 8.36| 4.19 | 3.75|
UPDATE_POST_TITLE| | | | | | | | | | |
| scripting | 1575.31 | 1432.17 | 1458.05 | 1369.72 | 1673.82 | 1369.72| 1458.05| 1501.81 | 20.25| 8.10 | 7.25|
| painting | 16.24 | 15.48 | 16.1 | 26.44 | 25.96 | 15.48| 16.24| 20.04 | 54.69| 28.09 | 25.15|
| rendering | 475.59 | 524.08 | 478.39 | 464.9 | 501.99 | 464.9| 478.39| 488.99 | 12.10| 4.88 | 4.36|
OPEN_MODAL| | | | | | | | | | |
| scripting | 451.42 | 438.24 | 446.77 | 435.65 | 511.11 | 435.65| 446.77| 456.64 | 16.53| 6.81 | 6.09|
| painting | 10.18 | 8.24 | 17.19 | 8.64 | 15.37 | 8.24| 10.18| 11.92 | 75.08| 34.31 | 30.70|
| rendering | 383.43 | 378.78 | 388.49 | 368.54 | 435.84 | 368.54| 383.43| 391.02 | 17.21| 6.68 | 5.97|
CLOSE_MODAL| | | | | | | | | | |
| scripting | 174.23 | 193.36 | 187.38 | 170.69 | 199.5 | 170.69| 187.38| 185.03 | 15.57| 6.65 | 5.95|
| painting | 10.39 | 4.41 | 5.07 | 8.05 | 6.79 | 4.41| 6.79| 6.94 | 86.17| 34.58 | 30.98|
| rendering | 334.44 | 347.01 | 340.05 | 335.58 | 345.04 | 334.44| 340.05| 340.42 | 3.69| 1.64 | 1.46|
SELECT_WIDGET_MENU_OPEN| | | | | | | | | | |
| scripting | 913.05 | 956.37 | 1002.53 | 962.92 | 987.41 | 913.05| 962.92| 964.46 | 9.28| 3.55 | 3.17|
| painting | 5.66 | 6.44 | 5.32 | 7.86 | 7.19 | 5.32| 6.44| 6.49 | 39.14| 16.18 | 14.48|
| rendering | 594.68 | 607.36 | 595.16 | 624.51 | 643.37 | 594.68| 607.36| 613.02 | 7.94| 3.40 | 3.04|
SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | |
| scripting | 164.14 | 189.1 | 161.75 | 160.73 | 202.89 | 160.73| 164.14| 175.72 | 23.99| 10.92 | 9.76|
| painting | 3.64 | 8 | 2.41 | 16.68 | 27.02 | 2.41| 8| 11.55 | 213.07| 89.18 | 79.74|
| rendering | 294.03 | 311.84 | 310.79 | 312.74 | 326.79 | 294.03| 311.84| 311.24 | 10.53| 3.74 | 3.34|

sbalaji1192
sbalaji1192 previously approved these changes Sep 22, 2022
if (styleConfig) {
combinedConfig.push(...styleConfig);
}
if (!contentConfig && !styleConfig) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to L211

if (!map) {
log.error("Widget property pane configs not defined", type);
return [];
if (!map || (map && map.length === 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we removed the error log?

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=a235e8c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3110965168.
Workflow: Appsmith External Integration Test Workflow.
Commit: a235e8c.
PR: 16639.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3110965168.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 357.03 324.15 345.25 432.96 403 324.15 357.03 372.48 29.21 11.94 10.67
painting 4.24 3 3.76 4.52 7.99 3 4.24 4.7 106.17 41.06 36.60
rendering 108.48 104.82 107.05 123.97 110.54 104.82 108.48 110.97 17.26 6.81 6.09
BIND_TABLE_DATA
scripting 1052.14 1071.35 1093.6 1322 1205.81 1052.14 1093.6 1148.98 23.49 9.89 8.84
painting 18.51 13.98 17.7 35.61 26.77 13.98 18.51 22.51 96.09 38.56 34.52
rendering 807.56 798.74 846.21 990.47 929.02 798.74 846.21 874.4 21.93 9.47 8.47
CLICK_ON_TABLE_ROW
scripting 750.76 1134.95 1288.09 1044.88 945.13 750.76 1044.88 1032.76 52.03 19.55 17.48
painting 11.6 11.23 13.19 10.37 10.01 10.01 11.23 11.28 28.19 10.99 9.84
rendering 288.46 294.84 323.6 324.23 299.65 288.46 299.65 306.16 11.68 5.45 4.88
UPDATE_POST_TITLE
scripting 1366.63 1422.57 1415.39 2792.98 1533.05 1366.63 1422.57 1706.12 83.60 35.79 32.01
painting 12.44 12.89 15.84 29.15 14.77 12.44 14.77 17.02 98.18 40.66 36.37
rendering 449.8 452.9 471.61 684.01 455.37 449.8 455.37 502.74 46.59 20.23 18.09
OPEN_MODAL
scripting 409.21 453.21 464.27 546.8 441.23 409.21 453.21 462.94 29.72 11.06 9.89
painting 11.2 14.5 14.29 14.64 12.4 11.2 14.29 13.41 25.65 11.41 10.22
rendering 355.55 363.37 385.49 438.6 376.99 355.55 376.99 384 21.63 8.51 7.61
CLOSE_MODAL
scripting 158.81 195.49 378.04 241.72 195.65 158.81 195.65 233.94 93.71 36.65 32.79
painting 9.88 4.81 8.58 6.11 10.75 4.81 8.58 8.03 73.97 31.26 27.90
rendering 332.82 350.13 528.77 408.48 338.46 332.82 350.13 391.73 50.02 21.01 18.79
SELECT_WIDGET_MENU_OPEN
scripting 919.18 994.78 1094.02 1028.04 981.05 919.18 994.78 1003.41 17.42 6.40 5.72
painting 8.5 6.76 8.52 6.57 10.42 6.57 8.5 8.15 47.24 19.26 17.18
rendering 587.9 616.74 719.96 659.82 606.57 587.9 616.74 638.2 20.69 8.27 7.40
SELECT_WIDGET_SELECT_OPTION
scripting 152.44 150.99 249.77 190.12 265 150.99 190.12 201.66 56.54 26.53 23.73
painting 3.13 3.47 13.95 16.56 4.46 3.13 4.46 8.31 161.61 77.26 69.07
rendering 298.98 301.87 478.76 361.59 344.34 298.98 344.34 357.11 50.34 20.49 18.32

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=89bd97f

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3134580302.
Workflow: Appsmith External Integration Test Workflow.
Commit: 89bd97f.
PR: 16639.

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=7995c6a

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3134866298.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7995c6a.
PR: 16639.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3134866298.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 418.95 332.37 329.22 334.75 340.48 329.22 334.75 351.15 25.55 10.86 9.71
painting 7.88 3.71 6.05 3.03 4.16 3.03 4.16 4.97 97.59 39.84 35.61
rendering 117.1 103.85 101.39 102.4 105.77 101.39 103.85 106.1 14.81 5.99 5.36
BIND_TABLE_DATA
scripting 1177.72 1052.1 1054.7 1109.52 1106.75 1052.1 1106.75 1100.16 11.42 4.66 4.17
painting 24.64 19.75 17.85 13.79 15.43 13.79 17.85 18.29 59.32 23.07 20.61
rendering 894.95 813.47 776.31 794.88 813.56 776.31 813.47 818.63 14.49 5.54 4.96
CLICK_ON_TABLE_ROW
scripting 823.92 848.42 875.1 872.87 849.15 823.92 849.15 853.89 5.99 2.46 2.20
painting 13.84 8.33 9.06 12.39 8.89 8.33 9.06 10.5 52.48 23.33 20.95
rendering 324.74 298.76 305.74 285.9 288.75 285.9 298.76 300.78 12.91 5.17 4.63
UPDATE_POST_TITLE
scripting 1364.17 1382.73 1827.41 1376.09 1369.07 1364.17 1376.09 1463.89 31.64 13.89 12.42
painting 15.38 15.49 28.36 13.32 14.06 13.32 15.38 17.32 86.84 36.03 32.22
rendering 472.25 446.42 432.68 444.19 452.75 432.68 446.42 449.66 8.80 3.24 2.90
OPEN_MODAL
scripting 416.47 417.65 426.78 425.2 415.09 415.09 417.65 420.24 2.78 1.28 1.14
painting 10.19 7.49 12.69 11.64 15.81 7.49 11.64 11.56 71.97 26.56 23.79
rendering 379.06 375.88 365.35 374.71 367.84 365.35 374.71 372.57 3.68 1.54 1.38
CLOSE_MODAL
scripting 204.17 154.85 209.16 173.8 169.21 154.85 173.8 182.24 29.80 12.86 11.50
painting 3.86 17.45 8.05 18.29 16.05 3.86 16.05 12.74 113.27 50.39 45.05
rendering 327.34 319.77 314.68 330.67 342.71 314.68 327.34 327.03 8.57 3.30 2.95
SELECT_WIDGET_MENU_OPEN
scripting 943.04 909.51 966.65 917.78 285.22 285.22 917.78 804.44 84.71 36.19 32.37
painting 13.97 11.44 14.28 4.42 4.73 4.42 11.44 9.77 100.92 49.85 44.52
rendering 600.34 592.99 595.53 571.52 593.28 571.52 593.28 590.73 4.88 1.89 1.69
SELECT_WIDGET_SELECT_OPTION
scripting 150.1 152.35 158.2 163.08 179.73 150.1 158.2 160.69 18.44 7.34 6.57
painting 3.99 3.36 4.13 3.4 2.84 2.84 3.4 3.54 36.44 14.69 13.28
rendering 312.34 309.04 299.75 300.42 317.13 299.75 309.04 307.74 5.65 2.46 2.20

@Sripriya93
Copy link

Automation done for 75% of the widgets and a quick sanity for all of them, rest was manually verified, working fine, moving to done.

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=09a12b2

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3136804775.
Workflow: Appsmith External Integration Test Workflow.
Commit: 09a12b2.
PR: 16639.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3136804775.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 321.04 363.49 370.08 374.58 339.52 321.04 363.49 353.74 15.14 6.43 5.75
painting 6.26 3.45 3.47 3.38 6.73 3.38 3.47 4.66 71.89 36.27 32.40
rendering 119.48 101.42 106.2 108.17 104.66 101.42 106.2 107.99 16.72 6.37 5.70
BIND_TABLE_DATA
scripting 1085.27 1056.59 1147.26 1092.36 1030.59 1030.59 1085.27 1082.41 10.78 4.04 3.62
painting 28.03 16.66 19.35 23.65 18.24 16.66 19.35 21.19 53.66 21.80 19.49
rendering 793.96 775.8 799.21 853.37 780.86 775.8 793.96 800.64 9.69 3.87 3.46
CLICK_ON_TABLE_ROW
scripting 795.81 928.37 966.42 992.3 891.49 795.81 928.37 914.88 21.48 8.39 7.50
painting 16.98 17.49 12.1 13.25 19.07 12.1 16.98 15.78 44.17 18.76 16.79
rendering 289.57 294.84 309.51 322.61 295.43 289.57 295.43 302.39 10.93 4.46 3.99
UPDATE_POST_TITLE
scripting 1369.19 1357.17 1402.83 1748.35 1251.32 1251.32 1369.19 1425.77 34.86 13.26 11.86
painting 14.47 15.8 13.27 20.81 15.4 13.27 15.4 15.95 47.27 18.12 16.18
rendering 445.63 478.3 453.74 602.63 438.57 438.57 453.74 483.77 33.91 14.08 12.59
OPEN_MODAL
scripting 419.69 419.82 868.28 539.29 440.61 419.69 440.61 537.54 83.45 35.61 31.85
painting 8.45 12.3 11.98 11.6 10.75 8.45 11.6 11.02 34.94 14.07 12.52
rendering 369.25 368.5 370.52 406.83 382.89 368.5 370.52 379.6 10.10 4.30 3.85
CLOSE_MODAL
scripting 183.76 151.32 187.82 184.02 157.64 151.32 183.76 172.91 21.11 9.86 8.82
painting 7.64 3.8 6.31 5.29 6.07 3.8 6.07 5.82 65.98 24.23 21.65
rendering 338.52 333.74 329.22 342.34 330.81 329.22 333.74 334.93 3.92 1.63 1.45
SELECT_WIDGET_MENU_OPEN
scripting 894.04 906.05 1300.24 1158.8 951.62 894.04 951.62 1042.15 38.98 17.22 15.40
painting 8.9 8.41 14.47 8.59 11.4 8.41 8.9 10.35 58.55 25.12 22.51
rendering 582.24 595.11 1084.05 706.51 616.97 582.24 616.97 716.98 69.99 29.41 26.30
SELECT_WIDGET_SELECT_OPTION
scripting 181.37 147.5 283.25 197.95 168.72 147.5 181.37 195.76 69.35 26.70 23.88
painting 1.85 3.68 4.74 3.21 4.6 1.85 3.68 3.62 79.83 32.32 29.01
rendering 301.92 293.56 502.33 311.18 312.98 293.56 311.18 344.39 60.62 25.74 23.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Property Pane Issues related to the behaviour of the property pane skip-changelog Adding this label to a PR prevents it from being listed in the changelog UI Builders Pod Issues that UI Builders face using appsmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove feature flag for Grouping & reorganisation of Property pane
5 participants