-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Property pane config cleanup #16639
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Unable to find test scripts. Please add necessary tests to the PR. |
Deployment failed with the following error:
|
/ok-to-test sha=a420af8 |
/ok-to-test sha=0b4f0d6 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3042432314. |
9c96fc7
to
7461852
Compare
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3090205593. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3090205593. Click to view performance test results| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| |
if (styleConfig) { | ||
combinedConfig.push(...styleConfig); | ||
} | ||
if (!contentConfig && !styleConfig) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to L211
if (!map) { | ||
log.error("Widget property pane configs not defined", type); | ||
return []; | ||
if (!map || (map && map.length === 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we removed the error log?
/ok-to-test sha=a235e8c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3110965168. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3110965168. Click to view performance test results
|
/ok-to-test sha=89bd97f |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3134580302. |
/ok-to-test sha=7995c6a |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3134866298. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3134866298. Click to view performance test results
|
Automation done for 75% of the widgets and a quick sanity for all of them, rest was manually verified, working fine, moving to done. |
/ok-to-test sha=09a12b2 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3136804775. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3136804775. Click to view performance test results
|
Description
Fixes #15296
How Has This Been Tested?
Checklist: