Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JS toggle default value is wrong for vertical alignment table widget #16733

Merged
merged 11 commits into from
Sep 30, 2022
Merged

fix: JS toggle default value is wrong for vertical alignment table widget #16733

merged 11 commits into from
Sep 30, 2022

Conversation

souma-ghosh
Copy link
Contributor

Description

  • Fixes wrong default value for Vertical Alignment in column settings of table widget
  • Fixes issue where JS toggle for vertical alignment cannot be turned off after turning it on once

Fixes #14953

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@souma-ghosh
fix: JS toggle default value is wrong for vertical alignment table wi…
3fdc92a 
…dget

- Fixes wrong default value for Vertical Alignment in column settings
- Fixes issue where JS toggle cannot be turned off after turning it on once
@vercel
Copy link

vercel bot commented Sep 13, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 0:51AM (UTC)

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Table Widget labels Sep 13, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

sbalaji1192
sbalaji1192 previously approved these changes Sep 14, 2022
View reviewed changes
@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=3fdc92a

aswathkk
aswathkk previously approved these changes Sep 14, 2022
View reviewed changes
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3052583258.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3fdc92a.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3052583258.
Commit: ``.
Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)|
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
SELECT_CATEGORY| | | | | | | | | | |
| scripting | 361.18 | 390.03 | 347.97 | 331.14 | 336.61 | 331.14| 347.97| 353.39 | 16.66| 6.65 | 5.95|
| painting | 6.26 | 10.94 | 3.71 | 5.74 | 3.85 | 3.71| 5.74| 6.1 | 118.52| 48.03 | 42.95|
| rendering | 107.92 | 114.5 | 107.76 | 108.94 | 107.41 | 107.41| 107.92| 109.31 | 6.49| 2.71 | 2.42|
BIND_TABLE_DATA| | | | | | | | | | |
| scripting | 984.85 | 1735.01 | 1052.89 | 952.95 | 1150.7 | 952.95| 1052.89| 1175.28 | 66.54| 27.39 | 24.50|
| painting | 23.16 | 19.82 | 25.41 | 15.71 | 34.7 | 15.71| 23.16| 23.76 | 79.92| 30.01 | 26.81|
| rendering | 850.56 | 522.2 | 867.75 | 857.84 | 976.69 | 522.2| 857.84| 815.01 | 55.76| 21.05 | 18.83|
CLICK_ON_TABLE_ROW| | | | | | | | | | |
| scripting | 850.4 | 964.14 | 886.44 | 850.39 | 961.6 | 850.39| 886.44| 902.59 | 12.60| 6.31 | 5.64|
| painting | 9.65 | 29.7 | 13.41 | 9.43 | 10.94 | 9.43| 10.94| 14.63 | 138.55| 58.58 | 52.43|
| rendering | 307.01 | 327.64 | 311.04 | 300.95 | 326.66 | 300.95| 311.04| 314.66 | 8.48| 3.80 | 3.40|
UPDATE_POST_TITLE| | | | | | | | | | |
| scripting | 1356.76 | 1512.38 | 1338.7 | 1195.64 | 1306.45 | 1195.64| 1338.7| 1341.99 | 23.60| 8.49 | 7.59|
| painting | 17.26 | 19.22 | 17.11 | 13.4 | 16.36 | 13.4| 17.11| 16.67 | 34.91| 12.66 | 11.34|
| rendering | 465.99 | 509.13 | 474.1 | 452.33 | 488.62 | 452.33| 474.1| 478.03 | 11.88| 4.56 | 4.08|
OPEN_MODAL| | | | | | | | | | |
| scripting | 474.39 | 493.28 | 443.2 | 432.03 | 428.72 | 428.72| 443.2| 454.32 | 14.21| 6.22 | 5.56|
| painting | 11.75 | 14.42 | 12.91 | 7.32 | 17.45 | 7.32| 12.91| 12.77 | 79.33| 29.13 | 26.08|
| rendering | 391.68 | 439.98 | 387.76 | 364.89 | 380.59 | 364.89| 387.76| 392.98 | 19.11| 7.18 | 6.42|
CLOSE_MODAL| | | | | | | | | | |
| scripting | 273.44 | 195.71 | 180.45 | 189.86 | 188.67 | 180.45| 189.86| 205.63 | 45.22| 18.63 | 16.66|
| painting | 7 | 11.51 | 4.97 | 14.26 | 6.49 | 4.97| 7| 8.85 | 104.97| 43.95 | 39.32|
| rendering | 370.7 | 368.06 | 334.79 | 361.65 | 358.03 | 334.79| 361.65| 358.65 | 10.01| 3.97 | 3.55|
SELECT_WIDGET_MENU_OPEN| | | | | | | | | | |
| scripting | 1000.14 | 1000.24 | 898.16 | 1027.64 | 988.16 | 898.16| 1000.14| 982.87 | 13.17| 5.04 | 4.51|
| painting | 8.61 | 7.06 | 5.34 | 16.36 | 6.39 | 5.34| 7.06| 8.75 | 125.94| 50.51 | 45.14|
| rendering | 668.34 | 661.41 | 589.25 | 719.08 | 632.91 | 589.25| 661.41| 654.2 | 19.85| 7.30 | 6.53|
SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | |
| scripting | 169.6 | 168.36 | 154.26 | 175.72 | 154.18 | 154.18| 168.36| 164.42 | 13.10| 5.91 | 5.29|
| painting | 6.8 | 7.43 | 6.65 | 11.43 | 2.85 | 2.85| 6.8| 7.03 | 122.05| 43.39 | 38.83|
| rendering | 365.09 | 316.23 | 341.97 | 321.17 | 317.4 | 316.23| 321.17| 332.37 | 14.70| 6.33 | 5.67|

@laveena-en
Copy link
Contributor

@souma-ghosh On changing the alignment and turning off the JS toggle, the respective option isn’t seen to be selected. Can you please check this? https://www.loom.com/share/74bc98b245ac46beaf4de094f24f0266

@souma-ghosh
Copy link
Contributor Author

@souma-ghosh On changing the alignment and turning off the JS toggle, the respective option isn’t seen to be selected. Can you please check this? https://www.loom.com/share/74bc98b245ac46beaf4de094f24f0266

@laveena-en We can create a separate issue for this. Confirmed with @aswathkk that this is a bug we need to fix. For this PR we can go ahead if:

  • Default value is correct for vertical alignment
  • Able to turn off JS toggle for Vertical Alignment after its turned on

@souma-ghosh
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/14…
4da23de 
…953-column-vertical-alignment-property-issue-tablewidgetv2
@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=4da23de

@laveena-en
Copy link
Contributor

Yes, will raise a separate issue for the same @souma-ghosh
PR works as expected.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3066922350.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4da23de.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3066922350.
Commit: ``.
Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)|
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
SELECT_CATEGORY| | | | | | | | | | |
| scripting | 349.8 | 383.49 | 599.72 | 366.62 | 316.85 | 316.85| 366.62| 403.3 | 70.14| 27.90 | 24.96|
| painting | 3.4 | 10.56 | 8.04 | 5.18 | 3 | 3| 5.18| 6.04 | 125.17| 53.31 | 47.68|
| rendering | 107.21 | 109.56 | 170.25 | 116.51 | 101.7 | 101.7| 109.56| 121.05 | 56.63| 23.14 | 20.70|
BIND_TABLE_DATA| | | | | | | | | | |
| scripting | 1025.21 | 1015.33 | 1841.14 | 1141.55 | 963.63 | 963.63| 1025.21| 1197.37 | 73.29| 30.54 | 27.32|
| painting | 20.56 | 16.07 | 32.84 | 27.19 | 16.43 | 16.07| 20.56| 22.62 | 74.14| 32.10 | 28.69|
| rendering | 826.1 | 832.54 | 929.85 | 893.73 | 793.72 | 793.72| 832.54| 855.19 | 15.92| 6.46 | 5.78|
CLICK_ON_TABLE_ROW| | | | | | | | | | |
| scripting | 846.35 | 981.97 | 1728.25 | 1035.36 | 851.62 | 846.35| 981.97| 1088.71 | 81.00| 33.69 | 30.14|
| painting | 13.05 | 22.53 | 16.16 | 21.18 | 11.78 | 11.78| 16.16| 16.94 | 63.46| 28.28 | 25.27|
| rendering | 296.52 | 306.66 | 604.9 | 333.52 | 290.41 | 290.41| 306.66| 366.4 | 85.83| 36.66 | 32.79|
UPDATE_POST_TITLE| | | | | | | | | | |
| scripting | 1364.51 | 1406.56 | 1725.41 | 1558.8 | 1164.96 | 1164.96| 1406.56| 1444.05 | 38.81| 14.61 | 13.06|
| painting | 15.11 | 16.75 | 20.9 | 23.26 | 12.89 | 12.89| 16.75| 17.78 | 58.32| 23.85 | 21.32|
| rendering | 478.09 | 476.73 | 500.3 | 505.9 | 441.43 | 441.43| 478.09| 480.49 | 13.42| 5.29 | 4.73|
OPEN_MODAL| | | | | | | | | | |
| scripting | 505.04 | 509.97 | 575.31 | 486.77 | 413.77 | 413.77| 505.04| 498.17 | 32.43| 11.61 | 10.39|
| painting | 14.17 | 9.91 | 21.6 | 13.12 | 17.62 | 9.91| 14.17| 15.28 | 76.51| 29.32 | 26.18|
| rendering | 401.46 | 400.19 | 441.51 | 409.54 | 353.69 | 353.69| 401.46| 401.28 | 21.88| 7.83 | 7.01|
CLOSE_MODAL| | | | | | | | | | |
| scripting | 200.6 | 182.32 | 213.55 | 239.95 | 208.49 | 182.32| 208.49| 208.98 | 27.58| 10.04 | 8.98|
| painting | 13.09 | 16.37 | 5.69 | 5.15 | 4.41 | 4.41| 5.69| 8.94 | 133.78| 60.74 | 54.36|
| rendering | 357.08 | 339.61 | 361.76 | 360.22 | 355.43 | 339.61| 357.08| 354.82 | 6.24| 2.50 | 2.23|
SELECT_WIDGET_MENU_OPEN| | | | | | | | | | |
| scripting | 1007.86 | 989.48 | 1045.54 | 1008.14 | 942.47 | 942.47| 1007.86| 998.7 | 10.32| 3.75 | 3.36|
| painting | 9.01 | 7.16 | 6.16 | 7.68 | 5.78 | 5.78| 7.16| 7.16 | 45.11| 17.88 | 16.06|
| rendering | 624.16 | 639.59 | 653.09 | 606.6 | 583.49 | 583.49| 624.16| 621.39 | 11.20| 4.41 | 3.94|
SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | |
| scripting | 167.37 | 172.11 | 208.83 | 162.19 | 156.95 | 156.95| 167.37| 173.49 | 29.90| 11.85 | 10.59|
| painting | 2.22 | 3.36 | 3.65 | 3.81 | 4.99 | 2.22| 3.65| 3.61 | 76.73| 27.42 | 24.65|
| rendering | 315.59 | 334.58 | 336.06 | 309.63 | 309.59 | 309.59| 315.59| 321.09 | 8.24| 4.12 | 3.68|

@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=4da23de

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3081019900.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4da23de.
PR: 16733.

@souma-ghosh
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/14…
da0718a 
…953-column-vertical-alignment-property-issue-tablewidgetv2
@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=da0718a

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3087534175.
Workflow: Appsmith External Integration Test Workflow.
Commit: da0718a.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3087534175.
Commit: ``.
Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)|
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
SELECT_CATEGORY| | | | | | | | | | |
| scripting | 356.53 | 333.6 | 324.76 | 333.4 | 354.27 | 324.76| 333.6| 340.51 | 9.33| 4.13 | 3.70|
| painting | 5.1 | 4.16 | 6.12 | 3.08 | 3.43 | 3.08| 4.16| 4.38 | 69.41| 28.31 | 25.34|
| rendering | 101.19 | 106.42 | 103.51 | 103.75 | 102.05 | 101.19| 103.51| 103.38 | 5.06| 1.93 | 1.73|
BIND_TABLE_DATA| | | | | | | | | | |
| scripting | 1166.63 | 1129.47 | 1025.91 | 1057.57 | 1057.03 | 1025.91| 1057.57| 1087.32 | 12.94| 5.37 | 4.80|
| painting | 15.42 | 14.18 | 11.88 | 18.44 | 13.94 | 11.88| 14.18| 14.77 | 44.41| 16.32 | 14.62|
| rendering | 789.55 | 793.13 | 769.15 | 777.81 | 791.62 | 769.15| 789.55| 784.25 | 3.06| 1.32 | 1.18|
CLICK_ON_TABLE_ROW| | | | | | | | | | |
| scripting | 1088.3 | 822.74 | 839.1 | 892.9 | 874.52 | 822.74| 874.52| 903.51 | 29.39| 11.84 | 10.59|
| painting | 8.9 | 10.74 | 11.51 | 8.46 | 11.69 | 8.46| 10.74| 10.26 | 31.48| 14.52 | 13.06|
| rendering | 289.73 | 289.44 | 288.36 | 321.73 | 297.21 | 288.36| 289.73| 297.29 | 11.22| 4.75 | 4.25|
UPDATE_POST_TITLE| | | | | | | | | | |
| scripting | 1366.4 | 1811.69 | 1188.28 | 1313.02 | 1335.42 | 1188.28| 1335.42| 1402.96 | 44.44| 16.98 | 15.19|
| painting | 13.19 | 12.39 | 12.15 | 12.51 | 16.59 | 12.15| 12.51| 13.37 | 33.21| 13.76 | 12.34|
| rendering | 440.64 | 455.87 | 423.15 | 449.26 | 450.3 | 423.15| 449.26| 443.84 | 7.37| 2.88 | 2.58|
OPEN_MODAL| | | | | | | | | | |
| scripting | 409.61 | 412.87 | 414.93 | 409.17 | 434.61 | 409.17| 412.87| 416.24 | 6.11| 2.53 | 2.27|
| painting | 7.58 | 19.94 | 7.14 | 13.17 | 28.3 | 7.14| 13.17| 15.23 | 138.94| 58.83 | 52.66|
| rendering | 367.58 | 367.31 | 372.2 | 355.26 | 373.64 | 355.26| 367.58| 367.2 | 5.01| 1.97 | 1.76|
CLOSE_MODAL| | | | | | | | | | |
| scripting | 210.79 | 168.96 | 167.88 | 162.64 | 157.76 | 157.76| 167.88| 173.61 | 30.55| 12.25 | 10.96|
| painting | 11.31 | 11.77 | 9.96 | 9.15 | 12.68 | 9.15| 11.31| 10.97 | 32.18| 12.94 | 11.58|
| rendering | 334.12 | 332.46 | 327.73 | 320.44 | 325.35 | 320.44| 327.73| 328.02 | 4.17| 1.68 | 1.50|
SELECT_WIDGET_MENU_OPEN| | | | | | | | | | |
| scripting | 922.27 | 934.37 | 930.46 | 922.32 | 922 | 922| 922.32| 926.28 | 1.34| 0.62 | 0.56|
| painting | 4.83 | 10.98 | 4.67 | 6.9 | 5.56 | 4.67| 5.56| 6.59 | 95.75| 39.61 | 35.36|
| rendering | 580.22 | 594.33 | 577.1 | 597.01 | 584.45 | 577.1| 584.45| 586.62 | 3.39| 1.48 | 1.33|
SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | |
| scripting | 150.09 | 164.02 | 160.82 | 147.87 | 158.61 | 147.87| 158.61| 156.28 | 10.33| 4.47 | 3.99|
| painting | 5.29 | 2.17 | 3.64 | 4.12 | 2.64 | 2.17| 3.64| 3.57 | 87.39| 34.45 | 30.81|
| rendering | 294.56 | 305.72 | 306.18 | 293.34 | 305.93 | 293.34| 305.72| 301.15 | 4.26| 2.19 | 1.96|

@souma-ghosh
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/14…
ccc8166 
…953-column-vertical-alignment-property-issue-tablewidgetv2
@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=c31c5cb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3112203928.
Workflow: Appsmith External Integration Test Workflow.
Commit: c31c5cb.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3112203928.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 488.42 1239.2 382.93 1083.67 427.13 382.93 488.42 724.27 118.23 55.86 49.96
painting 4.42 5.37 5.81 4.23 5.67 4.23 5.37 5.1 30.98 14.31 12.75
rendering 155.44 127.98 108.78 105.36 115.71 105.36 115.71 122.65 40.83 16.53 14.78
BIND_TABLE_DATA
scripting 1650.83 1168.81 1132.54 1040.8 1053.99 1040.8 1132.54 1209.39 50.44 20.88 18.67
painting 21.68 31.63 22.67 10.82 20.31 10.82 21.68 21.42 97.15 34.59 30.95
rendering 603.24 908.87 818.97 789.3 877.77 603.24 818.97 799.63 38.22 14.94 13.36
CLICK_ON_TABLE_ROW
scripting 1252.22 1072.6 943.46 891.76 1345.97 891.76 1072.6 1101.2 41.25 17.72 15.85
painting 15.74 16.95 11.27 17.53 9.77 9.77 15.74 14.25 54.46 24.63 22.04
rendering 417.25 349.34 312.1 294.99 332.53 294.99 332.53 341.24 35.83 13.83 12.37
UPDATE_POST_TITLE
scripting 2571.43 1742.68 1523.94 1463.49 1618.59 1463.49 1618.59 1784.03 62.10 25.37 22.69
painting 27.89 22.77 25.3 14.21 18.04 14.21 22.77 21.64 63.22 25.51 22.83
rendering 754.66 539.9 473.77 465.9 492.79 465.9 492.79 545.4 52.94 22.09 19.75
OPEN_MODAL
scripting 727.83 525.4 473.53 485.93 523.95 473.53 523.95 547.33 46.46 18.90 16.91
painting 19.45 12.82 8.38 15.06 11.47 8.38 12.82 13.44 82.37 30.80 27.53
rendering 558.66 415.33 382.76 411.49 413.05 382.76 413.05 436.26 40.32 15.98 14.29
CLOSE_MODAL
scripting 318.81 256.65 253.47 350.32 232.68 232.68 256.65 282.39 41.66 17.63 15.77
painting 6.36 5.02 15.05 5.61 9.36 5.02 6.36 8.28 121.14 50.00 44.69
rendering 445.31 354.58 363.48 347.18 354.51 347.18 354.58 373.01 26.31 10.95 9.79
SELECT_WIDGET_MENU_OPEN
scripting 1076.76 974.89 311.6 1081.65 997.62 311.6 997.62 888.5 86.67 36.68 32.81
painting 9.25 6.63 13.51 7.97 18.31 6.63 9.25 11.13 104.94 42.86 38.36
rendering 681.53 638.11 636.59 708.51 637.03 636.59 638.11 660.35 10.89 5.01 4.48
SELECT_WIDGET_SELECT_OPTION
scripting 187.92 183.25 169.25 221.69 148.48 148.48 183.25 182.12 40.20 14.78 13.22
painting 3.24 2.43 13.31 4.69 8.71 2.43 4.69 6.48 167.90 69.75 62.35
rendering 361.36 319.34 312.22 321.15 298.91 298.91 319.34 322.6 19.36 7.24 6.48

@souma-ghosh souma-ghosh mentioned this pull request Sep 26, 2022
Closed
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal linked an issue Sep 26, 2022 that may be closed by this pull request
[Bug]: Table column type date can't change original/display format JS toggle #16250
Closed
1 task
aswathkk
aswathkk previously approved these changes Sep 26, 2022
View reviewed changes
sbalaji1192
sbalaji1192 previously approved these changes Sep 26, 2022
View reviewed changes
@souma-ghosh
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/14…
f1533f2 
…953-column-vertical-alignment-property-issue-tablewidgetv2
@souma-ghosh
Merge branch 'fix/14953-column-vertical-alignment-property-issue-tabl…
b3ea5de 
…ewidgetv2' of github.com:appsmithorg/appsmith into fix/14953-column-vertical-alignment-property-issue-tablewidgetv2
@vercel
Copy link

vercel bot commented Sep 29, 2022

Deployment failed with the following error:

Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").

@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=b3ea5de

@github-actions github-actions bot added the Needs Triaging Needs attention from maintainers to triage label Sep 29, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3149356565.
Workflow: Appsmith External Integration Test Workflow.
Commit: b3ea5de.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3149356565.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 431.9 378 388.7 453.82 359.51 359.51 388.7 402.39 23.44 9.73 8.71
painting 5.28 3.34 3.31 4.19 6.1 3.31 4.19 4.44 62.84 27.70 24.77
rendering 114.01 110.23 121.71 117.81 104.49 104.49 114.01 113.65 15.15 5.87 5.25
BIND_TABLE_DATA
scripting 2097.77 1110.99 1005.23 1399.19 1059.2 1005.23 1110.99 1334.48 81.87 33.95 30.36
painting 53.97 25.25 10.74 33.85 16.97 10.74 25.25 28.16 153.52 59.84 53.52
rendering 1076.46 864.41 774.14 988.35 813.7 774.14 864.41 903.41 33.46 13.94 12.47
CLICK_ON_TABLE_ROW
scripting 1549.24 992.51 951.25 1365.05 1049.79 951.25 1049.79 1181.57 50.61 22.19 19.85
painting 24.78 12.85 17.69 23.4 21.32 12.85 21.32 20.01 59.62 24.04 21.49
rendering 507.16 326.45 306.62 376.52 310.86 306.62 326.45 365.52 54.86 22.96 20.54
UPDATE_POST_TITLE
scripting 2090.86 1433.66 1463.88 2166.08 1670.99 1433.66 1670.99 1765.09 41.49 19.55 17.49
painting 18.9 15.35 16.95 22.64 19.29 15.35 18.9 18.63 39.13 14.76 13.20
rendering 757.28 671.87 607.32 733.5 669.81 607.32 671.87 687.96 21.80 8.59 7.68
OPEN_MODAL
scripting 507.33 469.65 493.18 657.72 468.91 468.91 493.18 519.36 36.35 15.22 13.61
painting 9.31 14.12 13.13 26.67 9.29 9.29 13.13 14.5 119.86 49.31 44.07
rendering 1310.55 1232.81 1222.63 1361.14 1259.21 1222.63 1259.21 1277.27 10.84 4.54 4.06
CLOSE_MODAL
scripting 327.48 236.42 208.98 836.35 214.74 208.98 236.42 364.79 171.98 73.43 65.68
painting 5.93 10.23 5.29 6.14 13.54 5.29 6.14 8.23 100.24 43.13 38.64
rendering 1145.02 939.07 956.92 964.26 942.1 939.07 956.92 989.47 20.81 8.85 7.92
SELECT_WIDGET_MENU_OPEN
scripting 1020.49 927.82 1182.12 1011.02 982.64 927.82 1011.02 1024.82 24.81 9.27 8.30
painting 7.01 5.55 9.59 13.54 13.22 5.55 9.59 9.78 81.70 36.71 32.82
rendering 729.49 646.5 771.82 708.05 682.83 646.5 708.05 707.74 17.71 6.68 5.98
SELECT_WIDGET_SELECT_OPTION
scripting 159.15 162.83 198.34 159.62 188.6 159.15 162.83 173.71 22.56 10.60 9.49
painting 2.27 2.02 3.33 6.47 5.69 2.02 3.33 3.96 112.37 51.01 45.71
rendering 340.04 304.56 391.61 316.57 337.31 304.56 337.31 338.02 25.75 9.88 8.83

@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=7d19c9c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3151487427.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7d19c9c.
PR: 16733.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3151487427.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 379.68 339.85 363.23 355.5 1059.24 339.85 363.23 499.5 144.02 62.71 56.09
painting 3.36 4.3 4.14 3.42 3.63 3.36 3.63 3.77 24.93 11.41 10.08
rendering 110.52 105.03 105.07 104.39 102.91 102.91 105.03 105.58 7.21 2.74 2.45
BIND_TABLE_DATA
scripting 1153.3 1052.93 1079.23 1044.36 1039.53 1039.53 1052.93 1073.87 10.59 4.37 3.91
painting 22.67 16.24 18.69 18.71 17.41 16.24 18.69 18.74 34.31 12.91 11.58
rendering 807.15 803.01 810.91 781.07 795.83 781.07 803.01 799.59 3.73 1.47 1.32
CLICK_ON_TABLE_ROW
scripting 843.95 896.52 886.51 890.97 868.83 843.95 886.51 877.36 5.99 2.43 2.18
painting 10.61 10.18 15.11 9.05 10.06 9.05 10.18 11 55.09 21.55 19.27
rendering 312.83 299.36 299.9 291.21 297.97 291.21 299.36 300.25 7.20 2.61 2.34
UPDATE_POST_TITLE
scripting 1563.84 1408.33 1382.92 1359.93 1382.49 1359.93 1382.92 1419.5 14.36 5.81 5.20
painting 17.36 13.79 14.81 12.71 17.41 12.71 14.81 15.22 30.88 13.86 12.42
rendering 604.75 613.81 591.35 598.01 603.85 591.35 603.85 602.35 3.73 1.39 1.24
OPEN_MODAL
scripting 435.99 458.76 447 419.84 438.95 419.84 438.95 440.11 8.84 3.26 2.92
painting 12.71 8.8 20.69 27.68 8.12 8.12 12.71 15.6 125.38 53.85 48.21
rendering 1142.13 1204.46 1169.01 1137.03 1165.96 1137.03 1165.96 1163.72 5.79 2.30 2.06
CLOSE_MODAL
scripting 225.92 196.21 208.25 201.53 218.75 196.21 208.25 210.13 14.14 5.81 5.19
painting 12.36 5.05 11.68 6.24 9.74 5.05 9.74 9.01 81.13 36.07 32.30
rendering 901.54 910.56 877.73 885.07 921.15 877.73 901.54 899.21 4.83 1.99 1.78
SELECT_WIDGET_MENU_OPEN
scripting 927.1 913.04 931.2 913.16 963.43 913.04 927.1 929.59 5.42 2.22 1.98
painting 9.7 5.77 6.12 11.64 6.72 5.77 6.72 7.99 73.47 32.04 28.66
rendering 637.38 630.48 637.07 612.34 688.94 612.34 637.07 641.24 11.95 4.45 3.98
SELECT_WIDGET_SELECT_OPTION
scripting 150.58 155.26 157.41 156.48 152.52 150.58 155.26 154.45 4.42 1.84 1.64
painting 4.76 9.84 7.55 5.27 11.33 4.76 7.55 7.75 84.77 36.65 32.77
rendering 299.12 307.4 297.39 306.77 315.32 297.39 306.77 305.2 5.87 2.36 2.11

@souma-ghosh souma-ghosh merged commit 54e00b9 into release Sep 30, 2022
@souma-ghosh souma-ghosh deleted the fix/14953-column-vertical-alignment-property-issue-tablewidgetv2 branch September 30, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

@aswathkk aswathkk aswathkk left review comments

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Table Widget
Projects
None yet
Milestone
No milestone
4 participants
@souma-ghosh @laveena-en @sbalaji1192 @aswathkk