-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new property hidden to formControl fields #1682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hidden logic should be handled in the BaseControl and not in each and every control. This is leading to lots of code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akash-codemonk when the value is READ_ONLY, we do not render the Field
this leads me to believe, that the value may not available when the form is submitted. Could you confirm if the READ_ONLY fields have their original values sent to the servers?
@hetunandu Will create a separate component which will create the control. Similar to https://github.com/appsmithorg/appsmith/blob/release/app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx, this will handle the hidden logic and avoid duplication. |
@riodeuno The form values are initialised with the action or datasource values with for e.g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This has been addressed
Fixes #1659