fix: Fix template filtering version mismatch #16843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
sharat87
added
skip-docs
skip-changelog
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Bug
|
Unable to find test scripts. Please add necessary tests to the PR. |
|
QQ: For some more context to template apps, what does the latest running version have to do with them @sharat87 ? |
|
@nidhi-nair, each template application has a |
nidhi-nair
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getReleasedVersionmethod returns the current running version, only if it dosen't end with-SNAPSHOT. If it does end with-SNAPSHOT, then it'll return the version from the most recent entry in the release notes.The effect of this is that when fetching template applications, on version
v1.8.1-SNAPSHOT, we pass in version asv1.8.0(which would be the most recent in release notes), which means the latest and greatest of templates won't ever be listed on prod.The cloud-services API is actually capable of handling versions with
-SNAPSHOTin them just fine. This server just isn't sending it.This fix will send the current running version as is to cloud-services so we get more accurate results.