Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Container + List + Modal + Statbox + Tabs reskinning #16974

Merged
merged 19 commits into from
Sep 30, 2022
Merged

fix: Container + List + Modal + Statbox + Tabs reskinning #16974

merged 19 commits into from
Sep 30, 2022

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented Sep 22, 2022 •
edited

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes #10982
Fixes #10999
Fixes #3180
Fixes #10993

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 22, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 8:45AM (UTC)

@github-actions github-actions bot added the Bug Something isn't working label Sep 22, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@jsartisan jsartisan changed the title fix: List + Modal reskinning fix: Container + List + Modal reskinning Sep 23, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request List Widget Issues related to the list widget Low An issue that is neither critical nor breaks a user flow Modal Widget Needs Design needs design or changes to design Needs PRD Issue which are awaiting PRD Tab Widget and removed Enhancement New feature or request labels Sep 23, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Enhancement New feature or request label Sep 26, 2022
@jsartisan
Copy link
Contributor Author

/ok-to-test sha=57c1122

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3148903950.
Workflow: Appsmith External Integration Test Workflow.
Commit: 57c1122.
PR: 16974.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3148903950.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 386.45 352.6 382.14 1193.98 402.61 352.6 386.45 543.56 154.79 66.98 59.90
painting 5.48 3.37 7.97 6.53 3.95 3.37 5.48 5.46 84.25 34.43 30.77
rendering 113.86 104.82 107.44 112.72 118.46 104.82 112.72 111.46 12.24 4.84 4.33
BIND_TABLE_DATA
scripting 1130.07 1105.86 1113.96 1263.17 1164.62 1105.86 1130.07 1155.54 13.61 5.56 4.97
painting 25.04 14.99 19.23 40.12 24.81 14.99 24.81 24.84 101.17 38.29 34.26
rendering 884.61 793.86 828.58 967.33 887.69 793.86 884.61 872.41 19.88 7.58 6.78
CLICK_ON_TABLE_ROW
scripting 912.05 887.59 979.97 1022.37 989.27 887.59 979.97 958.25 14.07 5.87 5.25
painting 8.66 10.16 23.79 8.95 16.43 8.66 10.16 13.6 111.25 47.87 42.87
rendering 337.19 305.03 323.39 333.18 313.93 305.03 323.39 322.54 9.97 4.13 3.69
UPDATE_POST_TITLE
scripting 1655.57 1413.2 1479.29 1532.7 1696.21 1413.2 1532.7 1555.39 18.20 7.63 6.83
painting 24.42 15.28 16.09 16.91 18.39 15.28 16.91 18.22 50.16 20.03 17.95
rendering 651.61 592.07 608.8 640.51 643.43 592.07 640.51 627.28 9.49 4.07 3.64
OPEN_MODAL
scripting 483.82 474.68 475.47 456.12 509.52 456.12 475.47 479.92 11.13 4.04 3.62
painting 8.74 12.45 9.75 16.97 16.34 8.74 12.45 12.85 64.05 29.11 25.99
rendering 1248.76 1245.64 1197.76 1197.37 1229.22 1197.37 1229.22 1223.75 4.20 2.05 1.83
CLOSE_MODAL
scripting 245.55 233.04 195.07 244.75 229.45 195.07 233.04 229.57 21.99 8.95 8.00
painting 4.45 9.52 6.94 5.55 21.07 4.45 6.94 9.51 174.76 70.87 63.41
rendering 947.5 913.32 900.29 908.91 901.92 900.29 908.91 914.39 5.16 2.11 1.88
SELECT_WIDGET_MENU_OPEN
scripting 948.23 1003.45 996.77 1000.97 991.85 948.23 996.77 988.25 5.59 2.31 2.06
painting 5 6.18 11.31 7.26 7.06 5 7.06 7.36 85.73 32.34 28.94
rendering 656.63 682.47 691.3 704.53 684.48 656.63 684.48 683.88 7.00 2.56 2.29
SELECT_WIDGET_SELECT_OPTION
scripting 160.57 177.23 172.1 171.33 161.62 160.57 171.33 168.57 9.88 4.27 3.82
painting 3.4 3.31 8.95 4.54 7.28 3.31 4.54 5.5 102.55 45.64 40.73
rendering 318.41 310.82 325.04 312.63 316.64 310.82 316.64 316.71 4.49 1.76 1.57

@dhruvikn dhruvikn changed the title fix: Container + List + Modal + Statbox + Container + Tabs reskinning fix: Container + List + Modal + Statbox + Tabs reskinning Sep 29, 2022
@github-actions github-actions bot removed the Enhancement New feature or request label Sep 29, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Enhancement New feature or request label Sep 29, 2022
@jsartisan
Copy link
Contributor Author

/ok-to-test sha=69e94e4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3153542749.
Workflow: Appsmith External Integration Test Workflow.
Commit: 69e94e4.
PR: 16974.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=7109c17

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156408529.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7109c17.
PR: 16974.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=8f640f9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156744581.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8f640f9.
PR: 16974.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3156744581.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 338.49 405.12 429.39 612.17 603 338.49 429.39 477.63 57.30 25.80 23.08
painting 7.95 3.83 11.73 5.81 9.33 3.83 7.95 7.73 102.20 39.59 35.45
rendering 105.89 111.98 120.66 133.71 130.91 105.89 120.66 120.63 23.06 9.89 8.85
BIND_TABLE_DATA
scripting 1127.06 1080.99 1681.04 2125.65 1923.07 1080.99 1681.04 1587.56 65.80 29.54 26.42
painting 19.8 21.44 32.1 51.17 43.39 19.8 32.1 33.58 93.42 40.65 36.36
rendering 856.72 867.42 593.33 800.75 707.93 593.33 800.75 765.23 35.82 15.03 13.44
CLICK_ON_TABLE_ROW
scripting 842.79 1021.33 1691.28 1516.3 1048.2 842.79 1048.2 1223.98 69.32 29.49 26.38
painting 8.91 12.44 19.29 18.03 18.68 8.91 18.03 15.47 67.10 29.54 26.44
rendering 312.82 335.76 440.04 397.6 333.07 312.82 335.76 363.86 34.96 14.60 13.06
UPDATE_POST_TITLE
scripting 1418.96 1534.86 2467.82 2997.68 1612.49 1418.96 1612.49 2006.36 78.69 34.51 30.87
painting 15.31 17.51 26.09 37.83 16.5 15.31 17.51 22.65 99.43 41.90 37.48
rendering 612.99 645.11 801.48 1163.26 656.89 612.99 656.89 775.95 70.92 29.42 26.32
OPEN_MODAL
scripting 442.83 808.4 611.81 1012.64 600.62 442.83 611.81 695.26 81.96 31.61 28.27
painting 16.56 30.73 17.03 26.67 16.16 16.16 17.03 21.43 67.99 31.73 28.37
rendering 1231.63 1622.76 1380.86 1808.99 1328.36 1231.63 1380.86 1474.52 39.16 16.01 14.32
CLOSE_MODAL
scripting 244.86 306.35 583.51 417.02 305.04 244.86 306.35 371.36 91.19 36.06 32.25
painting 6.83 8.06 19.55 11.79 8.36 6.83 8.36 10.92 116.48 47.25 42.31
rendering 943.69 1025.59 1401.05 1132.02 1168.83 943.69 1132.02 1134.24 40.32 15.30 13.69
SELECT_WIDGET_MENU_OPEN
scripting 982.62 1129.91 1443.77 1005.68 1048.39 982.62 1048.39 1122.07 41.10 16.79 15.02
painting 11.35 8.83 14.18 6.05 13.01 6.05 11.35 10.68 76.12 30.71 27.43
rendering 662.77 806.64 998.76 668.17 748.65 662.77 748.65 777 43.24 17.71 15.84
SELECT_WIDGET_SELECT_OPTION
scripting 169.4 207.83 234.74 224.64 159.23 159.23 207.83 199.17 37.91 16.78 15.01
painting 4.36 4.07 7.72 3.86 2.36 2.36 4.07 4.47 119.91 44.07 39.37
rendering 334.7 337.84 396.36 341.38 310.85 310.85 337.84 344.23 24.84 9.15 8.19

@jsartisan jsartisan merged commit 138d4db into release Sep 30, 2022
@jsartisan jsartisan deleted the reskinning/list branch September 30, 2022 09:18
@github-actions github-actions bot added the QA Needs QA attention label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvikn dhruvikn dhruvikn approved these changes

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Community Reported issues reported by community members Enhancement New feature or request List Widget Issues related to the list widget Low An issue that is neither critical nor breaks a user flow Modal Widget Needs Design needs design or changes to design Needs PRD Issue which are awaiting PRD QA Needs QA attention Stat Box Widget Issues related to stat box Tab Widget
Projects
None yet
Milestone
No milestone
3 participants
@jsartisan @laveena-en @dhruvikn