Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select widget search improvement #17006

Merged
merged 5 commits into from
Oct 4, 2022
Merged

fix: select widget search improvement #17006

merged 5 commits into from
Oct 4, 2022

Conversation

Tooluloope
Copy link
Contributor

@Tooluloope Tooluloope commented Sep 23, 2022 •
edited by souma-ghosh

Description

Updated the DropdownOption to allow the label to be either number/string.

I left the EXPECTED STRUCTURE as a string because numbers shouldn't be supported by default.

Also added a cypress test to ensure filtering works and Select.SelectedOptionLabel outputs the correct type

Fixes #17003

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Cypress test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 8:46AM (UTC)

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Select Widget Select or dropdown widget labels Sep 23, 2022
@somangshu somangshu requested review from sbalaji1192 and removed request for ashit-rath September 26, 2022 11:40
sbalaji1192
sbalaji1192 previously approved these changes Sep 27, 2022
View reviewed changes
@sbalaji1192
Copy link
Contributor

/ok-to-test=2afda63

@chandannkumar
Copy link

Tested this PR and working as expected

@vercel
Copy link

vercel bot commented Sep 30, 2022

Deployment failed with the following error:

Resource is limited - try again in 3 minutes (more than 100, code: "api-deployments-free-per-day").

@souma-ghosh
Copy link
Contributor

/ok-to-test sha=3e9ea44

@souma-ghosh souma-ghosh self-assigned this Sep 30, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3157579562.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3e9ea44.
PR: 17006.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3157579562.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 337.76 346.57 375.43 365.48 426.56 337.76 365.48 370.36 23.98 9.39 8.40
painting 3.5 8.12 3.17 5.53 3.7 3.17 3.7 4.8 103.13 43.13 38.54
rendering 102.95 103.82 111.65 108.88 113.74 102.95 108.88 108.21 9.97 4.38 3.92
BIND_TABLE_DATA
scripting 1164.53 1128.49 1012.82 1092.62 1244.71 1012.82 1128.49 1128.63 20.55 7.61 6.80
painting 26.47 28.29 21.87 29.29 22.09 21.87 26.47 25.6 28.98 13.52 12.07
rendering 867.52 850.79 861.28 926.26 833.62 833.62 861.28 867.89 10.67 4.04 3.61
CLICK_ON_TABLE_ROW
scripting 771.53 980.14 908.99 926.39 939.28 771.53 926.39 905.27 23.04 8.75 7.83
painting 18.01 12.67 12.08 9.42 9.65 9.42 12.08 12.37 69.44 28.05 25.06
rendering 289.78 320.06 306.44 315.88 304.51 289.78 306.44 307.33 9.85 3.82 3.42
UPDATE_POST_TITLE
scripting 1421.71 1576.55 1300.49 1487.66 1423.36 1300.49 1423.36 1441.95 19.14 7.02 6.28
painting 12.26 15.9 16.71 16.48 12.77 12.26 15.9 14.82 30.03 14.44 12.89
rendering 583.63 611.67 608.42 617.3 598.22 583.63 608.42 603.85 5.58 2.20 1.96
OPEN_MODAL
scripting 415.59 465.66 429.41 480.14 457.14 415.59 457.14 449.59 14.36 5.90 5.27
painting 16.06 12.14 22.59 22.24 16 12.14 16.06 17.81 58.67 25.27 22.57
rendering 1134.44 1238.8 1184.4 1235.13 1224.5 1134.44 1224.5 1203.45 8.67 3.67 3.29
CLOSE_MODAL
scripting 198.8 215.59 190.67 198.56 256.76 190.67 198.8 212.08 31.16 12.53 11.21
painting 8.34 5.25 11.32 9.31 5.87 5.25 8.34 8.02 75.69 31.17 27.81
rendering 869.08 897.45 897.5 917.35 958.42 869.08 897.5 907.96 9.84 3.64 3.25
SELECT_WIDGET_MENU_OPEN
scripting 953.71 972.98 1021.54 988.78 991.98 953.71 988.78 985.8 6.88 2.55 2.28
painting 4.88 12.32 13.99 6.18 13.35 4.88 12.32 10.14 89.84 42.21 37.77
rendering 644.52 688.5 712.89 686.02 661.93 644.52 686.02 678.77 10.07 3.88 3.47
SELECT_WIDGET_SELECT_OPTION
scripting 170.03 165.34 164.67 162.11 164.89 162.11 164.89 165.41 4.79 1.74 1.55
painting 6.15 3.61 11.04 3.83 5.08 3.61 5.08 5.94 125.08 51.01 45.62
rendering 323.1 360.35 310.11 312.53 309.71 309.71 312.53 323.16 15.67 6.65 5.95

@sbalaji1192
Copy link
Contributor

@souma-ghosh Could you please fix the CI, Will approve post that

@jsartisan
Copy link
Contributor

/ok-to-test sha=41e1f22

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3173043148.
Workflow: Appsmith External Integration Test Workflow.
Commit: 41e1f22.
PR: 17006.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3173043148.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 366.26 315.65 320.37 336.88 401.37 315.65 336.88 348.11 24.62 10.27 9.19
painting 3.69 4.83 6.84 5.58 4.78 3.69 4.83 5.14 61.28 22.57 20.23
rendering 103.27 104.09 103.02 105.27 115.67 103.02 104.09 106.26 11.90 5.02 4.49
BIND_TABLE_DATA
scripting 1063.25 1088.05 1077.72 1003.94 1092.14 1003.94 1077.72 1065.02 8.28 3.37 3.02
painting 12.95 18.26 20.21 17.31 25.01 12.95 18.26 18.75 64.32 23.47 20.96
rendering 793.33 784.38 779.11 812.11 860.73 779.11 793.33 805.93 10.13 4.11 3.67
CLICK_ON_TABLE_ROW
scripting 785.58 1000.03 862.54 1159.95 997.73 785.58 997.73 961.17 38.95 14.98 13.40
painting 11.13 9.8 11.95 12.76 10.49 9.8 11.13 11.23 26.36 10.42 9.35
rendering 310.88 299.83 301.09 296.4 316.97 296.4 301.09 305.03 6.74 2.81 2.51
UPDATE_POST_TITLE
scripting 1474.38 1424.58 1329.96 1294.02 1421.53 1294.02 1421.53 1388.89 12.99 5.35 4.79
painting 12.75 13.66 12.9 12.68 14.59 12.68 12.9 13.32 14.34 6.08 5.48
rendering 585.6 607.42 591.55 601.36 614.99 585.6 601.36 600.18 4.90 1.97 1.76
OPEN_MODAL
scripting 443.41 449.67 420.68 439.69 441.1 420.68 441.1 438.91 6.60 2.48 2.22
painting 8.63 18.22 10.69 21.29 8.39 8.39 10.69 13.44 95.98 44.12 39.43
rendering 1155.53 1191.81 1156.73 1168.35 1195.82 1155.53 1168.35 1173.65 3.43 1.63 1.46
CLOSE_MODAL
scripting 191.91 635.17 209.96 184.27 228.78 184.27 209.96 290.02 155.47 66.79 59.74
painting 4.43 5.05 8.27 4.89 5.9 4.43 5.05 5.71 67.25 26.80 23.99
rendering 856.79 874.96 897.53 884.85 923.57 856.79 884.85 887.54 7.52 2.82 2.52
SELECT_WIDGET_MENU_OPEN
scripting 901.59 908.93 910.15 992.49 1028.55 901.59 910.15 948.34 13.39 6.14 5.50
painting 11.93 6.6 5.18 8 6.69 5.18 6.69 7.68 87.89 33.59 29.95
rendering 616.41 629.18 622.36 668.11 710.49 616.41 629.18 649.31 14.49 6.12 5.47
SELECT_WIDGET_SELECT_OPTION
scripting 153.12 148.78 157.1 172.28 156.65 148.78 156.65 157.59 14.91 5.63 5.03
painting 5.09 13.36 3.51 2.45 3.71 2.45 3.71 5.62 194.13 78.83 70.46
rendering 307.51 324.63 306.83 305.43 318.87 305.43 307.51 312.65 6.14 2.74 2.46

@jsartisan jsartisan enabled auto-merge (squash) October 4, 2022 05:46
@jsartisan jsartisan merged commit 589f2b9 into release Oct 4, 2022
@jsartisan jsartisan deleted the fix/Select-widget-search branch October 4, 2022 10:45
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3304974773.
Workflow: Appsmith External Integration Test Workflow.
Commit: 41e1f22.
PR: 17006.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17006&runId=3304974773_1

@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=2afda63

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3304995588.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2afda63.
PR: 17006.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17006&runId=3304995588_1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3305036734.
Workflow: Appsmith External Integration Test Workflow.
Commit: 41e1f22.
PR: 17006.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17006&runId=3305036734_1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3305037049.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3e9ea44.
PR: 17006.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17006&runId=3305037049_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

Assignees

@souma-ghosh souma-ghosh

Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Select Widget Select or dropdown widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Select widget crashes when searching using a Numeric Label value
5 participants
@Tooluloope @sbalaji1192 @chandannkumar @souma-ghosh @jsartisan