Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement data type handling in MySQL (#16621) #17017

Merged
merged 31 commits into from
Oct 4, 2022
Merged

feat: Implement data type handling in MySQL (#16621) #17017

merged 31 commits into from
Oct 4, 2022

Conversation

subrata71
Copy link
Contributor

@subrata71 subrata71 commented Sep 23, 2022 •
edited

Description

With this implementation we can now achieve the following under the prepared statement:

  • Ability to distinguish between null object and "null" string
  • Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer

Fixes #16621
Fixes #16600
Fixes #15572
Fixes #10456
Fixes #16811
Fixes #17058
Fixes #11691

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • JUnit
  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@subrata71
feat: Implement data type handling in MySQL (#16621)
43e795f 
With this implementation we can now achieve the following under prepared statement:
- Ability to distinguish between null object and "null" string
- Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer
@vercel
Copy link

vercel bot commented Sep 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 5:12AM (UTC)

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Data Platform Pod Issues related to the underlying data platform Datatype issue Issues that have risen because data types weren't handled Integrations Pod Issues related to a specific integration MySQL Issues related to MySQL plugin Task A simple Todo Enhancement New feature or request labels Sep 23, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

nidhi-nair
nidhi-nair previously approved these changes Sep 26, 2022
View reviewed changes
@subrata71
Copy link
Contributor Author

/ok-to-test sha=a0218fb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3126341717.
Workflow: Appsmith External Integration Test Workflow.
Commit: a0218fb.
PR: 17017.

@ChandanBalajiBP ChandanBalajiBP mentioned this pull request Sep 26, 2022
Closed
1 task
@subrata71
Copy link
Contributor Author

/ok-to-test sha=f6d21b8

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3158213453.
Workflow: Appsmith External Integration Test Workflow.
Commit: a455e8b.
PR: 17017.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3158213453.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 328.89 392.09 345.02 361.33 402.11 328.89 361.33 365.89 20.01 8.45 7.56
painting 4.22 30.64 4.37 4.42 4.44 4.22 4.42 9.62 274.64 122.14 109.25
rendering 103.43 102.8 105 104.89 104.51 102.8 104.51 104.13 2.11 0.93 0.83
BIND_TABLE_DATA
scripting 1055.85 1051.52 1090.34 1070.16 1009.92 1009.92 1055.85 1055.56 7.62 2.81 2.51
painting 16.93 18.7 18.55 12.02 20.61 12.02 18.55 17.36 49.48 18.78 16.76
rendering 808.79 777.23 823.2 818.66 863.46 777.23 818.66 818.27 10.54 3.79 3.39
CLICK_ON_TABLE_ROW
scripting 828.37 873.49 840.87 911.46 896.65 828.37 873.49 870.17 9.55 4.07 3.64
painting 9.4 8.64 8.92 8.88 9.54 8.64 8.92 9.08 9.91 4.19 3.74
rendering 286.95 312.83 302.43 298.07 313.85 286.95 302.43 302.83 8.88 3.68 3.29
UPDATE_POST_TITLE
scripting 1335.71 1368.26 1402.37 1355.28 1452.08 1335.71 1368.26 1382.74 8.42 3.31 2.96
painting 12.45 13.42 12.97 16.11 13.78 12.45 13.42 13.75 26.62 10.25 9.16
rendering 589.7 608.76 597.1 629.13 610.37 589.7 608.76 607.01 6.50 2.47 2.21
OPEN_MODAL
scripting 429.75 454.57 446.96 424.97 478.31 424.97 446.96 446.91 11.94 4.77 4.27
painting 11.59 9.14 13.65 11.56 12.21 9.14 11.59 11.63 38.78 14.02 12.55
rendering 1192.25 1213.56 1180.1 1176.45 1329.36 1176.45 1192.25 1218.34 12.55 5.23 4.68
CLOSE_MODAL
scripting 206.79 681.42 208.74 192.01 216.36 192.01 208.74 301.06 162.56 70.69 63.22
painting 4.8 7.53 6.01 4.97 13.39 4.8 6.01 7.34 117.03 48.37 43.32
rendering 873.64 899.66 870.64 911.34 924.5 870.64 899.66 895.96 6.01 2.62 2.34
SELECT_WIDGET_MENU_OPEN
scripting 902.03 902.92 920.1 991.14 1738.06 902.03 920.1 1090.85 76.64 33.34 29.82
painting 5.85 6.81 5.34 8.84 8.91 5.34 6.81 7.15 49.93 23.22 20.84
rendering 638.16 636.03 657.52 662.12 1327.93 636.03 657.52 784.35 88.21 38.77 34.68
SELECT_WIDGET_SELECT_OPTION
scripting 144.54 156.07 148.14 150.27 340.1 144.54 150.27 187.82 104.12 45.38 40.59
painting 5.3 4.06 3.61 9.32 5.86 3.61 5.3 5.63 101.42 39.96 35.88
rendering 306.94 318.85 311.5 313.74 646.63 306.94 313.74 379.53 89.50 39.36 35.20

nidhi-nair
nidhi-nair previously approved these changes Sep 30, 2022
View reviewed changes
Aishwarya-U-R
Aishwarya-U-R reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests looks good!

app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/Datatypes/MySQL_Spec.ts Outdated Show resolved Hide resolved
@ChandanBalajiBP
Copy link
Contributor

/ok-to-test sha=39a6767

@subrata71 subrata71 enabled auto-merge (squash) September 30, 2022 15:29
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3159873742.
Workflow: Appsmith External Integration Test Workflow.
Commit: 39a6767.
PR: 17017.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3159873742.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 383.7 349.2 354.48 339.28 381.24 339.28 354.48 361.58 12.28 5.49 4.91
painting 4.93 6.81 3.11 5.86 3.55 3.11 4.93 4.85 76.29 31.96 28.45
rendering 109.25 106.51 105.29 104.95 110.62 104.95 106.51 107.32 5.28 2.33 2.09
BIND_TABLE_DATA
scripting 1199.79 1082.47 1045.06 1093.57 1097.4 1045.06 1093.57 1103.66 14.02 5.22 4.67
painting 24.38 21.47 11.74 20.56 22.85 11.74 21.47 20.2 62.57 24.46 21.88
rendering 854.38 871.74 806.48 823.83 868.88 806.48 854.38 845.06 7.72 3.40 3.04
CLICK_ON_TABLE_ROW
scripting 873.93 969.68 964.25 953.44 920.62 873.93 953.44 936.38 10.23 4.25 3.80
painting 9.68 11.14 9.64 8.63 10.61 8.63 9.68 9.94 25.25 9.76 8.75
rendering 303.48 316.88 306.02 295.2 328.14 295.2 306.02 309.94 10.63 4.12 3.69
UPDATE_POST_TITLE
scripting 1620.21 1451.7 1425.11 1271.11 1445.8 1271.11 1445.8 1442.79 24.20 8.58 7.68
painting 17.77 23.04 13.8 12.74 17 12.74 17 16.87 61.06 23.95 21.46
rendering 661.44 661.69 622.07 586.21 620.96 586.21 622.07 630.47 11.97 5.05 4.52
OPEN_MODAL
scripting 496.6 458.91 443.84 445.48 892.84 443.84 458.91 547.53 82.00 35.47 31.72
painting 16.64 11.4 12.15 11.84 16.78 11.4 12.15 13.76 39.10 19.62 17.59
rendering 1287.28 1203.75 1189.52 1197.22 1189.93 1189.52 1197.22 1213.54 8.06 3.43 3.07
CLOSE_MODAL
scripting 225.54 218.25 221.01 229.69 193.09 193.09 221.01 217.52 16.83 6.59 5.89
painting 5.04 18.43 4.48 5.23 5.2 4.48 5.2 7.68 181.64 78.39 70.05
rendering 979.44 892.15 908.68 896.36 904.31 892.15 904.31 916.19 9.53 3.92 3.51
SELECT_WIDGET_MENU_OPEN
scripting 1036.8 952.51 938.52 961.21 948.53 938.52 952.51 967.51 10.16 4.09 3.66
painting 7.64 4.9 10.71 5.56 6.08 4.9 6.08 6.98 83.24 33.24 29.66
rendering 719.57 636.64 641.52 643.42 642.52 636.64 642.52 656.73 12.63 5.36 4.80
SELECT_WIDGET_SELECT_OPTION
scripting 164.01 160.32 163.32 154.46 147.1 147.1 160.32 157.84 10.71 4.49 4.02
painting 13.2 6.19 6.85 6.46 3.97 3.97 6.46 7.33 125.92 47.34 42.29
rendering 323.69 310.4 305.36 310.93 305.09 305.09 310.4 311.09 5.98 2.43 2.17

@ChandanBalajiBP
Copy link
Contributor

/ok-to-test sha=a05f496

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3179606363.
Workflow: Appsmith External Integration Test Workflow.
Commit: a05f496.
PR: 17017.

Aishwarya-U-R
Aishwarya-U-R approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress looks good!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3179606363.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 366.23 413.16 352.35 368.66 346.05 346.05 366.23 369.29 18.17 7.11 6.36
painting 5.57 3.43 3.07 3.96 2.94 2.94 3.43 3.79 69.39 28.23 25.33
rendering 108 114.68 105.61 107.33 108.34 105.61 108 108.79 8.34 3.18 2.84
BIND_TABLE_DATA
scripting 1101.43 1223.21 1088.62 1013.83 1082.38 1013.83 1088.62 1101.89 19.00 6.89 6.16
painting 24.91 36.56 23.78 12.68 14.71 12.68 23.78 22.53 105.99 42.25 37.77
rendering 857.46 950.06 836.59 787.87 827.85 787.87 836.59 851.97 19.04 7.09 6.34
CLICK_ON_TABLE_ROW
scripting 852.28 1047.69 953.57 879.61 911.49 852.28 911.49 928.93 21.04 8.22 7.35
painting 15.39 23.43 13.07 9.62 8.94 8.94 13.07 14.09 102.84 41.45 37.05
rendering 308.84 327.16 318.08 294.81 300.72 294.81 308.84 309.92 10.44 4.20 3.76
UPDATE_POST_TITLE
scripting 1481.59 1655.92 1338.4 1947.8 1574.79 1338.4 1574.79 1599.7 38.09 14.23 12.72
painting 13.09 16.7 15.72 17.61 16.27 13.09 16.27 15.88 28.46 10.71 9.57
rendering 623.34 680.88 601.62 598.1 654.1 598.1 623.34 631.61 13.11 5.61 5.02
OPEN_MODAL
scripting 444.64 530.26 464.07 424.86 496.59 424.86 464.07 472.08 22.33 8.88 7.94
painting 9.89 19.28 18.09 11.97 14.34 9.89 14.34 14.71 63.83 26.99 24.13
rendering 1196.51 1355.49 1196.26 1169.1 1242.54 1169.1 1196.51 1231.98 15.13 6.00 5.37
CLOSE_MODAL
scripting 709.88 282.98 197.59 185.73 208.46 185.73 208.46 316.93 165.38 70.34 62.91
painting 5.4 17.07 4.6 8.84 9.09 4.6 8.84 9 138.56 54.89 49.11
rendering 893.95 1007.05 911.45 887.64 923.72 887.64 911.45 924.76 12.91 5.21 4.66
SELECT_WIDGET_MENU_OPEN
scripting 1097.88 981.22 940.67 951.91 933.84 933.84 951.91 981.1 16.72 6.91 6.18
painting 12.06 9.23 5.66 5.86 9.05 5.66 9.05 8.37 76.46 31.90 28.55
rendering 755.78 692.07 655.15 648.28 655.11 648.28 655.15 681.28 15.78 6.61 5.92
SELECT_WIDGET_SELECT_OPTION
scripting 180.62 178.03 152.96 174.19 168.98 152.96 174.19 170.96 16.18 6.42 5.74
painting 8.2 2.36 4.72 3.4 4.82 2.36 4.72 4.7 124.26 46.81 41.91
rendering 331.24 320.98 313.97 355.94 303.09 303.09 320.98 325.04 16.26 6.18 5.53

@subrata71 subrata71 merged commit d2de8f7 into release Oct 4, 2022
@subrata71 subrata71 deleted the feat/16621-datatype-handling-in-mysql branch October 4, 2022 10:45
@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code Community Reported issues reported by community members High This issue blocks a user from building or impacts a lot of users Production Verified When issue is retested post its fixed and removed Bug Something isn't working labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChandanBalajiBP ChandanBalajiBP ChandanBalajiBP left review comments

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

@nidhi-nair nidhi-nair Awaiting requested review from nidhi-nair

Assignees
No one assigned
Labels
Backend This marks the issue or pull request to reference server code BE Coders Pod Issues related to users writing code to fetch and update data Community Reported issues reported by community members Data Platform Pod Issues related to the underlying data platform Datatype issue Issues that have risen because data types weren't handled Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Integrations Pod Issues related to a specific integration MySQL Issues related to MySQL plugin Needs Triaging Needs attention from maintainers to triage Postgres Postgres related issues Production Task A simple Todo Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Verified When issue is retested post its fixed
Projects
None yet
Milestone
No milestone
5 participants
@subrata71 @ChandanBalajiBP @Aishwarya-U-R @nidhi-nair @prapullac