Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix/additional rows api header section #17052

Merged
merged 7 commits into from
Sep 30, 2022
Merged

fix: Fix/additional rows api header section #17052

merged 7 commits into from
Sep 30, 2022

Conversation

sneha122
Copy link
Contributor

Description

When the user navigates to the Header section on the API it is observed that the additional two rows are automatically added into the section

Fixes #11832

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually Tested
  • Jest Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 26, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 10:19AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Integrations Pod Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Regressed Scenarios that were working before but have now regressed Release REST API plugin REST API plugin related issues Up for grabs Issues that have little to no dependencies on design/product, can be picked up in an ad-hoc manner labels Sep 26, 2022
@github-actions github-actions bot removed the Bug Something isn't working label Sep 26, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sneha122
Copy link
Contributor Author

/ok-to-test sha=329b294

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3126788318.
Workflow: Appsmith External Integration Test Workflow.
Commit: 329b294.
PR: 17052.

@sneha122 sneha122 changed the title Fix: Fix/additional rows api header section fix: Fix/additional rows api header section Sep 26, 2022
@github-actions github-actions bot added the Bug Something isn't working label Sep 26, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3126788318.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 332.83 369.02 362.88 347.24 366.22 332.83 362.88 355.64 10.18 4.30 3.84
painting 3.08 3.71 6.17 3.45 4.15 3.08 3.71 4.11 75.18 29.44 26.52
rendering 105.31 103.85 107.3 105.07 114.14 103.85 105.31 107.13 9.61 3.84 3.43
BIND_TABLE_DATA
scripting 1060.25 1011.66 1030.46 1069.75 1110.93 1011.66 1060.25 1056.61 9.40 3.62 3.23
painting 16.87 14.37 20.71 18.44 16.35 14.37 16.87 17.35 36.54 13.72 12.28
rendering 818.64 812.12 826.5 795.28 851.99 795.28 818.64 820.91 6.91 2.54 2.27
CLICK_ON_TABLE_ROW
scripting 837.55 901.37 885.77 927.86 920.65 837.55 901.37 894.64 10.09 4.02 3.59
painting 9 10.84 15.48 17.39 9.12 9 10.84 12.37 67.83 31.04 27.81
rendering 293.19 306.02 318.93 297.36 303.39 293.19 303.39 303.78 8.47 3.24 2.90
UPDATE_POST_TITLE
scripting 1537.97 1491.1 1270.02 1462.15 1510.36 1270.02 1491.1 1454.32 18.42 7.34 6.56
painting 14.15 17.91 11.87 13.13 14.36 11.87 14.15 14.28 42.30 15.76 14.15
rendering 473.69 485.71 448.47 464.98 481.62 448.47 473.69 470.89 7.91 3.15 2.82
OPEN_MODAL
scripting 436.88 514.48 451.66 918.18 475.9 436.88 475.9 559.42 86.04 36.23 32.41
painting 12.67 16.48 9.93 11.95 16.04 9.93 12.67 13.41 48.84 20.81 18.64
rendering 385.53 390.39 385.29 367.77 383.68 367.77 385.29 382.53 5.91 2.26 2.02
CLOSE_MODAL
scripting 219.18 177.25 181.26 222.1 223.89 177.25 219.18 204.74 22.78 11.41 10.21
painting 3.6 7.6 4.03 16.46 10.39 3.6 7.6 8.42 152.73 62.71 56.18
rendering 334.65 337.24 343.95 335.94 332.39 332.39 335.94 336.83 3.43 1.29 1.16
SELECT_WIDGET_MENU_OPEN
scripting 927.71 938.66 939.43 955.06 978.48 927.71 939.43 947.87 5.36 2.08 1.86
painting 5.06 5.71 5.83 5.74 5.78 5.06 5.74 5.62 13.70 5.69 4.98
rendering 591.55 600.45 598.97 598.11 665.29 591.55 598.97 610.87 12.07 5.01 4.48
SELECT_WIDGET_SELECT_OPTION
scripting 147.46 156.02 161.19 158.05 157.64 147.46 157.64 156.07 8.80 3.31 2.96
painting 7.35 4.44 3.98 2.75 6.21 2.75 4.44 4.95 92.93 36.97 33.13
rendering 310.67 309.79 317.23 316.81 323.19 309.79 316.81 315.54 4.25 1.73 1.55

@sneha122
Copy link
Contributor Author

/ok-to-test sha=bef1882

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3128089686.
Workflow: Appsmith External Integration Test Workflow.
Commit: bef1882.
PR: 17052.

AmanAgarwal041
AmanAgarwal041 previously approved these changes Sep 26, 2022
View reviewed changes
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3128089686.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 430.67 425.92 379 349.91 365.92 349.91 379 390.28 20.69 9.29 8.30
painting 4.51 7.91 7.62 3.16 3.37 3.16 4.51 5.31 89.45 43.31 38.79
rendering 122.93 122.9 109.42 109.12 109.93 109.12 109.93 114.86 12.02 6.41 5.73
BIND_TABLE_DATA
scripting 1170.09 1149.86 1204.32 1077.92 1045.17 1045.17 1149.86 1129.47 14.09 5.85 5.23
painting 27.33 20.65 11.74 20.91 29.31 11.74 20.91 21.99 79.90 31.33 28.06
rendering 938.02 949.68 802.54 834.67 902.78 802.54 902.78 885.54 16.62 7.28 6.51
CLICK_ON_TABLE_ROW
scripting 911.03 1005.85 1050.53 1250.81 1387.45 911.03 1050.53 1121.13 42.49 17.28 15.46
painting 16.27 13.33 20.15 16.84 10.71 10.71 16.27 15.46 61.06 23.22 20.76
rendering 332.03 324.52 328.06 320.3 322.24 320.3 324.52 325.43 3.60 1.44 1.29
UPDATE_POST_TITLE
scripting 1712.5 1466.33 1498.94 2131.98 1731.94 1466.33 1712.5 1708.34 38.96 15.56 13.91
painting 15.91 17.62 14.7 18.13 17.14 14.7 17.14 16.7 20.54 8.32 7.43
rendering 491.3 507.39 487 495.37 513.9 487 495.37 498.99 5.39 2.26 2.02
OPEN_MODAL
scripting 518.21 472.85 497.59 501.14 499.54 472.85 499.54 497.87 9.11 3.26 2.91
painting 8.74 14.32 10.95 10.53 15.59 8.74 10.95 12.03 56.94 23.61 21.11
rendering 401.62 418.8 427.17 398.73 419.17 398.73 418.8 413.1 6.88 2.98 2.67
CLOSE_MODAL
scripting 239.94 192.69 244.39 240.82 229.67 192.69 239.94 229.5 22.53 9.28 8.30
painting 4.57 4.97 4.77 9.86 16.47 4.57 4.97 8.13 146.37 63.47 56.83
rendering 351.2 360.16 369.39 367.99 347.63 347.63 360.16 359.27 6.06 2.71 2.43
SELECT_WIDGET_MENU_OPEN
scripting 1081.7 965.49 1029.68 964.56 939.72 939.72 965.49 996.23 14.25 5.85 5.23
painting 7.44 6.08 8.11 5.44 10.78 5.44 7.44 7.57 70.54 27.48 24.57
rendering 669.71 616.26 643.44 624.1 601.91 601.91 624.1 631.08 10.74 4.17 3.73
SELECT_WIDGET_SELECT_OPTION
scripting 179.5 182.39 161.7 167.07 155.24 155.24 167.07 169.18 16.05 6.84 6.12
painting 3.62 2.15 2.19 2.09 3.47 2.09 2.19 2.7 56.67 28.52 25.56
rendering 342.13 309.66 320.56 319.29 313.07 309.66 319.29 320.94 10.12 3.94 3.53

@sneha122
Copy link
Contributor Author

/ok-to-test sha=d38e655

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3135896403.
Workflow: Appsmith External Integration Test Workflow.
Commit: d38e655.
PR: 17052.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3135896403.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 641.07 950.05 509.69 551.7 590.74 509.69 590.74 648.65 67.89 27.03 24.18
painting 9.35 8.79 7.05 10.99 5.39 5.39 8.79 8.31 67.39 25.99 23.23
rendering 198 217.62 122.44 133.53 131.17 122.44 133.53 160.55 59.28 27.34 24.45
BIND_TABLE_DATA
scripting 2088.52 2162.26 1417.62 2050.57 2113.98 1417.62 2088.52 1966.59 37.86 15.74 14.08
painting 40.36 46.39 26.77 28.85 40.97 26.77 40.36 36.67 53.50 23.04 20.62
rendering 827.47 996.09 1008.02 712.27 854.99 712.27 854.99 879.77 33.62 14.08 12.59
CLICK_ON_TABLE_ROW
scripting 1847.31 2125.46 1236.92 1872.18 1510.04 1236.92 1847.31 1718.38 51.71 20.18 18.05
painting 30.53 25.84 17.12 24.06 19.68 17.12 24.06 23.45 57.19 22.43 20.04
rendering 570.99 515.9 367.8 456.36 452.43 367.8 456.36 472.7 42.98 16.11 14.41
UPDATE_POST_TITLE
scripting 3547.05 3006.16 2033.83 2271.3 2380.36 2033.83 2380.36 2647.74 57.15 23.34 20.87
painting 37.2 33.82 24.19 23.89 30.11 23.89 30.11 29.84 44.60 19.64 17.56
rendering 890.51 794.94 576.85 587.26 637.32 576.85 637.32 697.38 44.98 19.90 17.80
OPEN_MODAL
scripting 1072.72 553.05 584.56 624.65 726.99 553.05 624.65 712.39 72.95 29.73 26.59
painting 36.66 12.84 12.17 16.7 16.02 12.17 16.02 18.88 129.71 53.65 47.99
rendering 722.87 447.08 424.71 442.56 511.6 424.71 447.08 509.76 58.49 24.24 21.68
CLOSE_MODAL
scripting 438.92 436.62 247.86 297.53 402.24 247.86 402.24 364.63 52.40 23.85 21.33
painting 9.21 8.75 19.93 7.2 9.17 7.2 9.17 10.85 117.33 47.37 42.40
rendering 627.59 370.42 367.65 402.89 449.87 367.65 402.89 443.68 58.59 24.35 21.78
SELECT_WIDGET_MENU_OPEN
scripting 1451.56 1192.96 1285.54 1304.39 1310.25 1192.96 1304.39 1308.94 19.76 7.08 6.33
painting 21.53 7.68 14.11 10.57 16.6 7.68 14.11 14.1 98.23 38.01 34.04
rendering 1036.31 762.07 906.12 800.82 898.77 762.07 898.77 880.82 31.13 12.13 10.85
SELECT_WIDGET_SELECT_OPTION
scripting 274.04 218.69 226.28 215.35 217.13 215.35 218.69 230.3 25.48 10.77 9.64
painting 5.34 16.71 7.48 3.27 3.56 3.27 5.34 7.27 184.87 76.20 68.09
rendering 564.26 374.22 358.76 387.96 381.8 358.76 381.8 413.4 49.71 20.57 18.40

@sneha122
Copy link
Contributor Author

/ok-to-test sha=f9e47e1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3142770951.
Workflow: Appsmith External Integration Test Workflow.
Commit: f9e47e1.
PR: 17052.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3142770951.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 345.53 385.42 360.28 352.17 707.47 345.53 360.28 430.17 84.14 36.21 32.38
painting 13.29 6.18 8.33 3.11 10.54 3.11 8.33 8.29 122.80 47.29 42.22
rendering 107.69 113.48 105.99 110.91 156.27 105.99 110.91 118.87 42.30 17.76 15.88
BIND_TABLE_DATA
scripting 1092.79 1146.49 1008.88 1087.51 2049.93 1008.88 1092.79 1277.12 81.52 34.04 30.45
painting 22.5 31.81 11.41 12.76 50.53 11.41 22.5 25.8 151.63 62.36 55.78
rendering 815.75 897.7 783.99 813.69 802.56 783.99 813.69 822.74 13.82 5.32 4.76
CLICK_ON_TABLE_ROW
scripting 859.98 1086.41 887.36 889.58 2107.42 859.98 889.58 1166.15 106.97 45.78 40.95
painting 9.92 10.03 10.12 14.07 32.23 9.92 10.12 15.27 146.10 63.13 56.45
rendering 293.12 344.37 290.66 303 601.52 290.66 303 366.53 84.81 36.32 32.49
UPDATE_POST_TITLE
scripting 1429 1546.71 1394.48 1297.62 2881.96 1297.62 1429 1709.95 92.65 38.67 34.59
painting 15.21 17.57 13.8 16.13 37.47 13.8 16.13 20.04 118.11 49.10 43.91
rendering 448.45 498.25 457.28 448.18 615.96 448.18 457.28 493.62 33.99 14.47 12.95
OPEN_MODAL
scripting 447.31 485.01 912.2 437.5 523.12 437.5 485.01 561.03 84.61 35.51 31.76
painting 9.32 11.76 15.89 10.24 22.83 9.32 11.76 14.01 96.43 39.54 35.33
rendering 373.96 416.34 375.81 373.32 402.34 373.32 375.81 388.35 11.08 5.10 4.56
CLOSE_MODAL
scripting 209.47 197.39 188.96 180.25 237.15 180.25 197.39 202.64 28.08 10.91 9.76
painting 4.15 10.57 7.46 9.58 8.44 4.15 8.44 8.04 79.85 30.72 27.49
rendering 329.81 370.15 333.73 342.41 367.75 329.81 342.41 348.77 11.57 5.45 4.87
SELECT_WIDGET_MENU_OPEN
scripting 942.15 1495.85 954.64 1718.43 1050.37 942.15 1050.37 1232.29 62.99 28.70 25.67
painting 6.54 8.78 5.15 11.81 6.94 5.15 6.94 7.84 84.95 32.78 29.34
rendering 600.2 865.72 595.47 1281.9 668.41 595.47 668.41 802.34 85.55 36.10 32.29
SELECT_WIDGET_SELECT_OPTION
scripting 150.87 266.17 163.45 239.69 194.68 150.87 194.68 202.97 56.81 24.24 21.69
painting 2.14 7.7 2.8 6.31 3.83 2.14 3.83 4.56 121.93 51.97 46.49
rendering 303.21 365.95 308.75 354.75 322.99 303.21 322.99 331.13 18.95 8.43 7.54

@prapullac prapullac added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Sep 29, 2022
@sneha122 sneha122 enabled auto-merge (squash) September 30, 2022 05:01
@nidhi-nair nidhi-nair merged commit 9670fa2 into release Sep 30, 2022
@nidhi-nair nidhi-nair deleted the fix/additional-rows-api-header-section branch September 30, 2022 06:31
@SatishGandham
Copy link
Contributor

@sneha122 , where is this used. I see a lot of failures in perf test.

@sneha122
Copy link
Contributor Author

sneha122 commented Oct 3, 2022

@sneha122 , where is this used. I see a lot of failures in perf test.

It is used in API Editor, in headers, params tabs, to load key value pairs form.

@SatishGandham SatishGandham restored the fix/additional-rows-api-header-section branch October 4, 2022 04:34
@SatishGandham
Copy link
Contributor

/ok-to-test sha=f9e47e1

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3179445922.
Workflow: Appsmith External Integration Test Workflow.
Commit: f9e47e1.
PR: 17052.

@mohanarpit mohanarpit deleted the fix/additional-rows-api-header-section branch October 10, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Integrations Pod Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Regressed Scenarios that were working before but have now regressed Release REST API plugin REST API plugin related issues Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Up for grabs Issues that have little to no dependencies on design/product, can be picked up in an ad-hoc manner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]-[1400]:Additional rows gets added into the header section on new created REST API
5 participants
@sneha122 @SatishGandham @AmanAgarwal041 @nidhi-nair @prapullac