chore: Making the error pages conform to the design system #17109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
skip-changelog
|
Unable to find test scripts. Please add necessary tests to the PR. |
1 similar comment
|
Unable to find test scripts. Please add necessary tests to the PR. |
albinAppsmith
approved these changes
Sep 27, 2022
hetunandu
approved these changes
Sep 28, 2022
hetunandu
added
the
IDE Navigation
yatinappsmith
added a commit
that referenced
this pull request
Sep 29, 2022
* feat: audit-logs parity with ee (#17115) * fix: update rts logic to use updated shared AST logic (#16849) * update rts logic to use updated shared AST logic * Make changes to naming conventions * Add test cases for RTS and rename ast functions * Add running jest test to RTS workflow * Install dependencies and then trigger jest tests in workflow * Close server connection after test ends * Remove logs * Improve jest test descriptions * fix: RTE + Form + JSONForm reskinning (#16956) * update rich text editor styles * fix disalbed text color * add border * fix gaps and borders in json form * fix disabled state * fix checkbox disabled state color on checkbox + font size of title in json * fix disabled state of rte not re-rendering * remove unused import * fix cypress test * chore: Add view mode to the analytics events (#15791) * Add view mode to the analytics events * Add view mode to the analytics events * Fix UnSupported operation with template * Replace hardcoded strings * feat: Map Chart Reskinning (#16921) * feat: Map Chart Reskinning - Update font family based on theme - Fix caption, spacing, and legend styles * feat: Add migrations for Font Family of Map Chart * feat: Add migrations to test * fix: Fixed NPE issue with analytics event on authentication method configuration (#17112) * chore: Making the error pages conform to the design system (#17109) Co-authored-by: f0c1s <anubhav@appsmith.com> Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Dhruvik Neharia <dhruvik@appsmith.com> Co-authored-by: Vishnu Gp <vishnu@appsmith.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Vijetha-Kaja
pushed a commit
that referenced
this pull request
Dec 20, 2022
* feat: audit-logs parity with ee (#17115) * fix: update rts logic to use updated shared AST logic (#16849) * update rts logic to use updated shared AST logic * Make changes to naming conventions * Add test cases for RTS and rename ast functions * Add running jest test to RTS workflow * Install dependencies and then trigger jest tests in workflow * Close server connection after test ends * Remove logs * Improve jest test descriptions * fix: RTE + Form + JSONForm reskinning (#16956) * update rich text editor styles * fix disalbed text color * add border * fix gaps and borders in json form * fix disabled state * fix checkbox disabled state color on checkbox + font size of title in json * fix disabled state of rte not re-rendering * remove unused import * fix cypress test * chore: Add view mode to the analytics events (#15791) * Add view mode to the analytics events * Add view mode to the analytics events * Fix UnSupported operation with template * Replace hardcoded strings * feat: Map Chart Reskinning (#16921) * feat: Map Chart Reskinning - Update font family based on theme - Fix caption, spacing, and legend styles * feat: Add migrations for Font Family of Map Chart * feat: Add migrations to test * fix: Fixed NPE issue with analytics event on authentication method configuration (#17112) * chore: Making the error pages conform to the design system (#17109) Co-authored-by: f0c1s <anubhav@appsmith.com> Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Dhruvik Neharia <dhruvik@appsmith.com> Co-authored-by: Vishnu Gp <vishnu@appsmith.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error pages within Appsmith weren't using the design system components. Now they conform to the Appsmith Design System
Type of change
Before
After
How Has This Been Tested?
Manual
Checklist: