-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Static 404 page for chunk issue #17168
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
app/client/public/404.html
Outdated
<span class="button primary" onclick="refresh()">Refresh</span> | ||
</div> | ||
<div class="try-again-container"> | ||
<p class="try-again-text">Trying again in 2 minutes</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to keep such a big retry timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user can refresh immediately, but if they don't it will automatically refresh in 2 minutes.
We chose 2 minutes as I thought if the server is down and causing this, it would get back up in around 2 minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But will we hit this error screen if the server is down? Or will it happen if old chunks are being returned to the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For any reason, a chunk file is not downloaded, we will re attempt 3 times and then land on this screen.
Reasons why chunk is not download:
- The client has an old version of the app and hence an old link of a chunk, which is not present on the server to download
- The current server is unable to serve this file because it is down
- The server has not yet been updated but the client has so it does not have the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output looks good, Let's hope this works 🙏
Unable to find test scripts. Please add necessary tests to the PR. |
1 similar comment
Unable to find test scripts. Please add necessary tests to the PR. |
/ok-to-test sha=fad2d89 |
Deployment failed with the following error:
|
Deployment failed with the following error:
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3149372970. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3149372970. Click to view performance test results
|
/ok-to-test 504bd9e |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156461770. |
1 similar comment
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156461770. |
/ok-to-test sha=5e0544b |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156604214. |
Description
Redirect to a static 404 page to avoid showing the user a blank screen
Fixes #9740
Type of change
Checklist: