Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Static 404 page for chunk issue #17168

Merged
merged 15 commits into from
Sep 30, 2022
Merged

feat: Static 404 page for chunk issue #17168

merged 15 commits into from
Sep 30, 2022

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Sep 29, 2022

Description

Redirect to a static 404 page to avoid showing the user a blank screen

Screenshot 2022-09-29 at 11 26 27 AM

Fixes #9740

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 6:03AM (UTC)

<span class="button primary" onclick="refresh()">Refresh</span>
</div>
<div class="try-again-container">
<p class="try-again-text">Trying again in 2 minutes</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to keep such a big retry timeout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user can refresh immediately, but if they don't it will automatically refresh in 2 minutes.
We chose 2 minutes as I thought if the server is down and causing this, it would get back up in around 2 minutes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But will we hit this error screen if the server is down? Or will it happen if old chunks are being returned to the client?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any reason, a chunk file is not downloaded, we will re attempt 3 times and then land on this screen.

Reasons why chunk is not download:

  • The client has an old version of the app and hence an old link of a chunk, which is not present on the server to download
  • The current server is unable to serve this file because it is down
  • The server has not yet been updated but the client has so it does not have the file

kocharrahul7
kocharrahul7 previously approved these changes Sep 29, 2022
Copy link
Contributor

@kocharrahul7 kocharrahul7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output looks good, Let's hope this works 🙏

@github-actions github-actions bot added Bug Something isn't working Critical This issue needs immediate attention. Drop everything else IDE Issues related to the IDE New Developers Pod Issues that new developers face while exploring the IDE QA Needs QA attention QAVerificationBlocked Bug cannot be verified. Enhancement New feature or request and removed Bug Something isn't working labels Sep 29, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@hetunandu
Copy link
Member Author

/ok-to-test sha=fad2d89

@vercel
Copy link

vercel bot commented Sep 29, 2022

Deployment failed with the following error:

Resource is limited - try again in 44 minutes (more than 100, code: "api-deployments-free-per-day").

@vercel
Copy link

vercel bot commented Sep 29, 2022

Deployment failed with the following error:

Resource is limited - try again in 43 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3149372970.
Workflow: Appsmith External Integration Test Workflow.
Commit: fad2d89.
PR: 17168.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3149372970.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 504.64 505.41 373.17 381.77 446.91 373.17 446.91 442.38 29.89 14.44 12.92
painting 6.29 8.22 3.64 3.38 4.32 3.38 4.32 5.17 93.62 39.65 35.40
rendering 130.06 128.89 109.39 124.76 129.4 109.39 128.89 124.5 16.60 6.99 6.25
BIND_TABLE_DATA
scripting 1604.11 1717.27 1091.18 1202.7 1146.53 1091.18 1202.7 1352.36 46.30 21.22 18.98
painting 17.11 33.55 23.33 21.87 37.65 17.11 23.33 26.7 76.93 32.10 28.69
rendering 577.41 641.65 877.9 890.87 976.29 577.41 877.9 792.82 50.31 21.83 19.52
CLICK_ON_TABLE_ROW
scripting 1294.85 1397.11 1034.31 983.6 1148.46 983.6 1148.46 1171.67 35.29 14.83 13.26
painting 18.99 17.8 10.71 12.37 13.5 10.71 13.5 14.67 56.44 24.27 21.75
rendering 401.85 440.74 338.46 318.22 349.47 318.22 349.47 369.75 33.14 13.60 12.16
UPDATE_POST_TITLE
scripting 2501.1 2375.6 1465.93 1569.25 1915.47 1465.93 1915.47 1965.47 52.67 23.65 21.15
painting 32.45 28.17 13.5 17.9 21.89 13.5 21.89 22.78 83.19 33.54 29.98
rendering 1030.84 1054.8 650.56 654.48 730.56 650.56 730.56 824.25 49.04 24.54 21.95
OPEN_MODAL
scripting 652.07 664.09 449.11 542.11 546.76 449.11 546.76 570.83 37.66 15.55 13.91
painting 19.62 11.28 20.41 12.08 20.44 11.28 19.62 16.77 54.62 27.79 24.87
rendering 1660.45 1623.02 1245.54 1320.01 1411.33 1245.54 1411.33 1452.07 28.57 12.62 11.29
CLOSE_MODAL
scripting 290.51 286.33 229.5 266 231 229.5 266 260.67 23.41 11.23 10.05
painting 9.76 7.42 5.65 12.09 9.5 5.65 9.5 8.88 72.52 27.59 24.66
rendering 1156.37 1077.86 932.34 959.15 1002.83 932.34 1002.83 1025.71 21.84 8.92 7.98
SELECT_WIDGET_MENU_OPEN
scripting 1408.49 1085.66 1005.23 1052.98 1074.33 1005.23 1074.33 1125.34 35.83 14.33 12.82
painting 22.73 7 7.85 12.1 7.06 7 7.85 11.35 138.59 59.03 52.78
rendering 926.8 722.12 692.52 722.13 723.66 692.52 722.13 757.45 30.93 12.62 11.29
SELECT_WIDGET_SELECT_OPTION
scripting 230.54 163.7 153.91 165.87 181.25 153.91 165.87 179.05 42.80 16.98 15.19
painting 7.96 7.4 5.06 3.74 4.53 3.74 5.06 5.74 73.52 32.06 28.75
rendering 455.78 321.86 308.75 320.19 346.05 308.75 321.86 350.53 41.95 17.23 15.41

@hetunandu
Copy link
Member Author

/ok-to-test 504bd9e

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156461770.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 17168.

1 similar comment
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156461770.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 17168.

@hetunandu
Copy link
Member Author

/ok-to-test sha=5e0544b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3156604214.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5e0544b.
PR: 17168.

@hetunandu hetunandu merged commit 6db40c1 into release Sep 30, 2022
@hetunandu hetunandu deleted the fix/handle-js-404 branch September 30, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Enhancement New feature or request IDE Issues related to the IDE New Developers Pod Issues that new developers face while exploring the IDE QA Needs QA attention QAVerificationBlocked Bug cannot be verified.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] expected expression, got '<'
3 participants