Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding mode for graphql syntax with dynamic bindings #17229

Merged
merged 6 commits into from
Oct 8, 2022
Merged

fix: adding mode for graphql syntax with dynamic bindings #17229

merged 6 commits into from
Oct 8, 2022

Conversation

AmanAgarwal041
Copy link
Contributor

Description

Adding mode for dynamic binding with quotes for graphql query syntax.

Fixes #16702

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 8:48AM (UTC)

@github-actions github-actions bot added Bug Something isn't working GraphQL Plugin Issues related to GraphQL plugin Integrations Pod Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage labels Sep 30, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=34c11dd

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3159869960.
Workflow: Appsmith External Integration Test Workflow.
Commit: 34c11dd.
PR: 17229.

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3159869960.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 345.81 341 330.9 353.72 345.18 330.9 345.18 343.32 6.65 2.43 2.17
painting 6.22 3.9 4.29 6.31 6.71 3.9 6.22 5.49 51.18 23.50 20.95
rendering 105.11 103.16 101.95 107.96 104.9 101.95 104.9 104.62 5.74 2.18 1.95
BIND_TABLE_DATA
scripting 1053.18 1109.67 1003.38 1178.3 1128.23 1003.38 1109.67 1094.55 15.98 6.20 5.54
painting 13.32 14.45 13.86 18.2 10.39 10.39 13.86 14.04 55.63 19.94 17.81
rendering 801.22 805.6 785.16 817.89 732.39 732.39 801.22 788.45 10.84 4.24 3.79
CLICK_ON_TABLE_ROW
scripting 1081.69 873.08 886.2 899.09 895.78 873.08 895.78 927.17 22.50 9.38 8.39
painting 8.39 12.03 9.01 9.86 9.39 8.39 9.39 9.74 37.37 14.27 12.73
rendering 323.84 293.97 317.26 288.78 302.29 288.78 302.29 305.23 11.49 4.91 4.39
UPDATE_POST_TITLE
scripting 1487.65 1293.12 1313.46 1406.83 1462.59 1293.12 1406.83 1392.73 13.97 6.25 5.59
painting 13.43 12.46 15.71 19.61 13.55 12.46 13.55 14.95 47.83 19.13 17.12
rendering 612.45 599.28 603.57 592.52 597.39 592.52 599.28 601.04 3.32 1.25 1.12
OPEN_MODAL
scripting 430.9 437.99 454.98 455.03 470.86 430.9 454.98 449.95 8.88 3.50 3.13
painting 10.98 10.71 11.99 16.53 18.37 10.71 11.99 13.72 55.83 25.51 22.81
rendering 1196.49 1181.86 1218.93 1172.22 1257.69 1172.22 1196.49 1205.44 7.09 2.83 2.53
CLOSE_MODAL
scripting 202.24 178.93 242.91 190.17 214.62 178.93 202.24 205.77 31.09 11.99 10.72
painting 9.37 12.92 14.49 7.91 7.91 7.91 9.37 10.52 62.55 28.71 25.67
rendering 887.27 881.2 913.57 870.77 962.98 870.77 887.27 903.16 10.21 4.09 3.66
SELECT_WIDGET_MENU_OPEN
scripting 920.87 905.92 931.77 985.28 937.67 905.92 931.77 936.3 8.48 3.20 2.86
painting 4.94 5.35 8.8 9.31 4.61 4.61 5.35 6.6 71.21 34.24 30.61
rendering 640.09 627.08 648.18 664.26 634.45 627.08 640.09 642.81 5.78 2.22 1.99
SELECT_WIDGET_SELECT_OPTION
scripting 161.38 152.86 158.11 176.74 153.64 152.86 158.11 160.55 14.87 6.04 5.40
painting 1.93 3.41 2.23 3.92 6.31 1.93 3.41 3.56 123.03 48.88 43.82
rendering 306.14 307.28 303.21 323.49 307.95 303.21 307.28 309.61 6.55 2.57 2.30

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=db6db2c

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3173900505.
Workflow: Appsmith External Integration Test Workflow.
Commit: db6db2c.
PR: 17229.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3173900505.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 353.68 331.47 357.44 369.28 438.92 331.47 357.44 370.16 29.03 11.02 9.86
painting 3.38 3.2 6.78 8.12 14.02 3.2 6.78 7.1 152.39 62.25 55.63
rendering 104.69 104.13 115.61 111.03 150.5 104.13 111.03 117.19 39.57 16.39 14.67
BIND_TABLE_DATA
scripting 1047.83 1096.19 1112.44 1133.13 1214.11 1047.83 1112.44 1120.74 14.84 5.44 4.86
painting 19.14 19.34 22.99 19.35 28.73 19.14 19.35 21.91 43.77 18.90 16.89
rendering 798.39 824.55 849.6 842.11 986.85 798.39 842.11 860.3 21.91 8.54 7.63
CLICK_ON_TABLE_ROW
scripting 823.99 911.51 894.77 966.94 1214.26 823.99 911.51 962.29 40.56 15.57 13.93
painting 13.11 12.21 16.91 12.14 16.28 12.14 13.11 14.13 33.76 16.21 14.51
rendering 291.77 321.99 315.93 321.99 392.21 291.77 321.99 328.78 30.55 11.43 10.23
UPDATE_POST_TITLE
scripting 1501.6 1410.91 1454.83 1374.44 2171.69 1374.44 1454.83 1582.69 50.37 21.02 18.80
painting 15.47 15.28 15.88 15.85 25.39 15.28 15.85 17.57 57.54 24.93 22.25
rendering 667.73 645.3 621.18 613.2 796.08 613.2 645.3 668.7 27.35 11.12 9.94
OPEN_MODAL
scripting 467.91 442.88 464.37 479.86 751.59 442.88 467.91 521.32 59.22 24.82 22.20
painting 11.9 8.44 8.8 9.17 19.27 8.44 9.17 11.52 94.01 39.41 35.24
rendering 1198.43 1194.21 1208.77 1250.27 1801.12 1194.21 1208.77 1330.56 45.61 19.84 17.75
CLOSE_MODAL
scripting 199.81 201.46 234.55 202.08 910.46 199.81 202.08 349.67 203.23 89.75 80.27
painting 8.5 14.53 10.75 9.12 8.06 8.06 9.12 10.19 63.49 25.81 23.06
rendering 911.04 891.13 927.57 937.07 1354.1 891.13 927.57 1004.18 46.10 19.56 17.49
SELECT_WIDGET_MENU_OPEN
scripting 973.62 1061.81 991.54 1004.04 994.15 973.62 994.15 1005.03 8.77 3.34 2.99
painting 5.9 6.81 7.7 10.5 6.2 5.9 6.81 7.42 61.99 24.93 22.37
rendering 660.44 727.62 675.37 687.58 698.83 660.44 687.58 689.97 9.74 3.69 3.30
SELECT_WIDGET_SELECT_OPTION
scripting 150.78 178.22 182.82 154.47 166.81 150.78 166.81 166.62 19.23 8.46 7.57
painting 1.86 3.65 6.73 6.4 2.47 1.86 3.65 4.22 115.40 53.08 47.39
rendering 312.3 363.23 328.8 314.24 350.17 312.3 328.8 333.75 15.26 6.71 6.00

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=1d88366

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3203418502.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1d88366.
PR: 17229.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3203418502.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 499.41 436.65 393.53 383.87 349.42 349.42 393.53 412.58 36.35 13.97 12.50
painting 6.21 4.92 7.6 5.63 3.53 3.53 5.63 5.58 72.94 27.06 24.19
rendering 126.6 117.38 115.05 112.32 109.94 109.94 115.05 116.26 14.33 5.52 4.95
BIND_TABLE_DATA
scripting 1275.22 1152.86 1234.98 1114.03 1149.25 1114.03 1152.86 1185.27 13.60 5.66 5.06
painting 31.34 27.02 38.61 24.66 13.91 13.91 27.02 27.11 91.11 33.53 29.99
rendering 1035.94 915.94 943.19 882.11 915.73 882.11 915.94 938.58 16.39 6.24 5.58
CLICK_ON_TABLE_ROW
scripting 1068.12 1014.31 1135.34 1042.86 948.38 948.38 1042.86 1041.8 17.95 6.60 5.91
painting 17.22 10.24 14.31 11.97 8.23 8.23 11.97 12.39 72.56 28.25 25.26
rendering 360.88 333.52 337.48 332.65 310.96 310.96 333.52 335.1 14.90 5.30 4.74
UPDATE_POST_TITLE
scripting 1111.58 1094.67 1144.99 1075.5 989.3 989.3 1094.67 1083.21 14.37 5.39 4.82
painting 9.61 12.93 12.44 12.63 13.35 9.61 12.63 12.19 30.68 12.14 10.91
rendering 645.68 663.84 684.69 652.06 632.93 632.93 652.06 655.84 7.89 2.99 2.67
OPEN_MODAL
scripting 499.84 624.27 571.32 506.28 569.3 499.84 569.3 554.2 22.45 9.33 8.34
painting 10.77 12.99 14.28 14.81 9.54 9.54 12.99 12.48 42.23 18.11 16.19
rendering 1278.92 1416.37 1299.13 1274.98 1260.71 1260.71 1278.92 1306.02 11.92 4.84 4.33
CLOSE_MODAL
scripting 234.93 301.31 316.93 225.53 234.46 225.53 234.93 262.63 34.80 16.36 14.63
painting 9.68 7.48 6 6.99 5.85 5.85 6.99 7.2 53.19 21.39 19.17
rendering 943.27 1016.7 995.22 924.31 974.26 924.31 974.26 970.75 9.52 3.87 3.46
SELECT_WIDGET_MENU_OPEN
scripting 352.26 357 321.21 339.21 294.19 294.19 339.21 332.77 18.87 7.71 6.89
painting 15.96 16.3 7.5 12.35 7.54 7.5 12.35 11.93 73.76 36.13 32.36
rendering 751.64 764.64 708.07 726.84 671.76 671.76 726.84 724.59 12.82 5.07 4.54
SELECT_WIDGET_SELECT_OPTION
scripting 177.7 209.19 154.44 172.33 167.94 154.44 172.33 176.32 31.05 11.51 10.29
painting 2.86 2.85 2.44 4.18 2.17 2.17 2.85 2.9 69.31 26.55 23.79
rendering 335.31 335.84 314.36 334.77 310.18 310.18 334.77 326.09 7.87 3.90 3.49

@AmanAgarwal041 AmanAgarwal041 added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Oct 7, 2022
@AmanAgarwal041
Copy link
Contributor Author

Adding Test Plan Approved label as the issue is moved to Done pipeline.

@AmanAgarwal041 AmanAgarwal041 enabled auto-merge (squash) October 7, 2022 22:04
@AmanAgarwal041 AmanAgarwal041 merged commit ab10645 into release Oct 8, 2022
@AmanAgarwal041 AmanAgarwal041 deleted the fix/16702-gql-moustache-bind branch October 8, 2022 02:17
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3217373231.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 17229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irongade Irongade Irongade approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working GraphQL Plugin Issues related to GraphQL plugin Integrations Pod Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: moustache+quotes formatting goes wrong in graphql body | autocomplete fail
2 participants
@AmanAgarwal041 @Irongade