Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/show number of records #1734

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

vvkpd
Copy link
Contributor

@vvkpd vvkpd commented Nov 16, 2020

Description

Fixes # (issue)
#1205

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mohanarpit mohanarpit added the Bug Something isn't working label Nov 16, 2020
@mohanarpit mohanarpit marked this pull request as ready for review November 18, 2020 07:10
@mohanarpit
Copy link
Member

@vvkpd Thank you for your contribution to Appsmith! I've approved the changes. Right now, we have a minor issue with the CI. I'll merge this change once we resolve the CI build.

@mohanarpit mohanarpit merged commit de435ed into appsmithorg:release Nov 18, 2020
@mohanarpit mohanarpit linked an issue Nov 19, 2020 that may be closed by this pull request
@vvkpd vvkpd deleted the fix/show-number-of-records branch November 22, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Table should show the number of records instead of the pages
2 participants