Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Video Widget Reskinning #17355

Merged
merged 2 commits into from
Oct 7, 2022
Merged

feat: Video Widget Reskinning #17355

merged 2 commits into from
Oct 7, 2022

Conversation

dhruvikn
Copy link
Contributor

@dhruvikn dhruvikn commented Oct 6, 2022

Description

Add #000 default background color to the video widget. This enables the Video Widget borders to follow the theme even when the container is not the same size as the video.

Fixes #11021

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dhruvikn dhruvikn added Enhancement New feature or request App Viewers Pod This label assigns issues to the app viewers pod Low An issue that is neither critical nor breaks a user flow Video Widget labels Oct 6, 2022
@dhruvikn dhruvikn self-assigned this Oct 6, 2022
@vercel
Copy link

vercel bot commented Oct 6, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 7:17PM (UTC)

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@dhruvikn
Copy link
Contributor Author

dhruvikn commented Oct 6, 2022

/ok-to-test sha=42b2de7

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3197378102.
Workflow: Appsmith External Integration Test Workflow.
Commit: 42b2de7.
PR: 17355.

@laveena-en
Copy link
Contributor

Hey @dhruvikn Looks like the deployment failed. Can you check this please?

@dhruvikn
Copy link
Contributor Author

dhruvikn commented Oct 6, 2022

/ok-to-test sha=9af6751

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3199802777.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9af6751.
PR: 17355.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3199802777.
Commit: ``.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 344.72 359.18 344.97 356.02 362.94 344.72 356.02 353.57 5.15 2.36 2.11
painting 5.17 3.32 3.4 6.33 7.05 3.32 5.17 5.05 73.86 33.47 29.90
rendering 108.43 105.22 105.51 110.2 109.05 105.22 108.43 107.68 4.62 2.05 1.84
BIND_TABLE_DATA
scripting 1064.81 1043.55 1108.02 1052.11 1043.38 1043.38 1052.11 1062.37 6.08 2.54 2.27
painting 18.98 15.76 22.71 19.3 19.17 15.76 19.17 19.18 36.24 12.83 11.47
rendering 858.55 818.32 828.23 815.26 814.45 814.45 818.32 826.96 5.33 2.24 2.00
CLICK_ON_TABLE_ROW
scripting 834.25 971.68 953.49 947.84 934.58 834.25 947.84 928.37 14.80 5.85 5.23
painting 8.97 11.29 11.76 9.94 11.35 8.97 11.29 10.66 26.17 10.98 9.76
rendering 305.35 306.39 299.24 306.95 310.61 299.24 306.39 305.71 3.72 1.35 1.21
UPDATE_POST_TITLE
scripting 996.2 897.27 855.03 835.52 922.4 835.52 897.27 901.28 17.83 7.00 6.26
painting 10 8.2 8.81 10.26 15.28 8.2 10 10.51 67.36 26.64 23.79
rendering 599.31 596.36 588.8 592.62 606.18 588.8 596.36 596.65 2.91 1.11 0.99
OPEN_MODAL
scripting 473.81 482.42 449.13 478.75 458.1 449.13 473.81 468.44 7.11 3.04 2.72
painting 16.83 19.29 12.14 18.64 7.83 7.83 16.83 14.95 76.66 32.51 29.10
rendering 1235.46 1233.7 1167.76 1237.6 1189.09 1167.76 1233.7 1212.72 5.76 2.66 2.38
CLOSE_MODAL
scripting 247.77 195.04 220.88 189.47 268.39 189.47 220.88 224.31 35.18 15.08 13.49
painting 14.4 5.8 7.42 8.48 13.28 5.8 8.48 9.88 87.04 38.06 34.11
rendering 918.31 920.72 879.1 890.96 917.23 879.1 917.23 905.26 4.60 2.10 1.88
SELECT_WIDGET_MENU_OPEN
scripting 292.33 279.35 288.4 297.65 280.15 279.35 288.4 287.58 6.36 2.74 2.45
painting 6.57 13.72 5.91 6.21 6.87 5.91 6.57 7.86 99.36 41.98 37.53
rendering 657.59 644.07 641.24 662.35 644.42 641.24 644.42 649.93 3.25 1.45 1.29
SELECT_WIDGET_SELECT_OPTION
scripting 168.35 165.82 161.19 171.38 197.35 161.19 168.35 172.82 20.92 8.22 7.35
painting 4.85 2.25 4.06 3.85 3.67 2.25 3.85 3.74 69.52 25.13 22.73
rendering 387.9 307.33 313.92 321.4 321.41 307.33 321.4 330.39 24.39 9.89 8.85

@dhruvikn
Copy link
Contributor Author

dhruvikn commented Oct 6, 2022

Hey @dhruvikn Looks like the deployment failed. Can you check this please?

@laveena-en here you go - https://appsmith-1f7wqtj4t-get-appsmith.vercel.app/

@laveena-en
Copy link
Contributor

Tested and verified the changes.

@dhruvikn dhruvikn merged commit 97c86af into release Oct 7, 2022
@dhruvikn dhruvikn deleted the reskinning/video branch October 7, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees

@dhruvikn dhruvikn

Labels
App Viewers Pod This label assigns issues to the app viewers pod Enhancement New feature or request Low An issue that is neither critical nor breaks a user flow Video Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] : Video widget reskinning
3 participants
@dhruvikn @laveena-en @jsartisan