Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Datasource autosave improvements #17649

Merged
merged 78 commits into from
Nov 30, 2022
Merged

feat: Datasource autosave improvements #17649

merged 78 commits into from
Nov 30, 2022

Conversation

sneha122
Copy link
Contributor

@sneha122 sneha122 commented Oct 18, 2022 •
edited

Description

In Appsmith we try to autosave everywhere. Today when a user clicks on a new datasource, it creates new named resource even though the user might have just been exploring.

Fixes #4381

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 3:17PM (UTC)

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code Integrations Pod Issues related to a specific integration Needs Design needs design or changes to design snowflake Issues related to the snowflake Integration UX Improvement and removed Enhancement New feature or request labels Oct 18, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@vercel
Copy link

vercel bot commented Oct 20, 2022

Deployment failed with the following error:

Resource is limited - try again in 5 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added the Enhancement New feature or request label Oct 20, 2022
@sneha122 sneha122 changed the title Datasource autosave improvements WIP feat: Datasource autosave improvements Oct 20, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sneha122 sneha122 marked this pull request as ready for review October 25, 2022 12:19
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sneha122
Copy link
Contributor Author

/ok-to-test sha=a335614

Aishwarya-U-R
Aishwarya-U-R reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress looks good!

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=13b93b5

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3562934881.
Workflow: Appsmith External Integration Test Workflow.
Commit: 13b93b5.
PR: 17649.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17649&runId=3562934881_1

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=331ca85

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3565334955.
Workflow: Appsmith External Integration Test Workflow.
Commit: 331ca85.
PR: 17649.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17649&runId=3565334955_1

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=3a84755

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3566206295.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a84755.
PR: 17649.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17649&runId=3566206295_1

@prapullac prapullac added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 29, 2022
@sneha122
Copy link
Contributor Author

/perf-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3572922920.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 17649.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17649&runId=3572922920_1

@Rhitottam
Copy link
Contributor

/perf-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3574437792.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 17649.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17649&runId=3574437792_1

@sneha122 sneha122 merged commit b5902bf into release Nov 30, 2022
@sneha122 sneha122 deleted the feat/datasoure-autosave-improvements branch November 30, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 left review comments

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code Integrations Pod Issues related to a specific integration Needs Design needs design or changes to design snowflake Issues related to the snowflake Integration Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable UX Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]-[4000]:Autosave for new datasources needs improvements
5 participants
@sneha122 @Aishwarya-U-R @prapullac @Rhitottam @AmanAgarwal041