Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default position to TOP for widgets with labels #17726

Merged
merged 4 commits into from Oct 27, 2022

Conversation

adarshlilha
Copy link
Contributor

@adarshlilha adarshlilha commented Oct 19, 2022

Description

Changes default label position to TOP for the below widgets:

  • Inputs
    • Text Input
    • Phone Input
    • Currency Input
  • Select
    • Select
    • TreeSelect
    • MultiSelect
    • MultiTree Select
  • DatePicker
  • Group Widgets
    • Radio group
    • Switch group
    • Checkbox group

Fixes #17143
Screenshot 2022-10-19 at 19 00 09

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual - does not break the existing tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 19, 2022

@adarshlilha is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 26, 2022 at 8:51AM (UTC)

@adarshlilha adarshlilha changed the title Feature/change label pos feat: change default position to TOP for widgets with labels Oct 19, 2022
yarn.lock Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@Tooluloope
Copy link
Contributor

/ok-to-test sha=22415c9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3343124553.
Workflow: Appsmith External Integration Test Workflow.
Commit: 22415c9.
PR: 17726.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17726&runId=3343124553_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Change default label position to top for all widgets which have labels
3 participants