Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed check for incorrect dynamic bindings #1775

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Fixed check for incorrect dynamic bindings #1775

merged 3 commits into from
Nov 18, 2020

Conversation

nidhi-nair
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

mohanarpit
mohanarpit previously approved these changes Nov 18, 2020
View reviewed changes
@nidhi-nair nidhi-nair merged commit 941be8c into release Nov 18, 2020
@nidhi-nair nidhi-nair deleted the fix/ignore-invalid-dynamic-bindings branch November 18, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaanand trishaanand trishaanand approved these changes

@mohanarpit mohanarpit mohanarpit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nidhi-nair @mohanarpit @trishaanand