Change Sentry log 'environment' tag value. #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change Sentry log 'environment' tag value to 'Properties' from 'properties'.
1. Change Sentry log 'environment' tag value to 'Properties' from 'properties'.
…m/appsmith into fix/sentry_env_attribute
mohanarpit
reviewed
Nov 19, 2020
| @@ -32,6 +32,7 @@ segment.writeKey=${APPSMITH_SEGMENT_KEY:} | |||
| sentry.dsn=${APPSMITH_SENTRY_DSN:} | |||
| sentry.send-default-pii=true | |||
| sentry.debug=off | |||
| sentry.environment=${APPSMITH_SENTRY_ENVIRONMENT:} | |||
There was a problem hiding this comment.
Where will the environment APPSMITH_SENTRY_ENVIRONMENT be defined? Can you please add it to the file .env.example in the project root?
There was a problem hiding this comment.
Also make the change in .env.example in the root of the Appsmith project. Not just the server folder.
…m/appsmith into fix/sentry_env_attribute
…m/appsmith into fix/sentry_env_attribute
…m/appsmith into fix/sentry_env_attribute
…m/appsmith into fix/sentry_env_attribute
trishaanand
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes appsmithorg/appsmith #1737
Type of change
How Has This Been Tested?
Checklist: