Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: App card boundaries UI #1798

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix: App card boundaries UI #1798

merged 2 commits into from
Nov 20, 2020

Conversation

devrk96
Copy link
Contributor

@devrk96 devrk96 commented Nov 19, 2020

Description

After this fix, hover UI on app cards will look the same on both sides of the card.

Fixes #1607

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@devrk96 devrk96 added the Bug Something isn't working label Nov 19, 2020
@devrk96 devrk96 self-assigned this Nov 19, 2020
hetunandu
hetunandu requested changes Nov 19, 2020
View reviewed changes
Copy link
Member

@hetunandu hetunandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still unequal. Left side is 13px and everywhere else it is 10

@mohanarpit mohanarpit merged commit 0da8c84 into release Nov 20, 2020
@mohanarpit mohanarpit deleted the fix/app-card-boundaries-ui branch November 20, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees

@devrk96 devrk96

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] UI : App card boundaries inconsistent
3 participants
@devrk96 @hetunandu @mohanarpit