-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Property pane search #18164
feat: Property pane search #18164
Conversation
…into pp-search-2
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/ok-to-test sha=ff9e819 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657685276. |
9578022
to
5ccd863
Compare
/ok-to-test sha=5ccd863 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663967051. |
/ok-to-test sha=0816476 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3664597625. |
/ok-to-test sha=44d07ad |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3667654054. |
// const shouldFocusSearch = useSelector(getShouldFocusPropertySearch); | ||
// const shouldFocusPanelSearch = useSelector(getShouldFocusPanelPropertySearch); | ||
|
||
// useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswathkk Are we removing the focus on property pane search, if the feature is not going in with this PR, i suggest we completely remove the code instead of commenting large sections of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a task #18847 for it. Once this merges, I will raise another PR with the changes. This PR has been getting stuck for a while because of merge conflicts in AnalyticUtils and I had to waste some CI time on every merge conflict fix.
I just thought of moving the blocker piece of code into a different PR and shipping this one ASAP.
Description
Adds the ability to search properties and sections inside the property pane.
Fixes #15970
Fixes #15904
Screen.Recording.2022-12-02.at.5.47.32.PM.mov
Type of change
How Has This Been Tested?
Search for properties that are there in the content & style tabs. Search for section names too.
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity: