Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Property pane search #18164

Merged
merged 78 commits into from
Dec 11, 2022
Merged

feat: Property pane search #18164

merged 78 commits into from
Dec 11, 2022

Conversation

aswathkk
Copy link
Contributor

@aswathkk aswathkk commented Nov 15, 2022

Description

Adds the ability to search properties and sections inside the property pane.

Fixes #15970
Fixes #15904

Screen.Recording.2022-12-02.at.5.47.32.PM.mov

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Search for properties that are there in the content & style tabs. Search for section names too.

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 11, 2022 at 6:04AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Deploy Preview Issues found in Deploy Preview Property Pane Issues related to the behaviour of the property pane Task A simple Todo UI Builders Pod Issues that UI Builders face using appsmith Enhancement New feature or request and removed Bug Something isn't working labels Nov 15, 2022
@aswathkk
Copy link
Contributor Author

aswathkk commented Dec 9, 2022

/ok-to-test sha=ff9e819

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657685276.
Workflow: Appsmith External Integration Test Workflow.
Commit: ff9e819.
PR: 18164.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18164&runId=3657685276_1

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=5ccd863

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663967051.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5ccd863.
PR: 18164.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18164&runId=3663967051_1

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=0816476

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3664597625.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0816476.
PR: 18164.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18164&runId=3664597625_1

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=44d07ad

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3667654054.
Workflow: Appsmith External Integration Test Workflow.
Commit: 44d07ad.
PR: 18164.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18164&runId=3667654054_1

// const shouldFocusSearch = useSelector(getShouldFocusPropertySearch);
// const shouldFocusPanelSearch = useSelector(getShouldFocusPanelPropertySearch);

// useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswathkk Are we removing the focus on property pane search, if the feature is not going in with this PR, i suggest we completely remove the code instead of commenting large sections of code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a task #18847 for it. Once this merges, I will raise another PR with the changes. This PR has been getting stuck for a while because of merge conflicts in AnalyticUtils and I had to waste some CI time on every merge conflict fix.
I just thought of moving the blocker piece of code into a different PR and shipping this one ASAP.

@aswathkk aswathkk merged commit ce2925c into release Dec 11, 2022
@aswathkk aswathkk deleted the feat/pp-search branch December 11, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Enhancement New feature or request Property Pane Issues related to the behaviour of the property pane Task A simple Todo UI Builders Pod Issues that UI Builders face using appsmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Issues with Property pane search [Bug]: Unable to delete widget using delete key
4 participants