Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google sheet datasource fix #18199

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix: Google sheet datasource fix #18199

merged 1 commit into from
Nov 17, 2022

Conversation

vaibh1297
Copy link
Contributor

Description

Generate page from google sheet datasource was throwing exception.
Fixed that exception using simple null check.

Fixes #18102

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Nov 16, 2022 at 0:08AM (UTC)

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Generate Page Issures related to page generation Google Sheets Issues related to Google Sheets High This issue blocks a user from building or impacts a lot of users Integrations Pod Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production labels Nov 16, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@subrata71
Copy link
Contributor

In order to get the context I was trying to reproduce the issue locally and later planning to verify the fix. Here's some updates from my end.

  • I was able to reproduce the same on local or on production without this fix
  • I was trying to verify whether this fix solves the issue or not but unfortunately there's a new error occurs when I click on generate page

Screenshot 2022-11-17 at 1 04 51 PM

cc: @vaibh1297 @btsgh

@subrata71 subrata71 self-requested a review November 17, 2022 07:09
Copy link
Contributor

@subrata71 subrata71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to get the context I was trying to reproduce the issue locally and later planning to verify the fix. Here's some updates from my end.

  • I was able to reproduce the same on local or on production without this fix
  • I was trying to verify whether this fix solves the issue or not but unfortunately there's a new error occurs when I click on generate page

Screenshot 2022-11-17 at 1 04 51 PM

cc: @vaibh1297 @btsgh

Copy link
Contributor

@subrata71 subrata71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem that I mentioned earlier seems to be specific to my local env. Hence I am approving this PR.

@vaibh1297
Copy link
Contributor Author

/ok-to-test sha=7785e78

1 similar comment
@sumitsum
Copy link
Contributor

/ok-to-test sha=7785e78

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3487767255.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7785e78.
PR: 18199.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18199&runId=3487767255_1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3487767754.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7785e78.
PR: 18199.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18199&runId=3487767754_1

@btsgh
Copy link

btsgh commented Nov 17, 2022

@vaibh1297 - Tested and found the issue to be fixed. Tried the CRUD flow on two environments with local setup.
cc: @prapullac

@rohitagarwal88 rohitagarwal88 merged commit bc516a5 into release Nov 17, 2022
@rohitagarwal88 rohitagarwal88 deleted the gs-ds-fix branch November 17, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Generate Page Issures related to page generation Google Sheets Issues related to Google Sheets High This issue blocks a user from building or impacts a lot of users Integrations Pod Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production
Projects
None yet
5 participants