-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Google sheet datasource fix #18199
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Unable to find test scripts. Please add necessary tests to the PR. |
In order to get the context I was trying to reproduce the issue locally and later planning to verify the fix. Here's some updates from my end.
cc: @vaibh1297 @btsgh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to get the context I was trying to reproduce the issue locally and later planning to verify the fix. Here's some updates from my end.
- I was able to reproduce the same on local or on production without this fix
- I was trying to verify whether this fix solves the issue or not but unfortunately there's a new error occurs when I click on
generate page
cc: @vaibh1297 @btsgh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem that I mentioned earlier seems to be specific to my local env. Hence I am approving this PR.
/ok-to-test sha=7785e78 |
1 similar comment
/ok-to-test sha=7785e78 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3487767255. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3487767754. |
@vaibh1297 - Tested and found the issue to be fixed. Tried the CRUD flow on two environments with local setup. |
Description
Fixes #18102
Type of change
How Has This Been Tested?
Checklist:
Dev activity
QA activity: