Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Aggregate calls to add and remove Appsmith errors #18285

Merged
merged 10 commits into from
Dec 7, 2022
Merged

fix: Aggregate calls to add and remove Appsmith errors #18285

merged 10 commits into from
Dec 7, 2022

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Nov 18, 2022 •
edited by AnandiKulkarni

Description

This PR aims at aggregating calls to update debugger logs. Previously, logs were getting updated singly, causing multiple re-renders to subscribing components.

Fixes #14007
Fixes #17650

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

  • Manual

  • Validate the error log for widget (canvas), Query , API and JSeditor. Verify Error count are displayed properly with compare to release environment

  • Validate console log for widget, query API and JSeditor. It should display all logs properly comparing with release environment

  • Verify the response for query, api and JSeditor functions are displayed properly

  • Verify the errors such as - Uncut exceptions , errors on widgets, query or database connectivity errors are displayed properly

  • Jest

  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Nov 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 7:59AM (UTC)

@github-actions github-actions bot added the Bug Something isn't working label Nov 18, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=3c89199

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3499898657.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3c89199.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3499898657_1

@arunvjn
Copy link
Contributor

arunvjn commented Nov 21, 2022

/ok-to-test sha=3c89199

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3512162930.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3c89199.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3512162930_1

@github-actions github-actions bot added Debugger Issues related to the debugger FE Coders Pod Issues related to users writing javascript in appsmith Frontend This label marks the issue or pull request to reference client code Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage labels Nov 22, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Performance Pod All things related to Appsmith performance Task A simple Todo labels Nov 22, 2022
@ohansFavour ohansFavour mentioned this pull request Nov 22, 2022
Closed
1 task
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour ohansFavour marked this pull request as draft November 22, 2022 10:18
@ohansFavour ohansFavour marked this pull request as ready for review November 22, 2022 16:27
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=a7fc2d9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3525253124.
Workflow: Appsmith External Integration Test Workflow.
Commit: a7fc2d9.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3525253124_1

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=d3ca910

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3542396572.
Workflow: Appsmith External Integration Test Workflow.
Commit: d3ca910.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3542396572_1

@ohansFavour
Copy link
Contributor Author

/perf-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3546328032.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3546328032_1

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=c7a99e5

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3560498551.
Workflow: Appsmith External Integration Test Workflow.
Commit: c7a99e5.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3560498551_1

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3619777189.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4ee892a.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3619777189_1

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=1dbcd87

@ohansFavour ohansFavour force-pushed the fix/aggregate-appsmith-console-update branch from 6d95125 to 4aff94d Compare December 6, 2022 08:15
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=4aff94d

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3627712247.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4aff94d.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3627712247_1

@AnandiKulkarni AnandiKulkarni added Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable and removed Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable labels Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3627712247.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4aff94d.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3627712247_3

@ohansFavour ohansFavour force-pushed the fix/aggregate-appsmith-console-update branch from 4aff94d to f14addf Compare December 7, 2022 07:52
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=f14addf

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636910273.
Workflow: Appsmith External Integration Test Workflow.
Commit: f14addf.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3636910273_1

@ohansFavour ohansFavour merged commit e37f741 into release Dec 7, 2022
@ohansFavour ohansFavour deleted the fix/aggregate-appsmith-console-update branch December 7, 2022 10:28
@AnandiKulkarni AnandiKulkarni added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunvjn arunvjn arunvjn approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Debugger Issues related to the debugger FE Coders Pod Issues related to users writing javascript in appsmith Frontend This label marks the issue or pull request to reference client code Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Performance Pod All things related to Appsmith performance Task A simple Todo Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
4 participants
@ohansFavour @arunvjn @Aishwarya-U-R @AnandiKulkarni