Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show filter & show download should not control add new row link visibility in table widget #18348

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: show filter & show download should not control add new row link visibility in table widget #18348

merged 1 commit into from
Dec 7, 2022

Conversation

sbalaji1192
Copy link
Contributor

@sbalaji1192 sbalaji1192 commented Nov 22, 2022 •
edited

Fixes #18346

Description

Now toggling the show filter and show download properties from the property pane should not hide/show the add new row link in the table header

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Nov 22, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 6:19AM (UTC)

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Table Widget labels Nov 22, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

4 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sbalaji1192 sbalaji1192 removed the Needs Triaging Needs attention from maintainers to triage label Nov 22, 2022
@github-actions github-actions bot added the Needs Triaging Needs attention from maintainers to triage label Nov 22, 2022
@laveena-en
Copy link
Contributor

Tested and verified this fix.
Add row is visible despite the usage of the filters/download option in the table widget.

keyurparalkar
keyurparalkar previously approved these changes Nov 23, 2022
View reviewed changes
@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=b1f9bd0

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3529484072.
Workflow: Appsmith External Integration Test Workflow.
Commit: b1f9bd0.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3529484072_1

@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Nov 30, 2022
@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=b1f9bd0

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3589990277.
Workflow: Appsmith External Integration Test Workflow.
Commit: b1f9bd0.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3589990277_1

@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=0467192

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3591483983.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0467192.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3591483983_1

@github-actions github-actions bot removed the Stale label Dec 1, 2022
@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=0467192

@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=f1fc7f4

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3599309963.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0467192.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3599309963_1

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3599311226.
Workflow: Appsmith External Integration Test Workflow.
Commit: f1fc7f4.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3599311226_1

@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=25b7031ee811ffa0aee6f828a630d1533b2550b4

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3617519143.
Workflow: Appsmith External Integration Test Workflow.
Commit: 25b7031ee811ffa0aee6f828a630d1533b2550b4.
PR: 18348.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18348&runId=3617519143_1

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@sbalaji1192 sbalaji1192 merged commit be997b2 into release Dec 7, 2022
@sbalaji1192 sbalaji1192 deleted the fix/table-add-new-row-toggle branch December 7, 2022 04:22
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyurparalkar keyurparalkar keyurparalkar approved these changes

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Table Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 'Add new row' hides from toolbar on disabling Filter & Download property in Table widget
3 participants
@sbalaji1192 @laveena-en @keyurparalkar