fix: Parse js actions for view mode changes #18357

ApekshaBhosale · 2022-11-22T14:13:58Z

Description

Each time we load an application in view/edit mode, we parse each js object body to get the functions and variables to be executed. After parsing, we convert each js object function from string to function format.

As part of performance improvement, we realized we don't need to parse each js object body to get functions and variables in view mode because we don't update js objects in view if any discrepancies are detected on the client and server-side.

As a result of that, we can completely rely on the state of the js object we get from the backend. Each js object has an actions property and each action has js function saved in the body in string format which can be converted into function format to be executed which makes view mode faster because we will avoid parsing .

Fixes #18291

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
https://github.com/appsmithorg/TestSmith/issues/2113
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

vercel · 2022-11-22T14:14:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 10:48AM (UTC)

github-actions · 2022-11-22T14:14:55Z

Unable to find test scripts. Please add necessary tests to the PR.

ApekshaBhosale · 2022-11-23T08:02:48Z

/ok-to-test sha=dd1dbf7

github-actions · 2022-11-23T08:03:15Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3530231300.
Workflow: Appsmith External Integration Test Workflow.
Commit: dd1dbf7.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3530231300_1

ApekshaBhosale · 2022-11-23T11:40:28Z

/ok-to-test sha=846e7d1

github-actions · 2022-11-23T12:07:24Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3531716068.
Workflow: Appsmith External Integration Test Workflow.
Commit: 846e7d1.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3531716068_1

github-actions · 2022-11-23T12:08:29Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3531884132.
Workflow: Appsmith External Integration Test Workflow.
Commit: 846e7d1.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3531884132_1

github-actions · 2022-11-23T12:08:37Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3531898511.
Workflow: Appsmith External Integration Test Workflow.
Commit: 846e7d1.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3531898511_1

ApekshaBhosale · 2022-11-23T14:11:09Z

/ok-to-test sha=a4aa226

github-actions · 2022-11-23T14:11:39Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3532804329.
Workflow: Appsmith External Integration Test Workflow.
Commit: a4aa226.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3532804329_1

ApekshaBhosale · 2022-11-25T08:32:05Z

/ok-to-test sha=80bb50a

github-actions · 2022-11-25T09:11:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3546691853.
Workflow: Appsmith External Integration Test Workflow.
Commit: 80bb50a.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3546691853_1

rimildeyjsr · 2022-11-29T03:09:19Z

/ok-to-test sha=80e7b11

github-actions · 2022-11-29T03:09:43Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3570650277.
Workflow: Appsmith External Integration Test Workflow.
Commit: 80e7b11.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18357&runId=3570650277_1

arunvjn · 2022-11-29T04:24:29Z

app/client/src/workers/Evaluation/JSObject/index.ts

+    delete dataTreeEvalRef.currentJSCollectionState[`${entityName}`];
+    const jsActions = entity.meta;
+    //think about adding variables as currentJSCollectionState
+    Object.keys(jsActions).forEach((jsAction: string) => {


We would have the functions inside resolvedFunctions already. Could you please check ?

github-actions · 2022-12-10T03:56:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3662543290.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4fb97e0.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18357&runId=3662543290_1

arunvjn · 2022-12-10T06:38:26Z

/perf-test

github-actions · 2022-12-10T06:38:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663065347.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18357&runId=3663065347_1

rimildeyjsr · 2022-12-12T05:52:26Z

/ok-to-test sha=ff924b6

github-actions · 2022-12-12T05:52:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673075541.
Workflow: Appsmith External Integration Test Workflow.
Commit: ff924b6.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18357&runId=3673075541_1

rimildeyjsr · 2022-12-12T10:42:14Z

/ok-to-test sha=575964e

github-actions · 2022-12-12T10:42:41Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3674980212.
Workflow: Appsmith External Integration Test Workflow.
Commit: 575964e.
PR: 18357.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18357&runId=3674980212_1

This reverts commit efa8b68.

Revert "fix: Parse js actions for view mode changes (#18357)" This reverts commit efa8b68.

vercel bot deployed to Preview – appsmith November 22, 2022 14:14 View deployment

vercel bot deployed to Preview – appsmith November 23, 2022 10:52 View deployment

vercel bot deployed to Preview – appsmith November 23, 2022 14:13 View deployment

ApekshaBhosale changed the title ~~[WIP] parse js actions for view mode changes~~ fix: Parse js actions for view mode changes Nov 24, 2022

github-actions bot added the Bug Something isn't working label Nov 24, 2022

vercel bot deployed to Preview – appsmith November 25, 2022 08:28 View deployment

ApekshaBhosale requested review from rimildeyjsr and arunvjn November 25, 2022 10:55

rimildeyjsr force-pushed the view-mode-parsejsactions-changes branch from a01446b to 80e7b11 Compare November 28, 2022 05:03

vercel bot deployed to Preview – appsmith November 28, 2022 05:06 View deployment

arunvjn reviewed Nov 29, 2022

View reviewed changes

vercel bot deployed to Preview – appsmith December 1, 2022 07:04 View deployment

vercel bot deployed to Preview – appsmith December 1, 2022 07:08 View deployment

vercel bot deployed to Preview – appsmith December 2, 2022 04:50 View deployment

vercel bot deployed to Preview – appsmith December 2, 2022 05:47 View deployment

rimildeyjsr removed their request for review December 2, 2022 05:47

vercel bot deployed to Preview December 10, 2022 04:03 View deployment

Merge branch 'release' into view-mode-parsejsactions-changes

ff924b6

vercel bot deployed to Preview December 12, 2022 05:49 View deployment

AnandiKulkarni added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Dec 12, 2022

Merge branch 'release' into view-mode-parsejsactions-changes

575964e

vercel bot deployed to Preview December 12, 2022 10:48 View deployment

arunvjn approved these changes Dec 12, 2022

View reviewed changes

rimildeyjsr merged commit efa8b68 into release Dec 12, 2022

rimildeyjsr deleted the view-mode-parsejsactions-changes branch December 12, 2022 14:15

rimildeyjsr mentioned this pull request Dec 19, 2022

revert: Parse js actions for view mode changes #19033

Merged

rimildeyjsr added a commit that referenced this pull request Dec 20, 2022

Revert "fix: Parse js actions for view mode changes (#18357)"

7671d62

This reverts commit efa8b68.

mohanarpit pushed a commit that referenced this pull request Dec 21, 2022

revert: Parse js actions for view mode changes (#19033)

d0ceef7

Revert "fix: Parse js actions for view mode changes (#18357)" This reverts commit efa8b68.

rimildeyjsr added a commit that referenced this pull request Dec 21, 2022

revert: Parse js actions for view mode changes (#19033)

717664b

Revert "fix: Parse js actions for view mode changes (#18357)" This reverts commit efa8b68.

rimildeyjsr mentioned this pull request Dec 21, 2022

chore: Cherry-pick #19033 to master #19087

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Parse js actions for view mode changes #18357

fix: Parse js actions for view mode changes #18357

ApekshaBhosale commented Nov 22, 2022 •

edited by rimildeyjsr

vercel bot commented Nov 22, 2022 •

edited

github-actions bot commented Nov 22, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 25, 2022

github-actions bot commented Nov 25, 2022

rimildeyjsr commented Nov 29, 2022

github-actions bot commented Nov 29, 2022

arunvjn Nov 29, 2022

github-actions bot commented Dec 10, 2022

arunvjn commented Dec 10, 2022

github-actions bot commented Dec 10, 2022

rimildeyjsr commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

rimildeyjsr commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

fix: Parse js actions for view mode changes #18357

fix: Parse js actions for view mode changes #18357

Conversation

ApekshaBhosale commented Nov 22, 2022 • edited by rimildeyjsr

Description

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

vercel bot commented Nov 22, 2022 • edited

github-actions bot commented Nov 22, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 23, 2022

github-actions bot commented Nov 23, 2022

ApekshaBhosale commented Nov 25, 2022

github-actions bot commented Nov 25, 2022

rimildeyjsr commented Nov 29, 2022

github-actions bot commented Nov 29, 2022

arunvjn Nov 29, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 10, 2022

arunvjn commented Dec 10, 2022

github-actions bot commented Dec 10, 2022

rimildeyjsr commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

rimildeyjsr commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

ApekshaBhosale commented Nov 22, 2022 •

edited by rimildeyjsr

vercel bot commented Nov 22, 2022 •

edited