fix: modal deselect issue auto height

[ankurrsinghal]

Description

-- Issue
The modal widget deselects when it's changed from AutoHeight to Fixed and vice-versa.

-- Reason
When Auto Height is enabled every widget is wrapped around AutoHeightContainerWrapper in BaseWidget but for canvas-like widgets, in this case, Modal Widget, it just returns its children back, so no change in the UI as such, but for react it's a completely new node and therefore it unmounts the previous component, and ModalWidget in one of its effect, deselects itself on unmount.

-- Fix
Added another check for ModalWidget using its detachFromLayout props before wrapping AutoHeightContainerWrapper in BaseWidget class. This allows ModalWidget to never enter AutoHeightContainerWrapper ever therefore the node remains the same hence no unmount.

Fixes #18697

Media
(https://www.loom.com/share/85fe3285d14944d680c4ebfe083f601a)

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• PR is being merged under a feature flag

QA activity:

• Test plan has been approved by relevant developers
• Test plan has been peer reviewed by QA
• Cypress test cases have been added and approved by either SDET or manual QA
• Organized project review call with relevant stakeholders after Round 1/2 of QA
• Added Test Plan Approved label after reveiwing all Cypress test

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 11, 2022 at 8:03AM (UTC)

[ankurrsinghal]

/ok-to-test sha=062f20c

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3638650029.
Workflow: Appsmith External Integration Test Workflow.
Commit: 062f20c.
PR: 18750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18750&runId=3638650029_1

[riodeuno]

This is a good solution, makes things faster. We do have to make sure there aren't any side effects.

[kamakshibhat-appsmith]

Checked the fix along with other use cases w.r.t modal widgets
Looks good, we can proceed @ankurrsinghal

[ankurrsinghal]

/ok-to-test sha=7dad083

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3648881787.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7dad083.
PR: 18750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18750&runId=3648881787_1

[ankurrsinghal]

/ok-to-test sha=812fcfb

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3668031306.
Workflow: Appsmith External Integration Test Workflow.
Commit: 812fcfb.
PR: 18750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18750&runId=3668031306_1