New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgraded Snake YAML version to 2.0 #23572
Conversation
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5053512323. |
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5131499636. |
@mohanarpit @nidhi-nair, still failing from ff4j:
|
Looks like this is because we're using a yaml parser to figure out ff4j flags. I can convert this to use an XML parser, it's been a while since the related PR on the ff4j repo has seen any activity. Do you folks think we should go ahead with conversion to XML? @sharat87 @mohanarpit |
@nidhi-nair, thanks. I like this. Irrespective of the priority of this dependency upgrade, and irrespective of when FF4J team decide to release support for the upgrade, I'd vote for moving to XML. As much as I prefer YAML syntax to XML, I have to admit that XML parsers are a lot more rock-solid and battle tested, than anything else. Can we make this permanent? Then perhaps we can just exclude the SnakeYAML dependency completely? |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5196098338. |
Deploy-Preview-URL: https://ce-23572.dp.appsmith.com |
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5206725181. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5206725181.
To know the list of identified flaky tests - Refer here |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5206725181. |
Description
Upgrades SnakeYaml dependency version forcefully to 2.0 to overcome this issue, as advised here.
This version tag can be reverted when we upgrade to Spring 6.1, which is when the library aims to upgrade the version themselves.
Fixes https://github.com/appsmithorg/appsmith-ee/issues/1233
Type of change
Testing
This PR will be tested during regression.