fix for ui crashing when the gmaps api key is incorrect

[rishabhsaxena]

Description

When the api key is incorrect/restricted by domain, gmaps mutates the DOM which results in an errored state.
If we have a good way to measure the performance impact, we can take a call for this. Open to other suggestions as well.

fixes #2378

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• manually

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[ofpiyush]

@hetunandu @riodeuno If you can find a better solve for this, please help out.

Otherwise, this seems to add 2 checks on every node removal from DOM. (Not sure how to measure the perf hit of that.)

[hetunandu]

@hetunandu @riodeuno If you can find a better solve for this, please help out.

Otherwise, this seems to add 2 checks on every node removal from DOM. (Not sure how to measure the perf hit of that.)

This fix does not sit well with me. Can we do something more targeted for the maps widget itself?

@hetunandu objected

[hetunandu]

Needs a more targeted approach for google maps component only

[ofpiyush]

I'm assuming that the objection more design neatness.

Things to figure:

• Can we add the problem component after verifying that we have a legitimate key? Would that prevent/solve the issue?
  • Eg: Would this also happen when the maps widget goes into loading?
• How important is the problem to solve?
  • How many users are facing this?
  • Should we spend time trying to dig deeper with the lib/sdk etc.
• Under what circumstances would we would accept a global solution like this?

[rishabhsaxena]

Closing this for now, since this seems like an edge case with using an incorrect gmaps API key. Also these errors are displayed on the console.