Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add htmlPageTitle hook and use it in login and sign up pages #24458

Merged
merged 1 commit into from
Jun 14, 2023
Merged

feat: add htmlPageTitle hook and use it in login and sign up pages #24458

merged 1 commit into from
Jun 14, 2023

Conversation

dhruvikn
Copy link
Contributor

Description

This is a supportive PR for https://github.com/appsmithorg/appsmith-ee/pull/1606

Please see this comment.

PR fixes following issue(s)

Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@dhruvikn dhruvikn self-assigned this Jun 14, 2023
@dhruvikn dhruvikn added Bug Something isn't working App Viewers Pod This label assigns issues to the app viewers pod Branding All issues under branding and whitelabelling appsmith ecosystem labels Jun 14, 2023
@github-actions github-actions bot added Enhancement New feature or request and removed Bug Something isn't working labels Jun 14, 2023
@dhruvikn dhruvikn added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 14, 2023
@dhruvikn
Copy link
Contributor Author

/ok-to-test

@dhruvikn dhruvikn requested a review from jsartisan June 14, 2023 09:13
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24458.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24458&runId=5265262818_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

1 similar comment
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

1 similar comment
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@dhruvikn dhruvikn added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jun 14, 2023
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5265262818.
Commit: ``.
All cypress tests have passed 🎉

@Aishwarya-U-R Aishwarya-U-R merged commit 9f3c24d into release Jun 14, 2023
19 of 24 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the fix/remove-appsmith-from-tab-title branch June 14, 2023 15:55
dhruvikn added a commit that referenced this pull request Jun 15, 2023
@dhruvikn
feat: add htmlPageTitle hook and use it in login and sign up pages (#…
9c8b05b 
…24458)

## Description

This is a supportive PR for
https://github.com/appsmithorg/appsmith-ee/pull/1606

Please see [this
comment](https://github.com/appsmithorg/appsmith-ee/pull/1606#issuecomment-1590634326).

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

(cherry picked from commit 9f3c24d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

@albinAppsmith albinAppsmith Awaiting requested review from albinAppsmith

@tanvibhakta tanvibhakta Awaiting requested review from tanvibhakta

Assignees

@dhruvikn dhruvikn

Labels
App Viewers Pod This label assigns issues to the app viewers pod Branding All issues under branding and whitelabelling appsmith ecosystem Enhancement New feature or request skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhruvikn @jsartisan @Aishwarya-U-R