Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: API pane style and integration changes #2467

Merged
merged 3 commits into from
Jan 8, 2021

Conversation

devrk96
Copy link
Contributor

@devrk96 devrk96 commented Jan 6, 2021

  • Placeholder added in the search component
  • Height of section API header section fixed

@devrk96 devrk96 requested a review from hetunandu January 6, 2021 15:11
@devrk96 devrk96 self-assigned this Jan 6, 2021
@devrk96 devrk96 changed the title Fix: API pane style changes Fix: API pane style and integration changes Jan 6, 2021
editInteractionKind={EditInteractionKind.SINGLE}
hideEditIcon={true}
/>
<ApiNameWrapper page={props.page}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment why this was needed and how it will be changed in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hetunandu Added the prop information.

Copy link
Member

@hetunandu hetunandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments

@devrk96 devrk96 requested a review from hetunandu January 7, 2021 14:14
@devrk96 devrk96 merged commit 41cbbfc into feature/api-pane-redesign Jan 8, 2021
@devrk96 devrk96 deleted the fix/design-bugs branch January 8, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants