Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gsheet preview data UI using tabs for preview and configuration #28318

Merged
merged 36 commits into from
Nov 3, 2023

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Oct 24, 2023

Description

This PR includes the changes :

  • UI consistency of gsheet datasource to other schema preview by having accordions for spreadsheets, sheets, & attributes
  • Tabs based ui for gsheet

figma link: https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=2804-49159&mode=dev
notion issue link : https://www.notion.so/appsmith/5c8aa998aa94429995a6e0825ca2df05?v=14883d075b6649be9a8748938dcc224b&p=b95ba7f3beb04e7cb9e9d97a3844abef&pm=s

PR fixes following issue(s)

Fixes #27947
Fixes #27843

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added Activation - datasources issues related to activation projects BE Coders Pod Issues related to users writing code to fetch and update data Google Sheets Issues related to Google Sheets Integrations Pod Issues related to a specific integration Task A simple Todo labels Oct 24, 2023
@AmanAgarwal041 AmanAgarwal041 changed the title Fix/27947 gsheet preview data UI fix: gsheet preview data UI using tabs for preview and configuration Oct 24, 2023
@github-actions github-actions bot added the Bug Something isn't working label Oct 24, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6622908897.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28318.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://ce-28318.dp.appsmith.com

@sumitsum
Copy link
Contributor

sumitsum commented Nov 1, 2023

/ok-to-test

Copy link

github-actions bot commented Nov 1, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28318.

Copy link

github-actions bot commented Nov 1, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/MultipleOnPageLoadConfirmation_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
  3. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true recreate=true

Copy link

github-actions bot commented Nov 1, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6724187434.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28318.
recreate: true.

Copy link

github-actions bot commented Nov 1, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

Copy link

github-actions bot commented Nov 1, 2023

Deploy-Preview-URL: https://ce-28318.dp.appsmith.com

Copy link

github-actions bot commented Nov 1, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

@chandannkumar
Copy link

Tested this PR and LGTM

  • Tested for sheets with data and empty sheets
  • Tested new design implementation for g-sheet

@chandannkumar chandannkumar added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 2, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true recreate=true

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

github-actions bot commented Nov 2, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6732067003.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28318.
recreate: true.

Copy link

github-actions bot commented Nov 2, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6732068206.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28318.

Copy link

github-actions bot commented Nov 2, 2023

Deploy-Preview-URL: https://ce-28318.dp.appsmith.com

Copy link

github-actions bot commented Nov 2, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732068206.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

  2. cypress/e2e/Regression/ClientSide/ThemingTests/Theme_FormWidget_spec.js
  3. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js
  4. cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
To know the list of identified flaky tests - Refer here

@chandannkumar
Copy link

Tested and verified the fixes. LGTM

@chandannkumar
Copy link

Tested & verified for Bug fix #27843

Copy link

github-actions bot commented Nov 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732068206.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug28287_Spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/UpdateApplication_spec.js
  3. cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js
  4. cypress/e2e/Regression/ClientSide/Workspace/WorkspaceImportApplication_spec.js
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

github-actions bot commented Nov 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6744656655.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28318.

Copy link

github-actions bot commented Nov 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6744656655.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug27817_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js
To know the list of identified flaky tests - Refer here

Copy link

github-actions bot commented Nov 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6744656655.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@AmanAgarwal041 AmanAgarwal041 merged commit 72c4b4d into release Nov 3, 2023
16 checks passed
@AmanAgarwal041 AmanAgarwal041 deleted the fix/27947-gsheet-preview-data-ui branch November 3, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activation - datasources issues related to activation projects BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Google Sheets Issues related to Google Sheets Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Task A simple Todo Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
5 participants