-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gsheet preview data UI using tabs for preview and configuration #28318
Conversation
…946-schema-preview-data-ui
…946-schema-preview-data-ui
…946-schema-preview-data-ui
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6622908897. |
Deploy-Preview-URL: https://ce-28318.dp.appsmith.com |
…horg/appsmith into fix/27947-gsheet-preview-data-ui
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6720434911. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
|
/build-deploy-preview skip-tests=true recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6724187434. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
To know the list of identified flaky tests - Refer here |
Deploy-Preview-URL: https://ce-28318.dp.appsmith.com |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6720434911.
To know the list of identified flaky tests - Refer here |
Tested this PR and LGTM
|
…947-gsheet-preview-data-ui
…horg/appsmith into fix/27947-gsheet-preview-data-ui
/build-deploy-preview skip-tests=true recreate=true |
/ok-to-test |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6732067003. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6732068206. |
Deploy-Preview-URL: https://ce-28318.dp.appsmith.com |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732068206.
|
Tested and verified the fixes. LGTM |
Tested & verified for Bug fix #27843 |
…947-gsheet-preview-data-ui
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732068206.
|
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6744656655. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6744656655.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6744656655. |
Description
This PR includes the changes :
figma link: https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=2804-49159&mode=dev
notion issue link : https://www.notion.so/appsmith/5c8aa998aa94429995a6e0825ca2df05?v=14883d075b6649be9a8748938dcc224b&p=b95ba7f3beb04e7cb9e9d97a3844abef&pm=s
PR fixes following issue(s)
Fixes #27947
Fixes #27843
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed