fix: handle clone errors gracefully #28451

ohansFavour · 2023-10-29T20:22:36Z

Description

This PR introduces custom transmission (clone) error handlers.

PR fixes following issue(s)

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual
JUnit
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

ohansFavour · 2023-10-29T20:32:20Z

/ok-to-test

ohansFavour · 2023-10-29T20:32:36Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-29T20:32:46Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6685642361.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28451.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=28451&runId=6685642361_1

github-actions · 2023-10-29T20:33:01Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6685643478.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28451.
recreate: .

github-actions · 2023-10-29T20:43:58Z

Deploy-Preview-URL: https://ce-28451.dp.appsmith.com

github-actions · 2023-10-29T21:46:12Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6685642361.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifierProperty_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-10-29T21:58:08Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6685642361.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

This reverts commit e4e93f7.

This reverts commit dda7dc7.

ohansFavour · 2023-10-30T11:23:28Z

/ok-to-test

github-actions · 2023-10-30T11:23:55Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6692073758.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28451.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=28451&runId=6692073758_1

github-actions · 2023-10-30T11:24:00Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6692075302.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 28451.
recreate: .

ohansFavour · 2023-10-30T11:24:02Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-30T11:24:27Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6692079011.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28451.
recreate: .

github-actions · 2023-10-30T11:37:05Z

Deploy-Preview-URL: https://ce-28451.dp.appsmith.com

github-actions · 2023-10-30T12:40:11Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6692073758.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/Select/Select3_Spec.ts
cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-10-30T12:59:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6692073758.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

arunvjn

Changes looks good!

ohansFavour · 2023-10-31T10:02:10Z

/ok-to-test

ohansFavour · 2023-10-31T10:02:29Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-31T10:02:38Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6704905850.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28451.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=28451&runId=6704905850_1

github-actions · 2023-10-31T10:02:57Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6704909539.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28451.
recreate: .

github-actions · 2023-10-31T10:15:59Z

Deploy-Preview-URL: https://ce-28451.dp.appsmith.com

github-actions · 2023-10-31T11:19:12Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6704905850.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/Select3_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-10-31T12:08:28Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6704905850.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/Select3_Spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-10-31T13:00:53Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6704905850.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-10-31T17:51:08Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6704905850.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

ohansFavour added 3 commits October 28, 2023 10:00

Add default states to prevent crash

620cba3

clone diffs

dda7dc7

Handle invalid worker response

e4e93f7

ohansFavour requested a review from ApekshaBhosale as a code owner October 29, 2023 20:22

ohansFavour removed the request for review from ApekshaBhosale October 29, 2023 20:22

ohansFavour changed the title ~~Fix/handle clone errors gracefully~~ fix: handle clone errors gracefully Oct 29, 2023

github-actions bot added the Bug Something isn't working label Oct 29, 2023

ohansFavour requested a review from arunvjn October 29, 2023 22:25

ohansFavour added 4 commits October 30, 2023 12:08

Add custom transmission error handler

f0bc790

Revert "Handle invalid worker response"

eaeca53

This reverts commit e4e93f7.

Revert "clone diffs"

641c991

This reverts commit dda7dc7.

type

7a9e11c

arunvjn previously approved these changes Oct 30, 2023

View reviewed changes

ohansFavour added 2 commits October 31, 2023 10:39

Minor fix

6e8a29b

Add test for evalTree errorHandler

5d4572a

ohansFavour dismissed arunvjn’s stale review via 5d4572a October 31, 2023 10:01

Aishwarya-U-R merged commit 215adcf into release Oct 31, 2023
13 of 15 checks passed

Aishwarya-U-R deleted the fix/handle-clone-errors-gracefully branch October 31, 2023 18:29

github-actions bot added Critical This issue needs immediate attention. Drop everything else FE Coders Pod Issues related to users writing javascript in appsmith JS Evaluation Issues related to JS evaluation on the platform Needs Triaging Needs attention from maintainers to triage labels Nov 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handle clone errors gracefully #28451

fix: handle clone errors gracefully #28451

ohansFavour commented Oct 29, 2023 •

edited

ohansFavour commented Oct 29, 2023

ohansFavour commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

ohansFavour commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

ohansFavour commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

arunvjn left a comment

ohansFavour commented Oct 31, 2023

ohansFavour commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

fix: handle clone errors gracefully #28451

fix: handle clone errors gracefully #28451

Conversation

ohansFavour commented Oct 29, 2023 • edited

Description

PR fixes following issue(s)

Media

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

ohansFavour commented Oct 29, 2023

ohansFavour commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

github-actions bot commented Oct 29, 2023

ohansFavour commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

ohansFavour commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

arunvjn left a comment

Choose a reason for hiding this comment

ohansFavour commented Oct 31, 2023

ohansFavour commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

ohansFavour commented Oct 29, 2023 •

edited