chore: added new relic OTLP exporter #28480

vsvamsi1 · 2023-10-30T12:43:00Z

Description

Added new relic OTLP exporter to export eval traces, click event and api calls.
Conditionally loading both browser agent and OTLP scripts based on env variables.

PR fixes following issue(s)

Fixes #28504 and #28506

Type of change

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

Manual
JUnit
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

vsvamsi1 · 2023-10-30T12:43:33Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-30T12:43:56Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6692937115.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-10-30T12:55:36Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-10-31T07:23:28Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-31T07:23:53Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6703327091.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-10-31T07:37:57Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-10-31T07:45:13Z

/build-deploy-preview skip-tests=true

github-actions · 2023-10-31T07:45:38Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6703500919.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-10-31T07:58:09Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-11-01T12:10:45Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-01T12:11:08Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6719464989.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-11-01T12:22:57Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-11-01T12:40:17Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-01T12:40:45Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6719765458.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-11-01T12:53:44Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-11-01T19:30:50Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-01T19:31:16Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6724218512.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

vsvamsi1 · 2023-11-01T19:47:34Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-01T19:48:00Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6724369072.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-11-01T20:01:28Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-11-01T20:14:36Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-01T20:15:01Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6724625825.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-11-01T20:27:52Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

vsvamsi1 · 2023-11-01T20:42:24Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-04T04:16:15Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

github-actions · 2023-11-04T05:16:22Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6752628846.
Commit: c6f00231fc9f4d46d219f6d7ebf0383959cc1174.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-11-04T05:17:51Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6752648880.
Commit: e060f609bd516ce4e8003a9765efc120a9cda1f1.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts

To know the list of identified flaky tests - Refer here

rajatagrawal · 2023-11-04T06:05:03Z

app/client/src/auto-otel-web.js

+const { applicationId, otlpLicenseKey } = newRelic;
+
+const NEW_RELIC_OTLP_ENTITY_NAME = "Appsmith Frontend OTLP";
+const NEW_RELIC_OTLP_ENDPOINT = "https://otlp.nr-data.net:4318";


@vsvamsi1

I feel that we should move this url to environment variables too. Not sure if hard coding it here is appropriate even though it may be harmless.

@trishaanand Can you please share your viewpoints on this ?

These values will be fairly static, the collector endpoint is not dynamic and is available in new relic's documentation in the public domain. Its the same endpoint all new relic users need to export their telemetry information to.

If its necessary I can still do this but there are several places i need to update these vars, which i do not have to access to and will take some time to test it out. Let me know if we can defer this @rajatagrawal @trishaanand for now?

cc : @sharat87 FYI

If it is a common url for everyone using newrelic to post their OTLP metrics to, I think that we can keep it in frontend code only then.

I'd prefer to hard-code this, especially if it's going to be the same for everyone. Overall, my stance for taking decisions on things like this, is fewer configurable parameters on the system means fewer combinations of configurations that we need to test. Basically convention over configuration. 🙂

app/client/public/index.html

app/client/src/utils/WorkerUtil.ts

vsvamsi1 · 2023-11-05T12:23:12Z

/build-deploy-preview skip-tests=true

vsvamsi1 · 2023-11-05T12:23:37Z

/ok-to-test sha=f2385dfda12cac8739c217aa708a9dca86bbdb33

github-actions · 2023-11-05T12:23:37Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6761260945.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

github-actions · 2023-11-05T12:24:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6761263320.
Workflow: Appsmith External Integration Test Workflow.
Commit: f2385dfda12cac8739c217aa708a9dca86bbdb33.
PR: 28480.

github-actions · 2023-11-05T12:34:35Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

github-actions · 2023-11-05T13:37:35Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6761263320.
Commit: f2385dfda12cac8739c217aa708a9dca86bbdb33.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/Bug27817_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategorySlider_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-11-06T03:04:10Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6761263320.
Commit: f2385dfda12cac8739c217aa708a9dca86bbdb33.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

vsvamsi1 · 2023-11-06T07:44:47Z

/build-deploy-preview skip-tests=true

github-actions · 2023-11-06T07:45:14Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6767721693.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28480.
recreate: .

vsvamsi1 · 2023-11-06T07:45:14Z

/ok-to-test sha=435dc942ce15c92068c918dcad26e48b31d316b1

github-actions · 2023-11-06T07:45:42Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6767725938.
Workflow: Appsmith External Integration Test Workflow.
Commit: 435dc942ce15c92068c918dcad26e48b31d316b1.
PR: 28480.

github-actions · 2023-11-06T07:57:50Z

Deploy-Preview-URL: https://ce-28480.dp.appsmith.com

github-actions · 2023-11-06T08:58:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767725938.
Commit: 435dc942ce15c92068c918dcad26e48b31d316b1.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Sliders/NumberSlider_spec.ts
cypress/e2e/Sanity/Datasources/MySQLNoiseTest_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-11-06T09:30:01Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767725938.
Commit: 435dc942ce15c92068c918dcad26e48b31d316b1.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-11-06T09:46:57Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767725938.
Commit: 435dc942ce15c92068c918dcad26e48b31d316b1.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

- Added new relic OTLP exporter to export eval traces, click event and api calls. - Conditionally loading both browser agent and OTLP scripts based on env variables. Fixes #28504 and #28506 - Chore (housekeeping or task changes that don't impact user perception) - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > > Add Testsmith test cases links that relate to this PR > > > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

## Description - Added new relic OTLP exporter to export eval traces, click event and api calls. - Conditionally loading both browser agent and OTLP scripts based on env variables. #### PR fixes following issue(s) Fixes #28504 and #28506 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

vsvamsi1 force-pushed the newRelicTest branch from 2a61803 to 922fde9 Compare October 31, 2023 07:44

vsvamsi1 force-pushed the newRelicTest branch from 922fde9 to fbe5b3b Compare November 1, 2023 12:10

vsvamsi1 requested a review from KelvinOm as a code owner November 1, 2023 12:10

KelvinOm mentioned this pull request Nov 1, 2023

Otlp integration #28545

Closed

20 tasks

vsvamsi1 marked this pull request as draft November 1, 2023 15:33

vsvamsi1 removed the request for review from KelvinOm November 1, 2023 19:34

rajatagrawal reviewed Nov 4, 2023

View reviewed changes

app/client/public/index.html Outdated Show resolved Hide resolved

rajatagrawal reviewed Nov 4, 2023

View reviewed changes

app/client/src/utils/WorkerUtil.ts Show resolved Hide resolved

vars fixes

f2385df

vsvamsi1 requested a review from rajatagrawal November 5, 2023 12:23

Updated cdn file location

435dc94

rajatagrawal approved these changes Nov 6, 2023

View reviewed changes

Aishwarya-U-R merged commit 7aa1c98 into release Nov 6, 2023
14 of 15 checks passed

Aishwarya-U-R deleted the newRelicTest branch November 6, 2023 09:35

chore: added new relic OTLP exporter #28480

chore: added new relic OTLP exporter #28480

Conversation

vsvamsi1 commented Oct 30, 2023 • edited

Description

PR fixes following issue(s)

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

vsvamsi1 commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

vsvamsi1 commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

vsvamsi1 commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

vsvamsi1 commented Nov 1, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

rajatagrawal Nov 4, 2023

Choose a reason for hiding this comment

vsvamsi1 Nov 5, 2023

Choose a reason for hiding this comment

rajatagrawal Nov 6, 2023

Choose a reason for hiding this comment

rajatagrawal Nov 6, 2023

Choose a reason for hiding this comment

sharat87 Nov 6, 2023

Choose a reason for hiding this comment

vsvamsi1 commented Nov 5, 2023

vsvamsi1 commented Nov 5, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 6, 2023

vsvamsi1 commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

vsvamsi1 commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

vsvamsi1 commented Oct 30, 2023 •

edited