Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RTL support for input, select and multi-select widget #28522

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

sbalaji1192
Copy link
Contributor

@sbalaji1192 sbalaji1192 commented Oct 31, 2023

PR fixes following issue(s)

Fixes #28469

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added the Enhancement New feature or request label Oct 31, 2023
@sbalaji1192
Copy link
Contributor Author

/build-deploy-preview skipTests=true

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6705468622.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 28522.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://ce-28522.dp.appsmith.com

@sbalaji1192
Copy link
Contributor Author

/build-deploy-preview skipTests=true

@sbalaji1192
Copy link
Contributor Author

/ok-to-test

Copy link

github-actions bot commented Nov 1, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6716401809.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 28522.
recreate: .

Copy link

github-actions bot commented Nov 1, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6716403839.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28522.

Copy link

github-actions bot commented Nov 1, 2023

Deploy-Preview-URL: https://ce-28522.dp.appsmith.com

Copy link

github-actions bot commented Nov 1, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6716403839.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
  3. cypress/e2e/Regression/ClientSide/Widgets/TreeSelect/Single_Select_Tree_spec.ts
  4. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
To know the list of identified flaky tests - Refer here

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Input Widget MultiSelect Widget Issues related to MultiSelect Widget Select Widget Select or dropdown widget labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6716403839.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

@sbalaji1192 sbalaji1192 marked this pull request as ready for review November 2, 2023 07:59
@sbalaji1192
Copy link
Contributor Author

/ok-to-test

Copy link

github-actions bot commented Nov 2, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6732615004.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28522.

Copy link

github-actions bot commented Nov 2, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732615004.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.js
  3. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts
  4. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
To know the list of identified flaky tests - Refer here

Copy link

github-actions bot commented Nov 2, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732615004.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@sbalaji1192
Copy link
Contributor Author

/build-deploy-preview skipTests=true

Copy link

github-actions bot commented Nov 3, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6742087973.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 28522.
recreate: .

Copy link

github-actions bot commented Nov 3, 2023

Deploy-Preview-URL: https://ce-28522.dp.appsmith.com

@sbalaji1192 sbalaji1192 merged commit dcaa460 into release Nov 3, 2023
39 of 40 checks passed
@sbalaji1192 sbalaji1192 deleted the feat/rtl-input-select branch November 3, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Enhancement New feature or request Input Widget MultiSelect Widget Issues related to MultiSelect Widget Select Widget Select or dropdown widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: RTL support for Input, Select and Multi-select widget
2 participants