-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WDS Checkbox Group Integration #28528
Conversation
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6713990027. |
Deploy-Preview-URL: https://ce-28528.dp.appsmith.com |
…-checkbox-group-widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor comment.
app/client/src/widgets/wds/WDSCheckboxGroupWidget/component/index.tsx
Outdated
Show resolved
Hide resolved
…-checkbox-group-widget
…-checkbox-group-widget
@KelvinOm @jsartisan @ichik - I'm not adding the "select all" property right now. I have looked into how we can do this effectively and I couldn't come up with an intuitive solution (in terms of writing a non-hacky code). I also think we can introduce this property at the WDS component level rather than the widget level. I have raised another ticket for this here - #28581 Let me know what you folks think. Edit - Slack thread here - https://theappsmith.slack.com/archives/C04P60V0VQE/p1698930191095249 |
/build-deploy-preview skip-tests=true |
/ok-to-test |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6732931351. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6732934054. |
Deploy-Preview-URL: https://ce-28528.dp.appsmith.com |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732934054.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732934054. |
Description
Adds WDSCheckboxGroup Widget.
PR fixes following issue(s)
Fixes #28102
Media
CleanShot.2023-11-01.at.05.39.16-converted.2.mp4
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed