Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WDS Checkbox Group Integration #28528

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

dhruvikn
Copy link
Contributor

@dhruvikn dhruvikn commented Nov 1, 2023

Description

Adds WDSCheckboxGroup Widget.

PR fixes following issue(s)

Fixes #28102

Media

CleanShot.2023-11-01.at.05.39.16-converted.2.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@dhruvikn dhruvikn added Enhancement New feature or request App Viewers Pod This label assigns issues to the app viewers pod Anvil POD Issue related to Anvil project WDS team labels Nov 1, 2023
@dhruvikn dhruvikn self-assigned this Nov 1, 2023
@dhruvikn dhruvikn requested a review from a team as a code owner November 1, 2023 00:23
@dhruvikn dhruvikn removed the request for review from a team November 1, 2023 00:24
@dhruvikn
Copy link
Contributor Author

dhruvikn commented Nov 1, 2023

/build-deploy-preview skip-tests=true

Copy link

github-actions bot commented Nov 1, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6713990027.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28528.
recreate: .

Copy link

github-actions bot commented Nov 1, 2023

Deploy-Preview-URL: https://ce-28528.dp.appsmith.com

KelvinOm
KelvinOm previously approved these changes Nov 1, 2023
jsartisan
jsartisan previously approved these changes Nov 2, 2023
Copy link
Contributor

@jsartisan jsartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor comment.

@dhruvikn dhruvikn dismissed stale reviews from KelvinOm and jsartisan via 8b03085 November 2, 2023 12:57
@dhruvikn
Copy link
Contributor Author

dhruvikn commented Nov 2, 2023

@KelvinOm @jsartisan @ichik - I'm not adding the "select all" property right now. I have looked into how we can do this effectively and I couldn't come up with an intuitive solution (in terms of writing a non-hacky code).

I also think we can introduce this property at the WDS component level rather than the widget level. I have raised another ticket for this here - #28581

Let me know what you folks think.

Edit - Slack thread here - https://theappsmith.slack.com/archives/C04P60V0VQE/p1698930191095249

@dhruvikn
Copy link
Contributor Author

dhruvikn commented Nov 2, 2023

/build-deploy-preview skip-tests=true

@dhruvikn
Copy link
Contributor Author

dhruvikn commented Nov 2, 2023

/ok-to-test

Copy link

github-actions bot commented Nov 2, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6732931351.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28528.
recreate: .

Copy link

github-actions bot commented Nov 2, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6732934054.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28528.

Copy link

github-actions bot commented Nov 2, 2023

Deploy-Preview-URL: https://ce-28528.dp.appsmith.com

Copy link

github-actions bot commented Nov 2, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732934054.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts
To know the list of identified flaky tests - Refer here

Copy link

github-actions bot commented Nov 2, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6732934054.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@dhruvikn dhruvikn merged commit 5b641b4 into release Nov 6, 2023
15 of 16 checks passed
@dhruvikn dhruvikn deleted the feat/integrate-wds-checkbox-group-widget branch November 6, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil POD Issue related to Anvil project App Viewers Pod This label assigns issues to the app viewers pod Enhancement New feature or request WDS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate WDS CheckboxGroup component with appsmith
3 participants