-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CE linting changes #28629
chore: CE linting changes #28629
Conversation
/ok-to-test sha=b6a5b59 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6746109011. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have deleted entityConstructorMap.ts from ce and ee. it should be common somewhere right? @Rishabh-Rathod
@ApekshaBhosale We won't be using entityConstructorMap anymore, this PR has new changes where we extend the entityFactory class. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6746109011.
|
/ok-to-test sha=b6a5b59 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6754552854. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6754552854.
To know the list of identified flaky tests - Refer here |
Description
PR fixes following issue(s)
Fixes # (issue number)
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed