Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CE linting changes #28629

Merged
merged 1 commit into from
Nov 5, 2023
Merged

chore: CE linting changes #28629

merged 1 commit into from
Nov 5, 2023

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Nov 3, 2023

Description

PR fixes following issue(s)

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 3, 2023
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=b6a5b59

Copy link

github-actions bot commented Nov 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6746109011.
Workflow: Appsmith External Integration Test Workflow.
Commit: b6a5b59.
PR: 28629.

@rishabhrathod01 rishabhrathod01 added skip-docs skip-testPlan Does not require QA intervention or approval process labels Nov 3, 2023
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have deleted entityConstructorMap.ts from ce and ee. it should be common somewhere right? @Rishabh-Rathod

@rishabhrathod01
Copy link
Contributor Author

rishabhrathod01 commented Nov 3, 2023

if you have deleted entityConstructorMap.ts from ce and ee. it should be common somewhere right? @Rishabh-Rathod

@ApekshaBhosale We won't be using entityConstructorMap anymore, this PR has new changes where we extend the entityFactory class.
This was the suggestion i got from FE coders.

Copy link

github-actions bot commented Nov 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6746109011.
Commit: b6a5b59.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/Button_Text_WithRecaptcha_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug27817_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
To know the list of identified flaky tests - Refer here

@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=b6a5b59

Copy link

github-actions bot commented Nov 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6754552854.
Workflow: Appsmith External Integration Test Workflow.
Commit: b6a5b59.
PR: 28629.

Copy link

github-actions bot commented Nov 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6754552854.
Commit: b6a5b59.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js

To know the list of identified flaky tests - Refer here

@Aishwarya-U-R Aishwarya-U-R merged commit ed1a662 into release Nov 5, 2023
22 of 24 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the chore/linting-changes branch November 5, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-docs skip-testPlan Does not require QA intervention or approval process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants