Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add transactional to the update protected branches #28649

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: Add transactional to the update protected branches #28649

merged 1 commit into from
Nov 6, 2023

Conversation

nayan-rafiq
Copy link
Contributor

Description

This PR makes the update branch protection API transactional.

PR fixes following issue(s)

Fixes #28648

Media

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • JUnit

Test Plan

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@nayan-rafiq nayan-rafiq self-assigned this Nov 6, 2023
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 6, 2023
@nayan-rafiq
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6767007514.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28649.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767007514.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Widgets/Form/FormWidget_Select_TreeSelect_spec.js
  4. cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategorySlider_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767007514.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts

To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767007514.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts

To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6767007514.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@nayan-rafiq
Copy link
Contributor Author

/ci-merge-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/6769722743
PR: 28649

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Either get 'Test Plan Approved' or 'skip-testPlan' added and try again!

@nayan-rafiq nayan-rafiq added the skip-testPlan Does not require QA intervention or approval process label Nov 6, 2023
@github-actions github-actions bot added Git Pod Anything related to git sync Git Version Control Issues related to version control labels Nov 6, 2023
@nayan-rafiq
Copy link
Contributor Author

/ci-merge-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/6769752563
PR: 28649

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Hurray!🎉 Proceeding to Merge!!!

@nayan-rafiq nayan-rafiq enabled auto-merge (squash) November 6, 2023 11:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/6769752563
PR: 28649

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Hurray!🎉 Proceeding to Merge!!!

@trishaanand trishaanand merged commit a40a88d into release Nov 6, 2023
20 of 21 checks passed
@trishaanand trishaanand deleted the chore/make-branch-protection-transactional branch November 6, 2023 11:14
nayan-rafiq pushed a commit that referenced this pull request Nov 14, 2023
chore: Add transactional to the update protected branches (#28649)
e19cb0c 
## Description
This PR makes the update branch protection API transactional.

#### PR fixes following issue(s)
Fixes #28648

#### Media
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
#### How Has This Been Tested?
- [ ] JUnit

#### Test Plan
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnaghHegde AnaghHegde AnaghHegde approved these changes

Assignees

@nayan-rafiq nayan-rafiq

Labels
Git Pod Anything related to git sync Git Version Control Issues related to version control skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan Does not require QA intervention or approval process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add transactional to the branch protection service
3 participants
@nayan-rafiq @AnaghHegde @trishaanand