Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix css for DS view mode #28755

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ayushpahwa
Copy link
Contributor

Description

Fixed css for view mode of DS config, change affects only EE feature custom environments

PR fixes following issue(s)

Fixes #28439

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Custom environments Issues with creating or working with custom environments Data Platform Pod Issues related to the underlying data platform Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Release Blocker This issue must be resolved before the release labels Nov 9, 2023
@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@ayushpahwa ayushpahwa added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan Does not require QA intervention or approval process labels Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6807595099.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28755.
recreate: .

@github-actions github-actions bot removed the Bug Something isn't working label Nov 9, 2023
@nidhi-nair nidhi-nair merged commit af845cd into release Nov 9, 2023
18 of 19 checks passed
@nidhi-nair nidhi-nair deleted the chore/28439-css-fix-for-ds-view-mode branch November 9, 2023 05:07
ayushpahwa added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Custom environments Issues with creating or working with custom environments Data Platform Pod Issues related to the underlying data platform Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan Does not require QA intervention or approval process
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Bug]: The scroll bar should be displayed on configuration page when there are more than 2 custom environments
3 participants