Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed logic for bottom bar visibility #28781

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: fixed logic for bottom bar visibility #28781

merged 1 commit into from
Nov 10, 2023

Conversation

ayushpahwa
Copy link
Contributor

Description

Fixed logic check for showing bottom bar from environmentList.length && to environmentList.length > 0 &&. This was causing the variable to be set as o instead of false.

PR fixes following issue(s)

Fixes #28778

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@ayushpahwa ayushpahwa requested a review from a team as a code owner November 10, 2023 05:59
@ayushpahwa ayushpahwa requested review from jsartisan and removed request for a team November 10, 2023 05:59
@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Release Blocker This issue must be resolved before the release View Mode Issues related to the view mode skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Bug Something isn't working labels Nov 10, 2023
@ayushpahwa ayushpahwa added the skip-testPlan Does not require QA intervention or approval process label Nov 10, 2023
@github-actions github-actions bot added the Bug Something isn't working label Nov 10, 2023
@trishaanand trishaanand merged commit 94e0ca0 into release Nov 10, 2023
16 of 17 checks passed
@trishaanand trishaanand deleted the hotfix/28778-env-switcher-logic-fix branch November 10, 2023 06:07
ayushpahwa added a commit that referenced this pull request Nov 10, 2023
@ayushpahwa
chore: fixed logic for bottom bar visibility (#28781)
0f74f70 
## Description
Fixed logic check for showing bottom bar from `environmentList.length
&&` to `environmentList.length > 0 &&`. This was causing the variable to
be set as o instead of false.

#### PR fixes following issue(s)
Fixes #28778

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

@jsartisan jsartisan Awaiting requested review from jsartisan jsartisan is a code owner automatically assigned from appsmithorg/app-viewers

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan Does not require QA intervention or approval process View Mode Issues related to the view mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Digit '0' & a horizontal scroll present at the bottom left of the screen
3 participants
@ayushpahwa @ankitakinger @trishaanand