Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema accordions don't open on search, placeholder for search input #28785

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

AmanAgarwal041
Copy link
Contributor

Description

This pr fixes:

  • Let schema table accordions be closed on searching table
  • Search placheholder changed to Search for table

PR fixes following issue(s)

Fixes #28750

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added Bug Something isn't working Integrations Pod Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Postgres Postgres related issues labels Nov 10, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6822854652.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28785.
recreate: .

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6822855918.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28785.

Copy link

Deploy-Preview-URL: https://ce-28785.dp.appsmith.com

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6822855918.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts

  2. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/e2e/Regression/ClientSide/Linting/EntityPropertiesLint_spec.ts
  4. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6824375297.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28785.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6824375297.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

@rohan-arthur
Copy link
Contributor

tested this, LGTM

@rohan-arthur rohan-arthur added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 13, 2023
@hetunandu hetunandu merged commit 2e90243 into release Nov 13, 2023
15 of 17 checks passed
@hetunandu hetunandu deleted the fix/28750-schema-accordions branch November 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Integrations Pod Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Postgres Postgres related issues Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Datasource schema accordions opened on search, clearing search
4 participants