Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle data update for query execution failure #28841

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Handle data update for query execution failure #28841

merged 2 commits into from
Nov 16, 2023

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Nov 14, 2023 •
edited

Description

Sets query data to undefined when execution fails

PR fixes following issue(s)

Fixes #28817

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added the Bug Something isn't working label Nov 14, 2023
@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions github-actions bot added Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform Needs Triaging Needs attention from maintainers to triage labels Nov 14, 2023
@ohansFavour
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6861498106.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6861501653.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28841.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-28841.dp.appsmith.com

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6861498106.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug26941_Spec.ts

  2. cypress/e2e/Regression/ClientSide/BugTests/CatchBlock_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  4. cypress/e2e/Regression/ServerSide/ApiTests/API_All_Verb_spec.js
  5. cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
  6. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/False_Spec.ts
  7. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  8. cypress/e2e/Regression/ServerSide/QueryPane/EmptyDataSource_spec.js
  9. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  10. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
  11. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  12. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6861498106.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug26941_Spec.ts

  2. cypress/e2e/Regression/ClientSide/BugTests/CatchBlock_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  4. cypress/e2e/Regression/ServerSide/ApiTests/API_All_Verb_spec.js
  5. cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
  6. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/False_Spec.ts
  7. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  8. cypress/e2e/Regression/ServerSide/QueryPane/EmptyDataSource_spec.js
  9. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  10. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
  11. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  12. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Evaluated Value Issues related to evaluated values FE Coders Pod Issues related to users writing javascript in appsmith labels Nov 14, 2023
@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6870065527.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6870065527.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug26941_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/e2e/Regression/ServerSide/ApiTests/API_All_Verb_spec.js
  4. cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
  5. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  6. cypress/e2e/Regression/ServerSide/QueryPane/EmptyDataSource_spec.js
  7. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  8. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  9. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6870065527.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug26941_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/e2e/Regression/ServerSide/ApiTests/API_All_Verb_spec.js
  4. cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
  5. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  6. cypress/e2e/Regression/ServerSide/QueryPane/EmptyDataSource_spec.js
  7. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  8. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  9. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@ohansFavour ohansFavour force-pushed the fix/handle-failed-query-execution branch from 1a8671f to 5a34ac3 Compare November 15, 2023 17:03
@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6880540521.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6880554167.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6880554167.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug18035_Spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js
  3. cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts
  4. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6880540521.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug18035_Spec.ts
  3. cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js
  4. cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts
  5. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6880540521.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug18035_Spec.ts
  3. cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js
  4. cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts
  5. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
To know the list of identified flaky tests - Refer here

@ohansFavour
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6886839178.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28841.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-28841.dp.appsmith.com

@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6887174826.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6887174826.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug18035_Spec.ts
  3. cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js
  4. cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
  5. cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts
To know the list of identified flaky tests - Refer here

@ohansFavour ohansFavour force-pushed the fix/handle-failed-query-execution branch from 898aef8 to 1f5b2e8 Compare November 16, 2023 16:36
@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6893718814.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28841.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6893718814.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js

  2. cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6893718814.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@ohansFavour ohansFavour merged commit c7350c3 into release Nov 16, 2023
15 of 16 checks passed
@ohansFavour ohansFavour deleted the fix/handle-failed-query-execution branch November 16, 2023 19:14
@ohansFavour ohansFavour mentioned this pull request Nov 29, 2023
Merged
20 tasks
ohansFavour added a commit that referenced this pull request Nov 29, 2023
@ohansFavour
fix: revert #28841 (#29197)
2f09239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunvjn arunvjn arunvjn approved these changes

@ayushpahwa ayushpahwa Awaiting requested review from ayushpahwa ayushpahwa is a code owner

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform Evaluated Value Issues related to evaluated values FE Coders Pod Issues related to users writing javascript in appsmith Needs Triaging Needs attention from maintainers to triage
Projects
Data Platform Pod
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Query data is set to an error message when datasource is incorrectly configured
2 participants
@ohansFavour @arunvjn