feat: Transform API/Query data based on widget's expected data type after 1-click binding #28890
Conversation
github-actions
bot
added
Enhancement
|
/ok-to-test |
|
/build-deploy-preview skip-tests=true |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6886815996. |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6886816594. |
|
Deploy-Preview-URL: https://ce-28890.dp.appsmith.com |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6886815996.
|
|
/ok-to-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6887683341. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6887683341.
|
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6887683341.
To know the list of identified flaky tests - Refer here |
ohansFavour
force-pushed
the
feat/use-suggested-binding-in-one-click-binding
branch
from
8438701
to
0be7b61
Compare
|
/ok-to-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6893725902. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6893725902.
|
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6893725902.
To know the list of identified flaky tests - Refer here |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6893725902. |
ohansFavour
deleted the
feat/use-suggested-binding-in-one-click-binding
branch
…fter 1-click binding (#28890) ## Description In this PR, transformed API/Query data ( based on the widget's expected data type) is used after 1-click binding. This is aimed at improving 1-click binding success. #### PR fixes following issue(s) Fixes #28731 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
Description
In this PR, transformed API/Query data ( based on the widget's expected data type) is used after 1-click binding. This is aimed at improving 1-click binding success.
PR fixes following issue(s)
Fixes #28731
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approvedlabel after Cypress tests were reviewedTest Plan Approvedlabel after JUnit tests were reviewed