chore: Refine WDS dimension tokens #31158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichik
added
skip-changelog
KelvinOm
reviewed
Feb 16, 2024
ichik
force-pushed
the
chore/refine-wds-dimension-tokens
branch
from
0d16dc0
to
a04e90a
Compare
|
More things could be improved (i.e., title variants), but I suggest we merge this as a stop-gap since we also don't have a conclusion on widgets' block sizing. I'd rather move on it iteratively.
|
KelvinOm
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30890
This is not a full refinement, because we set height/block-size explicitly for some of our widgets with styles such as these. As such, changes to e.g. inner spacing only affect the horizontal/inline size and not the vertical/block one since the block padding doesn't affect an element that has block size set explicitly.
Ideally, we should switch to implicit sizing to fully embrace multi-dimensional sizing and density theming control over the widget dimensions (i.e. control it with padding that consumes the tokens of the inner spacing scale). If that is not feasible I'd like to know why and how we can closely tie together the sizing scale with inner spacing.