Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run button hiding issue #31323

Merged
merged 2 commits into from Feb 28, 2024
Merged

fix: Run button hiding issue #31323

merged 2 commits into from Feb 28, 2024

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Feb 28, 2024

Description

Run button in queries and js page was getting squeezed when file name is longer.

PR fixes following issue(s)

Fixes #31298

Media

Before

Screen.Recording.2024-02-28.at.10.01.47.AM.mov

After

Screen.Recording.2024-02-28.at.10.06.36.AM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • Style
    • Enhanced styling and layout control across various editor components for improved user experience.
    • Adjusted widths and overflow properties for cleaner, more consistent visual presentation.
    • Introduced new layout properties to components for better alignment and spacing, ensuring a more intuitive interface.

Copy link
Contributor

coderabbitai bot commented Feb 28, 2024

Walkthrough

Walkthrough

The modifications across various files primarily focus on improving UI components' layout and styling within the editor environment. By substituting div elements with the Flex component, the changes bring enhanced alignment, spacing, and overflow handling capabilities. Additionally, adjustments in styling rules, particularly in widths and margins, aim to refine the visual coherence and usability of name editing functionalities across different editor sections.

Changes

Files Change Summary
.../editorComponents/ActionNameEditor.tsx
.../JSEditor/JSObjectNameEditor.tsx
Replaced div with Flex component, adding alignItems, gap, overflow, and width properties.
.../utils/NameEditorComponent.tsx Updated styling for elements within NameWrapper; adjusted widths and removed margin-right.
.../JSEditor/styledComponents.ts
.../QueryEditor/QueryEditorHeader.tsx
Added width: 50%; and overflow: hidden; to NameWrapper and similar styling to ActionsWrapper.

Related issues

  • appsmithorg/appsmith#31298: Although the changes in this PR focus on layout and styling improvements within editor components, they do not directly address the visibility issue of the "Run" button as outlined in the issue. Therefore, this issue may not be directly linked to the PR without further investigation into whether any of the layout changes inadvertently impact the "Run" button's visibility.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Bug Something isn't working labels Feb 28, 2024
@albinAppsmith
Copy link
Collaborator Author

/ok-to-test tags="@tag.Sanity, @tag.IDE"

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8075364598.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Sanity, @tag.IDE.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8075364598.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu merged commit 0640b5e into release Feb 28, 2024
20 checks passed
@hetunandu hetunandu deleted the run-button-hiding-issue branch February 28, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Run button getting hidden in side by side
2 participants