New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use queryBuilder for count op #31328
Conversation
WalkthroughWalkthroughThe update involves refining the way a MongoDB query is constructed and executed within a specific Java class. Instead of manually creating a query for counting documents based on a datasource ID, the code now leverages a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
...erver/src/main/java/com/appsmith/server/repositories/ce/CustomNewActionRepositoryCEImpl.java
Show resolved
Hide resolved
@@ -351,12 +350,9 @@ public Mono<Long> countByDatasourceId(String datasourceId) { | |||
where(NewAction.Fields.publishedAction + ".datasource._id").is(new ObjectId(datasourceId)); | |||
|
|||
Criteria datasourceCriteria = | |||
notDeleted().orOperator(unpublishedDatasourceCriteria, publishedDatasourceCriteria); | |||
new Criteria().orOperator(unpublishedDatasourceCriteria, publishedDatasourceCriteria); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever happened to the notDeleted
clause? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Down the call-stack. it always gets added by the queryBuilder
API. It's not optional today, notDeleted
is always included in all calls of the queryBuilder
API.
Here's the line that does this:
Line 224 in 1858fb9
criteriaList.add(notDeleted()); |
Summary by CodeRabbit