Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Last selected js function / response does not load up #31495

Merged
merged 1 commit into from Mar 5, 2024

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Mar 5, 2024

fixes: #31494

Summary by CodeRabbit

  • Refactor
    • Enhanced initialization of the currently active response in the JSEditorForm to improve user interaction.

Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

Walkthrough

The change addresses a user experience issue in the IDE's JavaScript editor, where previously, navigating away from a JS Editor and returning would result in the last executed function's response not being loaded back. By initializing activeResponse with activeJSAction, the editor now retains and displays the last response, improving the consistency of the user interface and reducing confusion for users working with multiple JavaScript functions.

Changes

File Path Change Summary
.../Editor/JSEditor/Form.tsx Initialize activeResponse with activeJSAction instead of null

Assessment against linked issues

Objective Addressed Explanation
[#31494]: Load back last response when visiting JS Editor again

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE labels Mar 5, 2024
@hetunandu
Copy link
Member Author

/ok-to-test tags="@tag.JS"

Copy link

github-actions bot commented Mar 5, 2024

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8156062940.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.JS.

@Nikhil-Nandagopal Nikhil-Nandagopal added Release Low An issue that is neither critical nor breaks a user flow labels Mar 5, 2024
@github-actions github-actions bot added Medium Issues that frustrate users due to poor UX Production labels Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8156062940.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu merged commit 52ae6e0 into release Mar 5, 2024
22 checks passed
@hetunandu hetunandu deleted the fix/js-active-action-persistence branch March 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JS Editor does not load back last response when visited again
3 participants