Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Routing issues in Side by Side #31551

Merged
merged 5 commits into from Mar 8, 2024
Merged

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Mar 6, 2024

Description

Fixes certain navigation and routing issues in Side by Side

fixes: #31408
fixes: #31451
fixes: #31458

Summary by CodeRabbit

  • New Features
    • Added the CurlImportEditor component and routes for curl import functionality in the query editor.
  • Enhancements
    • Improved reactivity in the SplitScreenTabs component to changes in pageId.

Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Walkthrough

The recent updates primarily focus on enhancing navigation and state management across the application, introducing a new component for curl import functionality within the query editor, and improving the reactivity of components to changes in navigation and page IDs. These changes aim to address specific bugs related to the query editor appearing empty when adding a new curl API, the queries section being visible in preview mode instead of the canvas, and incorrect page references when navigating between queries.

Changes

File Path Change Summary
.../Editor/IDE/EditorPane/Query/hooks.ts Added CurlImportEditor component and routes for curl import functionality within the query editor.
.../Editor/IDE/EditorTabs/SplitScreenTabs.tsx Enhanced reactivity by adding pageId to the useEffect dependency array in SplitScreenTabs.

Assessment against linked issues

Objective Addressed Explanation
#31408: The new query editor looks empty when user tries to add the new curl API
#31451: Queries section is seen in the preview mode instead of the canvas The changes do not directly address the visibility of the queries section in preview mode, but improvements in navigation and state management could indirectly impact this issue.
#31458: Page reference is incorrect on navigating between queries Adjustments in navigation and state management likely address the issue of maintaining correct page references.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users IDE Navigation Issues/feature requests related to IDE navigation, and context switching Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production Release labels Mar 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Low An issue that is neither critical nor breaks a user flow label Mar 6, 2024
@hetunandu
Copy link
Member Author

/ok-to-test tags="@tag.IDE"

Copy link

github-actions bot commented Mar 6, 2024

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8169661402.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.IDE.

Copy link

github-actions bot commented Mar 6, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8169661402.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu enabled auto-merge (squash) March 6, 2024 09:51
@github-actions github-actions bot added the PR blocker Critical issues raised during feature testing & need to be fixed before PR is pushed to master label Mar 7, 2024
@hetunandu
Copy link
Member Author

/ok-to-test tags="@tag.IDE"

Copy link

github-actions bot commented Mar 7, 2024

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8188105050.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.IDE.

This comment was marked as outdated.

This comment was marked as outdated.

@hetunandu
Copy link
Member Author

/ok-to-test tags="@tag.IDE"

Copy link

github-actions bot commented Mar 8, 2024

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8198939657.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.IDE.

Copy link

github-actions bot commented Mar 8, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8198939657.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu merged commit 035f744 into release Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE PR blocker Critical issues raised during feature testing & need to be fixed before PR is pushed to master Production Release
Projects
None yet
3 participants